Uh oh!
There was an error while loading. Please reload this page.
[tests] update NUnit to 3.7.1 - #973
Merged
Merged
Conversation
dnfclas
commented
Oct 25, 2017
@jonathanpeppers, |
MemberAuthor
No hang, but the tests I checked seemed to fail with the same thing: |
akoeplinger
approved these changes
Oct 25, 2017
akoeplinger
left a comment
Member
There was a problem hiding this comment.
I tried this locally and it fixes the hang for me, nice find!
The test failures look unrelated (and don't happen locally).
dellis1972
commented
Oct 25, 2017
Contributor
build |
dellis1972
approved these changes
Oct 25, 2017
jonpryor
commented
Oct 25, 2017
Contributor
Please rebase atop master/PR #977. |
Context: https://github.com/nunit/nunit/releases/tag/3.7.1 The release notes for NUnit 3.7.1 mention a hang with parallelized tests, so it is worth a try to see if updating fixes it. Reverting 6687dac as well to see if we get a green build.
jonathanpeppersforce-pushed
the
nunit-3.7.1
branch
from
October 25, 2017 19:47
68ec25d to
4e808a9Compareakoeplinger
commented
Oct 25, 2017
Member
the test failures look unrelated :) |
Redth pushed a commit
to Redth/xamarin-android
that referenced
this pull request
Oct 30, 2017
Context: https://github.com/nunit/nunit/releases/tag/3.7.1 Context: commit 6687dac The release notes for NUnit 3.7.1 mention a hang with parallelized tests, so it is worth a try to see if updating fixes it the hangs that we experienced and tried to workaround in 6687dac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/nunit/nunit/releases/tag/3.7.1
The release notes for NUnit 3.7.1 mention a hang with parallelized
tests, so it is worth a try to see if updating fixes it.
Reverting 6687dac as well to see if we get a green build.