Uh oh!
There was an error while loading. Please reload this page.
[Mono.Android-Tests] Remove obsolete .shproj file. - #9758
Merged
Conversation
jpobstforce-pushed
the
dev/jpobst/mono-android-tests
branch
4 times, most recently
from
February 6, 2025 21:13
4302875 to
9c80d50Compare.shproj file..shproj file.jpobstforce-pushed
the
dev/jpobst/mono-android-tests
branch
2 times, most recently
from
February 10, 2025 19:40
d9a90d6 to
817e1bcComparejpobst
marked this pull request as ready for review
February 10, 2025 23:39
jonathanpeppers
left a comment
Member
There was a problem hiding this comment.
Did I misread the diff, or did a couple tests get deleted on accident?
Comment on lines
-9
to
-16
| [TestFixture] | ||
| public class HandlerTest { | ||
| [Test] | ||
| public void RemoveDisposedInstance () | ||
| { | ||
| using (var t = new HandlerThread ("RemoveDisposedInstance")) { | ||
| t.Start (); |
There was a problem hiding this comment.
I don't think we should delete this one?
Comment on lines
-5
to
-17
| namespace Xamarin.Android.RuntimeTests | ||
| { | ||
| [TestFixture] | ||
| public class LocalizationTests | ||
| { | ||
| // https://bugzilla.xamarin.com/show_bug.cgi?id=31705 | ||
| [Test] | ||
| public void EmbeddedResources_ShouldBeLocalized () | ||
| { | ||
| CultureInfo culture = Thread.CurrentThread.CurrentCulture; | ||
| CultureInfo uiCulture = Thread.CurrentThread.CurrentUICulture; | ||
| Assert.AreEqual ("a", AppResources.String1, "Embedded string resource did not contain expected value."); |
jpobst
commented
Feb 11, 2025
ContributorAuthor
I removed tests that are not being run today in |
jonathanpeppers
commented
Feb 11, 2025
Member
The two above look like they should pass, but |
jpobstforce-pushed
the
dev/jpobst/mono-android-tests
branch
3 times, most recently
from
February 11, 2025 23:01
3c993eb to
36cabc7Comparejpobst
commented
Feb 12, 2025
ContributorAuthor
👍 Tests enabled. |
jonathanpeppers
approved these changes
Feb 12, 2025
pjcollins
approved these changes
Feb 12, 2025
jpobstforce-pushed
the
dev/jpobst/mono-android-tests
branch
from
February 12, 2025 18:38
36cabc7 to
678d36dComparejonathanpeppers pushed a commit
that referenced
this pull request
Feb 13, 2025
Context: #9758 While enabling new tests for `Mono.Android-Tests`, git somehow ate my files and made them all empty. I fixed the ones that CI found but didn't notice the other empty files. Add the content of these files back. Verified on CI run that the 2 new tests are indeed being run and succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mono.Android-Testsstill uses a.shprojfile from the time when we had both a Classic XA and .NET version. However, VS does not seem to support this anymore, and none of the included files appear in the IDE, making it hard to write new tests.Remove the
.shprojfile and update the.csprojfile to directly point to needed files.Also do some other cleanups like removing tests that are no longer run and fixing directory structure.
Verified that both the
mainversion and this PR run 885 tests on CI.