Uh oh!
There was an error while loading. Please reload this page.
[XABT] remove $(_AndroidUseLibZipSharp)=true default value - #9840
Merged
Conversation
This was referenced Feb 25, 2025
jonathanpeppers
commented
Feb 25, 2025
MemberAuthor
I believe this has a new issue now: |
jonathanpeppers
marked this pull request as draft
February 25, 2025 15:24
Context: dotnet/runtime#112017 In .NET 10 Preview 1, when using System.IO.Compression to create `.apk` files, `zipalign` was giving the error: 01-30 21:38:27.669 38611 159726 W zip : WARNING: header mismatch To workaround, we temporarily set `$(_AndroidUseLibZipSharp)=true`. We think this is fixed now, so partially revert f3ef4fe.
jonathanpeppersforce-pushed
the
dev/peppers/_AndroidUseLibZipSharp
branch
from
April 17, 2025 15:34
b71bce5 to
ac295a0CompareUpdate: We're hoping this will be resolved with the latest fixes:
We also added async support if you have a chance to test it:
|
MemberAuthor
So far this looks good, the MSBuild tests build many projects using I restarted a few of the lanes that the Android emulator timed out. |
jonathanpeppers
marked this pull request as ready for review
April 17, 2025 20:00
jpobst
approved these changes
Apr 17, 2025
jpobst
left a comment
Contributor
There was a problem hiding this comment.
🥳 Yay! Thank you everyone for helping us ship this performance win for our users!
jonathanpeppers
commented
Apr 17, 2025
MemberAuthor
The test lanes I reran are now failing due to something with AzDO downloading secrets: I think this is safe to merge, because 100s of tests were failing when this wasn't working. We can revisit if something comes up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: dotnet/runtime#112017
Context: dotnet/runtime#113306
In .NET 10 Preview 1, when using System.IO.Compression to create
.apkfiles,zipalignwas giving the error:To workaround, we temporarily set
$(_AndroidUseLibZipSharp)=true.We think this is fixed now, so partially revert f3ef4fe.