') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); })(); PortToDocs: Add methods that either collect files automatically, or allow passing documents manually by carlossanlop · Pull Request #110 · dotnet/api-docs-sync · GitHub
Skip to content

PortToDocs: Add methods that either collect files automatically, or allow passing documents manually - #110

Merged
carlossanlop merged 3 commits into
dotnet:mainfrom
carlossanlop:PortToDocsFileCollect
Mar 17, 2022
Merged

PortToDocs: Add methods that either collect files automatically, or allow passing documents manually#110
carlossanlop merged 3 commits into
dotnet:mainfrom
carlossanlop:PortToDocsFileCollect

Conversation

@carlossanlop

@carlossanlopcarlossanlop commented Mar 15, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Unit testing is too hard in the PortToDocs project because the only method we currently use requires creating real files and modifying them as they would in a real use case scenario.

We can keep the tests we already have but we should also have the ability to create tests that don't depend on the filesystem and which allow passing the document to read and the document to write.

This is the first iteration. In the next iteration (maybe next commit, or maybe next PR) I will add unit tests using this simplified process.

@carlossanlopcarlossanlop mentioned this pull request Mar 16, 2022
Open
14 tasks
@carlossanlop
carlossanlop merged commit 149a093 into dotnet:mainMar 17, 2022
@carlossanlop
carlossanlop deleted the PortToDocsFileCollect branch March 17, 2022 17:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
1 more reviewer
@RussKieRussKieRussKie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlossanlop@RussKie