') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Merge carlossanlop/main with jeffhandley/retain-directives by carlossanlop · Pull Request #99 · dotnet/api-docs-sync · GitHub
Skip to content

Merge carlossanlop/main with jeffhandley/retain-directives - #99

Closed
carlossanlop wants to merge 7 commits into
mainfrom
merge-retain-directives
Closed

Merge carlossanlop/main with jeffhandley/retain-directives#99
carlossanlop wants to merge 7 commits into
mainfrom
merge-retain-directives

Conversation

@carlossanlop

@carlossanlopcarlossanlop commented Sep 10, 2021

Copy link
Copy Markdown
Contributor

@jeffhandley I pulled all the changes in main into a copy of your branch, and this is the result.

If you're ok with that, let's work on this branch from now on. I will leave some comments summarizing what's new.

carlossanlop
carlossanlop commented Sep 10, 2021
View reviewed changes
Comment threadTests/DocsApi/TestDocsApi.cs
Comment on lines +15 to +16
public override string ReturnType { get; }
public override string Returns { get; set; }

@carlossanlopcarlossanlopSep 10, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only manual change I had to add so the project could build: The DocsAPI abstract class now implements ReturnType and Returns. This is because delegates are Types, and they can have a return value, just like a Member method.

@carlossanlop

carlossanlop commented Sep 10, 2021

Copy link
Copy Markdown
ContributorAuthor

Next step: Figure out why the Roslyn VSInstance code is not working... again. I updated the dependencies, but I'm still having trouble getting it to work.

@carlossanlopcarlossanlop mentioned this pull request Oct 20, 2021
Open
14 tasks
@RussKie
Fix build
2683435
@RussKie
Clean up tests
40cfe78
* Use Verify tests to visually assert correctness
* Remove redundant "source" files
@RussKie
Streamline package versions management with Microsoft.Build.CentralPa…
4bb7079
…ckageVersions
See https://github.com/Microsoft/MSBuildSdks
@RussKie
RussKieforce-pushed the merge-retain-directives branch from 4969711 to 4bb7079CompareDecember 7, 2021 05:29
@RussKie

RussKie commented Dec 9, 2021

Copy link
Copy Markdown
Contributor

@carlossanlop@jeffhandley I've been trying to fix tests but it's painfully slow and at times I get completely lost... Am I moving in the right direction?

@carlossanlop
carlossanlop deleted the merge-retain-directives branch July 25, 2023 16:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlossanlop@RussKie