Skip to content

Merging internal commits for release/6.0 - #47652

Merged
wtgodbe merged 24 commits into
dotnet:release/6.0from
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Apr 12, 2023
Merged

Merging internal commits for release/6.0#47652
wtgodbe merged 24 commits into
dotnet:release/6.0from
vseanreesermsft:internal-merge-6.0-2023-04-11-1028

Conversation

@vseanreesermsft

@vseanreesermsftvseanreesermsft commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

No description provided.

dotnet-botand others added 23 commits March 7, 2023 22:17
@dotnet-bot
Merge in 'release/6.0' changes
f0b89db
@dotnet-bot
Merge in 'release/6.0' changes
48345db
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
92609a4
…t-efcore
@dotnet-bot
Merge in 'release/6.0' changes
03626ad
@dotnet-bot
Merge in 'release/6.0' changes
fb6bff7
@dotnet-bot
Merge in 'release/6.0' changes
e40b13e
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
f971c03
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
2e6b193
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
98b903b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
23cbd6b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
798ac3d
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
9c56c4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
92f3976
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
56b0b4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
0e2c1b3
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
732cd26
…t-efcore
@mmitche
Merged PR 30049: [internal/release/6.0] Merge from public
642c823
Merge from public release/6.0 to internal/release/6.0 and resolve conflicts if necessary
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
206b88e
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
bb8d881
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
7a292a4
…t-efcore
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
41a6490
…t-runtime
@dotnet-bot@mmitche
Merged PR 30222: [internal/release/6.0] Update dependencies from dnce…
d6f154c
…ng/internal/dotnet-runtime
This pull request updates the following dependencies
[marker]: <> (Begin:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 7745f62d-e15b-4ba3-39b3-08d960f4ca81
- **Build**: 20230323.11
- **Date Produced**: March 24, 2023 6:12:38 PM UTC
- **Commit**: 1e620a42e71ca8c7efb033fd525f04be5fa701fe
- **Branch**: refs/heads/internal/release/6.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Ref**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.win-x64**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NETCore.Platforms**: [from 6.0.9 to 6.0.9][1]
[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC567ff53ac7&targetVersion=GC1e620a42e7&_a=files
[DependencyUpdate]: <> (End)
[marker]: <> (End:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
@vseanreesermsft
Merge commit 'd6f154cca3863703cf87c8b840eea9cbe20229b2' into internal…
017655f
…-merge-6.0-2023-04-11-1028
@ghostghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 11, 2023
@ghostghost added this to the 6.0.x milestone Apr 11, 2023
@ghost

ghost commented Apr 11, 2023

Copy link
Copy Markdown

Hi @vseanreesermsft. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost

ghost commented Apr 11, 2023

Copy link
Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe
wtgodbe requested a review from a team as a code ownerApril 11, 2023 17:55
@wtgodbe

wtgodbe commented Apr 11, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Got some Components-e2e failures, @MackinnonBuck could you take a look?

Microsoft.AspNetCore.Components.E2ETest.Tests.ComponentRenderingTest.CanHandleClearedChild

Assert.DoesNotContain() Failure
Found: (filter expression)
In value: ReadOnlyCollection [[2023-04-11T18:43:04Z] [Info] http://127.0.0.1:42599/subdir/_framework/blazor.webassembly.js 0:35640 "Handle blur...", [2023-04-11T18:43:09Z] [Debug] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:131187 "mono_wasm_runtime_ready" "fe00e07a-5519-4dfe-b35a-f867dbaf2e28", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>"]

@MackinnonBuck

MackinnonBuck commented Apr 11, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Looks like some tests are failing because there are errors in the console.

@pavelsavara Do you know what might be happening here? From what I can tell, application functionality hasn't broken in any way other than outputting this error in the console.

dotnet.6.0.16.9vxckk6r1z.js:1 /__w/1/s/src/mono/mono/eglib/gpath.c:115 <disabled>
580850 @ dotnet.6.0.16.9vxckk6r1z.js:1
_emscripten_asm_const_int @ dotnet.6.0.16.9vxckk6r1z.js:1
$func111 @ dotnet.wasm:0x94bd
$func2230 @ dotnet.wasm:0x8ebb3
$func3483 @ dotnet.wasm:0xcc2e7
$func3484 @ dotnet.wasm:0xcc318
$func3485 @ dotnet.wasm:0xcc34b
$func3552 @ dotnet.wasm:0xcd83e
$func2078 @ dotnet.wasm:0x862e3
$func2076 @ dotnet.wasm:0x85de1
$func1338 @ dotnet.wasm:0x653d0
$func328 @ dotnet.wasm:0x255f4
$func310 @ dotnet.wasm:0x1eb55
$func361 @ dotnet.wasm:0x27e5b
$func214 @ dotnet.wasm:0x1a03b
$func167 @ dotnet.wasm:0x18991
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$func3217 @ dotnet.wasm:0xc4e86
$mono_background_exec @ dotnet.wasm:0x9433f
Module._mono_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
pump_message @ dotnet.6.0.16.9vxckk6r1z.js:1
setTimeout (async)
_schedule_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
$func2392 @ dotnet.wasm:0x942f0
$func3216 @ dotnet.wasm:0xc4e16
$func219 @ dotnet.wasm:0x1a529
$func167 @ dotnet.wasm:0xce8f
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$mono_wasm_invoke_method @ dotnet.wasm:0x969f
Module._mono_wasm_invoke_method @ dotnet.6.0.16.9vxckk6r1z.js:1
_call_method_with_converted_args @ dotnet.6.0.16.9vxckk6r1z.js:1
call_method @ dotnet.6.0.16.9vxckk6r1z.js:1
(anonymous) @ dotnet.6.0.16.9vxckk6r1z.js:1
call_assembly_entry_point @ dotnet.6.0.16.9vxckk6r1z.js:1
callEntryPoint @ MonoPlatform.ts:61
At @ Boot.WebAssembly.ts:135
await in At (async)
(anonymous) @ Boot.WebAssembly.ts:218
(anonymous) @ blazor.webassembly.js:1

@pavelsavara

pavelsavara commented Apr 12, 2023

Copy link
Copy Markdown
Member

I don't know yet.

@kg@radekdoulik any thoughts ?

@pavelsavara

pavelsavara commented Apr 12, 2023

Copy link
Copy Markdown
Member

/mono/mono/eglib/gpath.c:115 is g_path_get_dirname with NULL filename

@lewing

lewing commented Apr 12, 2023

Copy link
Copy Markdown
Member

@elinor-fung I think this is the dllimport change breaking blazor

@lewinglewing mentioned this pull request Apr 12, 2023
Merged
@elinor-fung

elinor-fung commented Apr 12, 2023

Copy link
Copy Markdown
Member

Looks like 6.0 didn't have the null check: dotnet/runtime#60445

Just to double check - this is a log message, not a 'crashing the world', right?

@wtgodbe

wtgodbe commented Apr 12, 2023

Copy link
Copy Markdown
Member

Test failure fixed by dotnet/runtime#84740

@wtgodbe
wtgodbe merged commit 5629320 into dotnet:release/6.0Apr 12, 2023
@ghostghost modified the milestones: 6.0.x, 6.0.17Apr 12, 2023
@lewinglewing mentioned this pull request Apr 12, 2023
Merged
@lewing

lewing commented Apr 12, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Looks like 6.0 didn't have the null check: dotnet/runtime#60445

Just to double check - this is a log message, not a 'crashing the world', right?

no this is crashing the world when that path gets hit

@ghost

ghost commented Apr 12, 2023

Copy link
Copy Markdown

Hi @lewing. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbewtgodbeAwaiting requested review from wtgodbe

Assignees

No one assigned

Labels

area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

6.0.17

Development

Successfully merging this pull request may close these issues.

8 participants

@vseanreesermsft@wtgodbe@MackinnonBuck@pavelsavara@lewing@elinor-fung@dotnet-bot@mmitche
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Merging internal commits for release/6.0 by vseanreesermsft · Pull Request #47652 · dotnet/aspnetcore · GitHub
Skip to content
Merging internal commits for release/6.0 - #47652
Merged
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Apr 12, 2023
Merged
Merging internal commits for release/6.0#47652
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Conversation
@vseanreesermsft
@vseanreesermsftvseanreesermsft
commented
Apr 11, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
dotnet-botand others
added 23 commits
March 7, 2023 22:17
@dotnet-bot
Merge in 'release/6.0' changes
f0b89db
@dotnet-bot
Merge in 'release/6.0' changes
48345db
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
92609a4
…t-efcore
@dotnet-bot
Merge in 'release/6.0' changes
03626ad
@dotnet-bot
Merge in 'release/6.0' changes
fb6bff7
@dotnet-bot
Merge in 'release/6.0' changes
e40b13e
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
f971c03
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
2e6b193
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
98b903b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
23cbd6b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
798ac3d
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
9c56c4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
92f3976
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
56b0b4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
0e2c1b3
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
732cd26
…t-efcore
@mmitche
Merged PR 30049: [internal/release/6.0] Merge from public
642c823
Merge from public release/6.0 to internal/release/6.0 and resolve conflicts if necessary
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
206b88e
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
bb8d881
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
7a292a4
…t-efcore
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
41a6490
…t-runtime
@dotnet-bot@mmitche
Merged PR 30222: [internal/release/6.0] Update dependencies from dnce…
d6f154c
…ng/internal/dotnet-runtime
This pull request updates the following dependencies
[marker]: <> (Begin:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 7745f62d-e15b-4ba3-39b3-08d960f4ca81
- **Build**: 20230323.11
- **Date Produced**: March 24, 2023 6:12:38 PM UTC
- **Commit**: 1e620a42e71ca8c7efb033fd525f04be5fa701fe
- **Branch**: refs/heads/internal/release/6.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Ref**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.win-x64**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NETCore.Platforms**: [from 6.0.9 to 6.0.9][1]
[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC567ff53ac7&targetVersion=GC1e620a42e7&_a=files
[DependencyUpdate]: <> (End)
[marker]: <> (End:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
@vseanreesermsft
Merge commit 'd6f154cca3863703cf87c8b840eea9cbe20229b2' into internal…
017655f
…-merge-6.0-2023-04-11-1028
@ghostghost
added
the 
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
label
Apr 11, 2023
@ghostghost
added this to the 6.0.x milestone
Apr 11, 2023
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hi @vseanreesermsft. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.

Otherwise, please add tell-mode label.
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.
@wtgodbe
wtgodbe
requested a review
from a team
as a code ownerApril 11, 2023 17:55
@wtgodbe
wtgodbe
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Got some Components-e2e failures, @MackinnonBuck could you take a look?
Microsoft.AspNetCore.Components.E2ETest.Tests.ComponentRenderingTest.CanHandleClearedChild
Assert.DoesNotContain() Failure

Found: (filter expression)

In value: ReadOnlyCollection [[2023-04-11T18:43:04Z] [Info] http://127.0.0.1:42599/subdir/_framework/blazor.webassembly.js 0:35640 "Handle blur...", [2023-04-11T18:43:09Z] [Debug] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:131187 "mono_wasm_runtime_ready" "fe00e07a-5519-4dfe-b35a-f867dbaf2e28", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>"]
@MackinnonBuck
MackinnonBuck
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like some tests are failing because there are errors in the console.
@pavelsavara Do you know what might be happening here? From what I can tell, application functionality hasn't broken in any way other than outputting this error in the console.
dotnet.6.0.16.9vxckk6r1z.js:1 /__w/1/s/src/mono/mono/eglib/gpath.c:115 <disabled>
580850 @ dotnet.6.0.16.9vxckk6r1z.js:1
_emscripten_asm_const_int @ dotnet.6.0.16.9vxckk6r1z.js:1
$func111 @ dotnet.wasm:0x94bd
$func2230 @ dotnet.wasm:0x8ebb3
$func3483 @ dotnet.wasm:0xcc2e7
$func3484 @ dotnet.wasm:0xcc318
$func3485 @ dotnet.wasm:0xcc34b
$func3552 @ dotnet.wasm:0xcd83e
$func2078 @ dotnet.wasm:0x862e3
$func2076 @ dotnet.wasm:0x85de1
$func1338 @ dotnet.wasm:0x653d0
$func328 @ dotnet.wasm:0x255f4
$func310 @ dotnet.wasm:0x1eb55
$func361 @ dotnet.wasm:0x27e5b
$func214 @ dotnet.wasm:0x1a03b
$func167 @ dotnet.wasm:0x18991
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$func3217 @ dotnet.wasm:0xc4e86
$mono_background_exec @ dotnet.wasm:0x9433f
Module._mono_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
pump_message @ dotnet.6.0.16.9vxckk6r1z.js:1
setTimeout (async)
_schedule_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
$func2392 @ dotnet.wasm:0x942f0
$func3216 @ dotnet.wasm:0xc4e16
$func219 @ dotnet.wasm:0x1a529
$func167 @ dotnet.wasm:0xce8f
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$mono_wasm_invoke_method @ dotnet.wasm:0x969f
Module._mono_wasm_invoke_method @ dotnet.6.0.16.9vxckk6r1z.js:1
_call_method_with_converted_args @ dotnet.6.0.16.9vxckk6r1z.js:1
call_method @ dotnet.6.0.16.9vxckk6r1z.js:1
(anonymous) @ dotnet.6.0.16.9vxckk6r1z.js:1
call_assembly_entry_point @ dotnet.6.0.16.9vxckk6r1z.js:1
callEntryPoint @ MonoPlatform.ts:61
At @ Boot.WebAssembly.ts:135
await in At (async)
(anonymous) @ Boot.WebAssembly.ts:218
(anonymous) @ blazor.webassembly.js:1

@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
I don't know yet.
@kg@radekdoulik any thoughts ?
@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
/mono/mono/eglib/gpath.c:115 is g_path_get_dirname with NULL filename
@lewing
lewing
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
@elinor-fung I think this is the dllimport change breaking blazor
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@elinor-fung
elinor-fung
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
@wtgodbe
wtgodbe
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Test failure fixed by dotnet/runtime#84740
@wtgodbe
wtgodbe
merged commit 5629320
into
dotnet:release/6.0Apr 12, 2023
@ghostghost
modified the milestones:
6.0.x, 6.0.17Apr 12, 2023
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@lewing
lewing
commented
Apr 12, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
no this is crashing the world when that path gets hit
@ghost
ghost
commented
Apr 12, 2023

Copy link


Copy Markdown

Hi @lewing. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wtgodbewtgodbeAwaiting requested review from wtgodbe

Assignees


No one assigned


Labels

area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects


None yet


Milestone

6.0.17

Development

Successfully merging this pull request may close these issues.

8 participants

@vseanreesermsft@wtgodbe@MackinnonBuck@pavelsavara@lewing@elinor-fung@dotnet-bot@mmitche

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Merging internal commits for release/6.0 by vseanreesermsft · Pull Request #47652 · dotnet/aspnetcore · GitHub
Skip to content
Merging internal commits for release/6.0 - #47652
Merged
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Apr 12, 2023
Merged
Merging internal commits for release/6.0#47652
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Conversation
@vseanreesermsft
@vseanreesermsftvseanreesermsft
commented
Apr 11, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
dotnet-botand others
added 23 commits
March 7, 2023 22:17
@dotnet-bot
Merge in 'release/6.0' changes
f0b89db
@dotnet-bot
Merge in 'release/6.0' changes
48345db
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
92609a4
…t-efcore
@dotnet-bot
Merge in 'release/6.0' changes
03626ad
@dotnet-bot
Merge in 'release/6.0' changes
fb6bff7
@dotnet-bot
Merge in 'release/6.0' changes
e40b13e
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
f971c03
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
2e6b193
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
98b903b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
23cbd6b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
798ac3d
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
9c56c4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
92f3976
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
56b0b4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
0e2c1b3
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
732cd26
…t-efcore
@mmitche
Merged PR 30049: [internal/release/6.0] Merge from public
642c823
Merge from public release/6.0 to internal/release/6.0 and resolve conflicts if necessary
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
206b88e
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
bb8d881
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
7a292a4
…t-efcore
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
41a6490
…t-runtime
@dotnet-bot@mmitche
Merged PR 30222: [internal/release/6.0] Update dependencies from dnce…
d6f154c
…ng/internal/dotnet-runtime
This pull request updates the following dependencies
[marker]: <> (Begin:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 7745f62d-e15b-4ba3-39b3-08d960f4ca81
- **Build**: 20230323.11
- **Date Produced**: March 24, 2023 6:12:38 PM UTC
- **Commit**: 1e620a42e71ca8c7efb033fd525f04be5fa701fe
- **Branch**: refs/heads/internal/release/6.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Ref**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.win-x64**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NETCore.Platforms**: [from 6.0.9 to 6.0.9][1]
[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC567ff53ac7&targetVersion=GC1e620a42e7&_a=files
[DependencyUpdate]: <> (End)
[marker]: <> (End:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
@vseanreesermsft
Merge commit 'd6f154cca3863703cf87c8b840eea9cbe20229b2' into internal…
017655f
…-merge-6.0-2023-04-11-1028
@ghostghost
added
the 
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
label
Apr 11, 2023
@ghostghost
added this to the 6.0.x milestone
Apr 11, 2023
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hi @vseanreesermsft. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.

Otherwise, please add tell-mode label.
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.
@wtgodbe
wtgodbe
requested a review
from a team
as a code ownerApril 11, 2023 17:55
@wtgodbe
wtgodbe
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Got some Components-e2e failures, @MackinnonBuck could you take a look?
Microsoft.AspNetCore.Components.E2ETest.Tests.ComponentRenderingTest.CanHandleClearedChild
Assert.DoesNotContain() Failure

Found: (filter expression)

In value: ReadOnlyCollection [[2023-04-11T18:43:04Z] [Info] http://127.0.0.1:42599/subdir/_framework/blazor.webassembly.js 0:35640 "Handle blur...", [2023-04-11T18:43:09Z] [Debug] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:131187 "mono_wasm_runtime_ready" "fe00e07a-5519-4dfe-b35a-f867dbaf2e28", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>"]
@MackinnonBuck
MackinnonBuck
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like some tests are failing because there are errors in the console.
@pavelsavara Do you know what might be happening here? From what I can tell, application functionality hasn't broken in any way other than outputting this error in the console.
dotnet.6.0.16.9vxckk6r1z.js:1 /__w/1/s/src/mono/mono/eglib/gpath.c:115 <disabled>
580850 @ dotnet.6.0.16.9vxckk6r1z.js:1
_emscripten_asm_const_int @ dotnet.6.0.16.9vxckk6r1z.js:1
$func111 @ dotnet.wasm:0x94bd
$func2230 @ dotnet.wasm:0x8ebb3
$func3483 @ dotnet.wasm:0xcc2e7
$func3484 @ dotnet.wasm:0xcc318
$func3485 @ dotnet.wasm:0xcc34b
$func3552 @ dotnet.wasm:0xcd83e
$func2078 @ dotnet.wasm:0x862e3
$func2076 @ dotnet.wasm:0x85de1
$func1338 @ dotnet.wasm:0x653d0
$func328 @ dotnet.wasm:0x255f4
$func310 @ dotnet.wasm:0x1eb55
$func361 @ dotnet.wasm:0x27e5b
$func214 @ dotnet.wasm:0x1a03b
$func167 @ dotnet.wasm:0x18991
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$func3217 @ dotnet.wasm:0xc4e86
$mono_background_exec @ dotnet.wasm:0x9433f
Module._mono_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
pump_message @ dotnet.6.0.16.9vxckk6r1z.js:1
setTimeout (async)
_schedule_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
$func2392 @ dotnet.wasm:0x942f0
$func3216 @ dotnet.wasm:0xc4e16
$func219 @ dotnet.wasm:0x1a529
$func167 @ dotnet.wasm:0xce8f
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$mono_wasm_invoke_method @ dotnet.wasm:0x969f
Module._mono_wasm_invoke_method @ dotnet.6.0.16.9vxckk6r1z.js:1
_call_method_with_converted_args @ dotnet.6.0.16.9vxckk6r1z.js:1
call_method @ dotnet.6.0.16.9vxckk6r1z.js:1
(anonymous) @ dotnet.6.0.16.9vxckk6r1z.js:1
call_assembly_entry_point @ dotnet.6.0.16.9vxckk6r1z.js:1
callEntryPoint @ MonoPlatform.ts:61
At @ Boot.WebAssembly.ts:135
await in At (async)
(anonymous) @ Boot.WebAssembly.ts:218
(anonymous) @ blazor.webassembly.js:1

@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
I don't know yet.
@kg@radekdoulik any thoughts ?
@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
/mono/mono/eglib/gpath.c:115 is g_path_get_dirname with NULL filename
@lewing
lewing
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
@elinor-fung I think this is the dllimport change breaking blazor
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@elinor-fung
elinor-fung
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
@wtgodbe
wtgodbe
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Test failure fixed by dotnet/runtime#84740
@wtgodbe
wtgodbe
merged commit 5629320
into
dotnet:release/6.0Apr 12, 2023
@ghostghost
modified the milestones:
6.0.x, 6.0.17Apr 12, 2023
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@lewing
lewing
commented
Apr 12, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
no this is crashing the world when that path gets hit
@ghost
ghost
commented
Apr 12, 2023

Copy link


Copy Markdown

Hi @lewing. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wtgodbewtgodbeAwaiting requested review from wtgodbe

Assignees


No one assigned


Labels

area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects


None yet


Milestone

6.0.17

Development

Successfully merging this pull request may close these issues.

8 participants

@vseanreesermsft@wtgodbe@MackinnonBuck@pavelsavara@lewing@elinor-fung@dotnet-bot@mmitche

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Merging internal commits for release/6.0 by vseanreesermsft · Pull Request #47652 · dotnet/aspnetcore · GitHub
Skip to content
Merging internal commits for release/6.0 - #47652
Merged
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Apr 12, 2023
Merged
Merging internal commits for release/6.0#47652
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Conversation
@vseanreesermsft
@vseanreesermsftvseanreesermsft
commented
Apr 11, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
dotnet-botand others
added 23 commits
March 7, 2023 22:17
@dotnet-bot
Merge in 'release/6.0' changes
f0b89db
@dotnet-bot
Merge in 'release/6.0' changes
48345db
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
92609a4
…t-efcore
@dotnet-bot
Merge in 'release/6.0' changes
03626ad
@dotnet-bot
Merge in 'release/6.0' changes
fb6bff7
@dotnet-bot
Merge in 'release/6.0' changes
e40b13e
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
f971c03
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
2e6b193
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
98b903b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
23cbd6b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
798ac3d
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
9c56c4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
92f3976
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
56b0b4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
0e2c1b3
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
732cd26
…t-efcore
@mmitche
Merged PR 30049: [internal/release/6.0] Merge from public
642c823
Merge from public release/6.0 to internal/release/6.0 and resolve conflicts if necessary
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
206b88e
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
bb8d881
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
7a292a4
…t-efcore
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
41a6490
…t-runtime
@dotnet-bot@mmitche
Merged PR 30222: [internal/release/6.0] Update dependencies from dnce…
d6f154c
…ng/internal/dotnet-runtime
This pull request updates the following dependencies
[marker]: <> (Begin:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 7745f62d-e15b-4ba3-39b3-08d960f4ca81
- **Build**: 20230323.11
- **Date Produced**: March 24, 2023 6:12:38 PM UTC
- **Commit**: 1e620a42e71ca8c7efb033fd525f04be5fa701fe
- **Branch**: refs/heads/internal/release/6.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Ref**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.win-x64**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NETCore.Platforms**: [from 6.0.9 to 6.0.9][1]
[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC567ff53ac7&targetVersion=GC1e620a42e7&_a=files
[DependencyUpdate]: <> (End)
[marker]: <> (End:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
@vseanreesermsft
Merge commit 'd6f154cca3863703cf87c8b840eea9cbe20229b2' into internal…
017655f
…-merge-6.0-2023-04-11-1028
@ghostghost
added
the 
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
label
Apr 11, 2023
@ghostghost
added this to the 6.0.x milestone
Apr 11, 2023
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hi @vseanreesermsft. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.

Otherwise, please add tell-mode label.
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.
@wtgodbe
wtgodbe
requested a review
from a team
as a code ownerApril 11, 2023 17:55
@wtgodbe
wtgodbe
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Got some Components-e2e failures, @MackinnonBuck could you take a look?
Microsoft.AspNetCore.Components.E2ETest.Tests.ComponentRenderingTest.CanHandleClearedChild
Assert.DoesNotContain() Failure

Found: (filter expression)

In value: ReadOnlyCollection [[2023-04-11T18:43:04Z] [Info] http://127.0.0.1:42599/subdir/_framework/blazor.webassembly.js 0:35640 "Handle blur...", [2023-04-11T18:43:09Z] [Debug] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:131187 "mono_wasm_runtime_ready" "fe00e07a-5519-4dfe-b35a-f867dbaf2e28", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>"]
@MackinnonBuck
MackinnonBuck
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like some tests are failing because there are errors in the console.
@pavelsavara Do you know what might be happening here? From what I can tell, application functionality hasn't broken in any way other than outputting this error in the console.
dotnet.6.0.16.9vxckk6r1z.js:1 /__w/1/s/src/mono/mono/eglib/gpath.c:115 <disabled>
580850 @ dotnet.6.0.16.9vxckk6r1z.js:1
_emscripten_asm_const_int @ dotnet.6.0.16.9vxckk6r1z.js:1
$func111 @ dotnet.wasm:0x94bd
$func2230 @ dotnet.wasm:0x8ebb3
$func3483 @ dotnet.wasm:0xcc2e7
$func3484 @ dotnet.wasm:0xcc318
$func3485 @ dotnet.wasm:0xcc34b
$func3552 @ dotnet.wasm:0xcd83e
$func2078 @ dotnet.wasm:0x862e3
$func2076 @ dotnet.wasm:0x85de1
$func1338 @ dotnet.wasm:0x653d0
$func328 @ dotnet.wasm:0x255f4
$func310 @ dotnet.wasm:0x1eb55
$func361 @ dotnet.wasm:0x27e5b
$func214 @ dotnet.wasm:0x1a03b
$func167 @ dotnet.wasm:0x18991
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$func3217 @ dotnet.wasm:0xc4e86
$mono_background_exec @ dotnet.wasm:0x9433f
Module._mono_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
pump_message @ dotnet.6.0.16.9vxckk6r1z.js:1
setTimeout (async)
_schedule_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
$func2392 @ dotnet.wasm:0x942f0
$func3216 @ dotnet.wasm:0xc4e16
$func219 @ dotnet.wasm:0x1a529
$func167 @ dotnet.wasm:0xce8f
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$mono_wasm_invoke_method @ dotnet.wasm:0x969f
Module._mono_wasm_invoke_method @ dotnet.6.0.16.9vxckk6r1z.js:1
_call_method_with_converted_args @ dotnet.6.0.16.9vxckk6r1z.js:1
call_method @ dotnet.6.0.16.9vxckk6r1z.js:1
(anonymous) @ dotnet.6.0.16.9vxckk6r1z.js:1
call_assembly_entry_point @ dotnet.6.0.16.9vxckk6r1z.js:1
callEntryPoint @ MonoPlatform.ts:61
At @ Boot.WebAssembly.ts:135
await in At (async)
(anonymous) @ Boot.WebAssembly.ts:218
(anonymous) @ blazor.webassembly.js:1

@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
I don't know yet.
@kg@radekdoulik any thoughts ?
@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
/mono/mono/eglib/gpath.c:115 is g_path_get_dirname with NULL filename
@lewing
lewing
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
@elinor-fung I think this is the dllimport change breaking blazor
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@elinor-fung
elinor-fung
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
@wtgodbe
wtgodbe
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Test failure fixed by dotnet/runtime#84740
@wtgodbe
wtgodbe
merged commit 5629320
into
dotnet:release/6.0Apr 12, 2023
@ghostghost
modified the milestones:
6.0.x, 6.0.17Apr 12, 2023
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@lewing
lewing
commented
Apr 12, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
no this is crashing the world when that path gets hit
@ghost
ghost
commented
Apr 12, 2023

Copy link


Copy Markdown

Hi @lewing. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wtgodbewtgodbeAwaiting requested review from wtgodbe

Assignees


No one assigned


Labels

area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects


None yet


Milestone

6.0.17

Development

Successfully merging this pull request may close these issues.

8 participants

@vseanreesermsft@wtgodbe@MackinnonBuck@pavelsavara@lewing@elinor-fung@dotnet-bot@mmitche

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Merging internal commits for release/6.0 by vseanreesermsft · Pull Request #47652 · dotnet/aspnetcore · GitHub
Skip to content
Merging internal commits for release/6.0 - #47652
Merged
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Apr 12, 2023
Merged
Merging internal commits for release/6.0#47652
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Conversation
@vseanreesermsft
@vseanreesermsftvseanreesermsft
commented
Apr 11, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
dotnet-botand others
added 23 commits
March 7, 2023 22:17
@dotnet-bot
Merge in 'release/6.0' changes
f0b89db
@dotnet-bot
Merge in 'release/6.0' changes
48345db
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
92609a4
…t-efcore
@dotnet-bot
Merge in 'release/6.0' changes
03626ad
@dotnet-bot
Merge in 'release/6.0' changes
fb6bff7
@dotnet-bot
Merge in 'release/6.0' changes
e40b13e
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
f971c03
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
2e6b193
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
98b903b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
23cbd6b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
798ac3d
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
9c56c4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
92f3976
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
56b0b4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
0e2c1b3
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
732cd26
…t-efcore
@mmitche
Merged PR 30049: [internal/release/6.0] Merge from public
642c823
Merge from public release/6.0 to internal/release/6.0 and resolve conflicts if necessary
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
206b88e
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
bb8d881
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
7a292a4
…t-efcore
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
41a6490
…t-runtime
@dotnet-bot@mmitche
Merged PR 30222: [internal/release/6.0] Update dependencies from dnce…
d6f154c
…ng/internal/dotnet-runtime
This pull request updates the following dependencies
[marker]: <> (Begin:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 7745f62d-e15b-4ba3-39b3-08d960f4ca81
- **Build**: 20230323.11
- **Date Produced**: March 24, 2023 6:12:38 PM UTC
- **Commit**: 1e620a42e71ca8c7efb033fd525f04be5fa701fe
- **Branch**: refs/heads/internal/release/6.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Ref**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.win-x64**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NETCore.Platforms**: [from 6.0.9 to 6.0.9][1]
[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC567ff53ac7&targetVersion=GC1e620a42e7&_a=files
[DependencyUpdate]: <> (End)
[marker]: <> (End:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
@vseanreesermsft
Merge commit 'd6f154cca3863703cf87c8b840eea9cbe20229b2' into internal…
017655f
…-merge-6.0-2023-04-11-1028
@ghostghost
added
the 
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
label
Apr 11, 2023
@ghostghost
added this to the 6.0.x milestone
Apr 11, 2023
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hi @vseanreesermsft. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.

Otherwise, please add tell-mode label.
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.
@wtgodbe
wtgodbe
requested a review
from a team
as a code ownerApril 11, 2023 17:55
@wtgodbe
wtgodbe
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Got some Components-e2e failures, @MackinnonBuck could you take a look?
Microsoft.AspNetCore.Components.E2ETest.Tests.ComponentRenderingTest.CanHandleClearedChild
Assert.DoesNotContain() Failure

Found: (filter expression)

In value: ReadOnlyCollection [[2023-04-11T18:43:04Z] [Info] http://127.0.0.1:42599/subdir/_framework/blazor.webassembly.js 0:35640 "Handle blur...", [2023-04-11T18:43:09Z] [Debug] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:131187 "mono_wasm_runtime_ready" "fe00e07a-5519-4dfe-b35a-f867dbaf2e28", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>"]
@MackinnonBuck
MackinnonBuck
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like some tests are failing because there are errors in the console.
@pavelsavara Do you know what might be happening here? From what I can tell, application functionality hasn't broken in any way other than outputting this error in the console.
dotnet.6.0.16.9vxckk6r1z.js:1 /__w/1/s/src/mono/mono/eglib/gpath.c:115 <disabled>
580850 @ dotnet.6.0.16.9vxckk6r1z.js:1
_emscripten_asm_const_int @ dotnet.6.0.16.9vxckk6r1z.js:1
$func111 @ dotnet.wasm:0x94bd
$func2230 @ dotnet.wasm:0x8ebb3
$func3483 @ dotnet.wasm:0xcc2e7
$func3484 @ dotnet.wasm:0xcc318
$func3485 @ dotnet.wasm:0xcc34b
$func3552 @ dotnet.wasm:0xcd83e
$func2078 @ dotnet.wasm:0x862e3
$func2076 @ dotnet.wasm:0x85de1
$func1338 @ dotnet.wasm:0x653d0
$func328 @ dotnet.wasm:0x255f4
$func310 @ dotnet.wasm:0x1eb55
$func361 @ dotnet.wasm:0x27e5b
$func214 @ dotnet.wasm:0x1a03b
$func167 @ dotnet.wasm:0x18991
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$func3217 @ dotnet.wasm:0xc4e86
$mono_background_exec @ dotnet.wasm:0x9433f
Module._mono_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
pump_message @ dotnet.6.0.16.9vxckk6r1z.js:1
setTimeout (async)
_schedule_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
$func2392 @ dotnet.wasm:0x942f0
$func3216 @ dotnet.wasm:0xc4e16
$func219 @ dotnet.wasm:0x1a529
$func167 @ dotnet.wasm:0xce8f
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$mono_wasm_invoke_method @ dotnet.wasm:0x969f
Module._mono_wasm_invoke_method @ dotnet.6.0.16.9vxckk6r1z.js:1
_call_method_with_converted_args @ dotnet.6.0.16.9vxckk6r1z.js:1
call_method @ dotnet.6.0.16.9vxckk6r1z.js:1
(anonymous) @ dotnet.6.0.16.9vxckk6r1z.js:1
call_assembly_entry_point @ dotnet.6.0.16.9vxckk6r1z.js:1
callEntryPoint @ MonoPlatform.ts:61
At @ Boot.WebAssembly.ts:135
await in At (async)
(anonymous) @ Boot.WebAssembly.ts:218
(anonymous) @ blazor.webassembly.js:1

@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
I don't know yet.
@kg@radekdoulik any thoughts ?
@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
/mono/mono/eglib/gpath.c:115 is g_path_get_dirname with NULL filename
@lewing
lewing
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
@elinor-fung I think this is the dllimport change breaking blazor
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@elinor-fung
elinor-fung
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
@wtgodbe
wtgodbe
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Test failure fixed by dotnet/runtime#84740
@wtgodbe
wtgodbe
merged commit 5629320
into
dotnet:release/6.0Apr 12, 2023
@ghostghost
modified the milestones:
6.0.x, 6.0.17Apr 12, 2023
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@lewing
lewing
commented
Apr 12, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
no this is crashing the world when that path gets hit
@ghost
ghost
commented
Apr 12, 2023

Copy link


Copy Markdown

Hi @lewing. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wtgodbewtgodbeAwaiting requested review from wtgodbe

Assignees


No one assigned


Labels

area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects


None yet


Milestone

6.0.17

Development

Successfully merging this pull request may close these issues.

8 participants

@vseanreesermsft@wtgodbe@MackinnonBuck@pavelsavara@lewing@elinor-fung@dotnet-bot@mmitche

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Merging internal commits for release/6.0 by vseanreesermsft · Pull Request #47652 · dotnet/aspnetcore · GitHub
Skip to content
Merging internal commits for release/6.0 - #47652
Merged
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Apr 12, 2023
Merged
Merging internal commits for release/6.0#47652
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Conversation
@vseanreesermsft
@vseanreesermsftvseanreesermsft
commented
Apr 11, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
dotnet-botand others
added 23 commits
March 7, 2023 22:17
@dotnet-bot
Merge in 'release/6.0' changes
f0b89db
@dotnet-bot
Merge in 'release/6.0' changes
48345db
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
92609a4
…t-efcore
@dotnet-bot
Merge in 'release/6.0' changes
03626ad
@dotnet-bot
Merge in 'release/6.0' changes
fb6bff7
@dotnet-bot
Merge in 'release/6.0' changes
e40b13e
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
f971c03
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
2e6b193
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
98b903b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
23cbd6b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
798ac3d
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
9c56c4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
92f3976
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
56b0b4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
0e2c1b3
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
732cd26
…t-efcore
@mmitche
Merged PR 30049: [internal/release/6.0] Merge from public
642c823
Merge from public release/6.0 to internal/release/6.0 and resolve conflicts if necessary
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
206b88e
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
bb8d881
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
7a292a4
…t-efcore
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
41a6490
…t-runtime
@dotnet-bot@mmitche
Merged PR 30222: [internal/release/6.0] Update dependencies from dnce…
d6f154c
…ng/internal/dotnet-runtime
This pull request updates the following dependencies
[marker]: <> (Begin:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 7745f62d-e15b-4ba3-39b3-08d960f4ca81
- **Build**: 20230323.11
- **Date Produced**: March 24, 2023 6:12:38 PM UTC
- **Commit**: 1e620a42e71ca8c7efb033fd525f04be5fa701fe
- **Branch**: refs/heads/internal/release/6.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Ref**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.win-x64**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NETCore.Platforms**: [from 6.0.9 to 6.0.9][1]
[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC567ff53ac7&targetVersion=GC1e620a42e7&_a=files
[DependencyUpdate]: <> (End)
[marker]: <> (End:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
@vseanreesermsft
Merge commit 'd6f154cca3863703cf87c8b840eea9cbe20229b2' into internal…
017655f
…-merge-6.0-2023-04-11-1028
@ghostghost
added
the 
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
label
Apr 11, 2023
@ghostghost
added this to the 6.0.x milestone
Apr 11, 2023
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hi @vseanreesermsft. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.

Otherwise, please add tell-mode label.
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.
@wtgodbe
wtgodbe
requested a review
from a team
as a code ownerApril 11, 2023 17:55
@wtgodbe
wtgodbe
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Got some Components-e2e failures, @MackinnonBuck could you take a look?
Microsoft.AspNetCore.Components.E2ETest.Tests.ComponentRenderingTest.CanHandleClearedChild
Assert.DoesNotContain() Failure

Found: (filter expression)

In value: ReadOnlyCollection [[2023-04-11T18:43:04Z] [Info] http://127.0.0.1:42599/subdir/_framework/blazor.webassembly.js 0:35640 "Handle blur...", [2023-04-11T18:43:09Z] [Debug] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:131187 "mono_wasm_runtime_ready" "fe00e07a-5519-4dfe-b35a-f867dbaf2e28", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>"]
@MackinnonBuck
MackinnonBuck
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like some tests are failing because there are errors in the console.
@pavelsavara Do you know what might be happening here? From what I can tell, application functionality hasn't broken in any way other than outputting this error in the console.
dotnet.6.0.16.9vxckk6r1z.js:1 /__w/1/s/src/mono/mono/eglib/gpath.c:115 <disabled>
580850 @ dotnet.6.0.16.9vxckk6r1z.js:1
_emscripten_asm_const_int @ dotnet.6.0.16.9vxckk6r1z.js:1
$func111 @ dotnet.wasm:0x94bd
$func2230 @ dotnet.wasm:0x8ebb3
$func3483 @ dotnet.wasm:0xcc2e7
$func3484 @ dotnet.wasm:0xcc318
$func3485 @ dotnet.wasm:0xcc34b
$func3552 @ dotnet.wasm:0xcd83e
$func2078 @ dotnet.wasm:0x862e3
$func2076 @ dotnet.wasm:0x85de1
$func1338 @ dotnet.wasm:0x653d0
$func328 @ dotnet.wasm:0x255f4
$func310 @ dotnet.wasm:0x1eb55
$func361 @ dotnet.wasm:0x27e5b
$func214 @ dotnet.wasm:0x1a03b
$func167 @ dotnet.wasm:0x18991
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$func3217 @ dotnet.wasm:0xc4e86
$mono_background_exec @ dotnet.wasm:0x9433f
Module._mono_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
pump_message @ dotnet.6.0.16.9vxckk6r1z.js:1
setTimeout (async)
_schedule_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
$func2392 @ dotnet.wasm:0x942f0
$func3216 @ dotnet.wasm:0xc4e16
$func219 @ dotnet.wasm:0x1a529
$func167 @ dotnet.wasm:0xce8f
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$mono_wasm_invoke_method @ dotnet.wasm:0x969f
Module._mono_wasm_invoke_method @ dotnet.6.0.16.9vxckk6r1z.js:1
_call_method_with_converted_args @ dotnet.6.0.16.9vxckk6r1z.js:1
call_method @ dotnet.6.0.16.9vxckk6r1z.js:1
(anonymous) @ dotnet.6.0.16.9vxckk6r1z.js:1
call_assembly_entry_point @ dotnet.6.0.16.9vxckk6r1z.js:1
callEntryPoint @ MonoPlatform.ts:61
At @ Boot.WebAssembly.ts:135
await in At (async)
(anonymous) @ Boot.WebAssembly.ts:218
(anonymous) @ blazor.webassembly.js:1

@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
I don't know yet.
@kg@radekdoulik any thoughts ?
@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
/mono/mono/eglib/gpath.c:115 is g_path_get_dirname with NULL filename
@lewing
lewing
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
@elinor-fung I think this is the dllimport change breaking blazor
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@elinor-fung
elinor-fung
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
@wtgodbe
wtgodbe
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Test failure fixed by dotnet/runtime#84740
@wtgodbe
wtgodbe
merged commit 5629320
into
dotnet:release/6.0Apr 12, 2023
@ghostghost
modified the milestones:
6.0.x, 6.0.17Apr 12, 2023
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@lewing
lewing
commented
Apr 12, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
no this is crashing the world when that path gets hit
@ghost
ghost
commented
Apr 12, 2023

Copy link


Copy Markdown

Hi @lewing. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wtgodbewtgodbeAwaiting requested review from wtgodbe

Assignees


No one assigned


Labels

area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects


None yet


Milestone

6.0.17

Development

Successfully merging this pull request may close these issues.

8 participants

@vseanreesermsft@wtgodbe@MackinnonBuck@pavelsavara@lewing@elinor-fung@dotnet-bot@mmitche

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Merging internal commits for release/6.0 by vseanreesermsft · Pull Request #47652 · dotnet/aspnetcore · GitHub
Skip to content
Merging internal commits for release/6.0 - #47652
Merged
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Apr 12, 2023
Merged
Merging internal commits for release/6.0#47652
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Conversation
@vseanreesermsft
@vseanreesermsftvseanreesermsft
commented
Apr 11, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
dotnet-botand others
added 23 commits
March 7, 2023 22:17
@dotnet-bot
Merge in 'release/6.0' changes
f0b89db
@dotnet-bot
Merge in 'release/6.0' changes
48345db
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
92609a4
…t-efcore
@dotnet-bot
Merge in 'release/6.0' changes
03626ad
@dotnet-bot
Merge in 'release/6.0' changes
fb6bff7
@dotnet-bot
Merge in 'release/6.0' changes
e40b13e
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
f971c03
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
2e6b193
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
98b903b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
23cbd6b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
798ac3d
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
9c56c4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
92f3976
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
56b0b4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
0e2c1b3
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
732cd26
…t-efcore
@mmitche
Merged PR 30049: [internal/release/6.0] Merge from public
642c823
Merge from public release/6.0 to internal/release/6.0 and resolve conflicts if necessary
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
206b88e
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
bb8d881
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
7a292a4
…t-efcore
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
41a6490
…t-runtime
@dotnet-bot@mmitche
Merged PR 30222: [internal/release/6.0] Update dependencies from dnce…
d6f154c
…ng/internal/dotnet-runtime
This pull request updates the following dependencies
[marker]: <> (Begin:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 7745f62d-e15b-4ba3-39b3-08d960f4ca81
- **Build**: 20230323.11
- **Date Produced**: March 24, 2023 6:12:38 PM UTC
- **Commit**: 1e620a42e71ca8c7efb033fd525f04be5fa701fe
- **Branch**: refs/heads/internal/release/6.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Ref**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.win-x64**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NETCore.Platforms**: [from 6.0.9 to 6.0.9][1]
[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC567ff53ac7&targetVersion=GC1e620a42e7&_a=files
[DependencyUpdate]: <> (End)
[marker]: <> (End:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
@vseanreesermsft
Merge commit 'd6f154cca3863703cf87c8b840eea9cbe20229b2' into internal…
017655f
…-merge-6.0-2023-04-11-1028
@ghostghost
added
the 
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
label
Apr 11, 2023
@ghostghost
added this to the 6.0.x milestone
Apr 11, 2023
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hi @vseanreesermsft. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.

Otherwise, please add tell-mode label.
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.
@wtgodbe
wtgodbe
requested a review
from a team
as a code ownerApril 11, 2023 17:55
@wtgodbe
wtgodbe
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Got some Components-e2e failures, @MackinnonBuck could you take a look?
Microsoft.AspNetCore.Components.E2ETest.Tests.ComponentRenderingTest.CanHandleClearedChild
Assert.DoesNotContain() Failure

Found: (filter expression)

In value: ReadOnlyCollection [[2023-04-11T18:43:04Z] [Info] http://127.0.0.1:42599/subdir/_framework/blazor.webassembly.js 0:35640 "Handle blur...", [2023-04-11T18:43:09Z] [Debug] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:131187 "mono_wasm_runtime_ready" "fe00e07a-5519-4dfe-b35a-f867dbaf2e28", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>"]
@MackinnonBuck
MackinnonBuck
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like some tests are failing because there are errors in the console.
@pavelsavara Do you know what might be happening here? From what I can tell, application functionality hasn't broken in any way other than outputting this error in the console.
dotnet.6.0.16.9vxckk6r1z.js:1 /__w/1/s/src/mono/mono/eglib/gpath.c:115 <disabled>
580850 @ dotnet.6.0.16.9vxckk6r1z.js:1
_emscripten_asm_const_int @ dotnet.6.0.16.9vxckk6r1z.js:1
$func111 @ dotnet.wasm:0x94bd
$func2230 @ dotnet.wasm:0x8ebb3
$func3483 @ dotnet.wasm:0xcc2e7
$func3484 @ dotnet.wasm:0xcc318
$func3485 @ dotnet.wasm:0xcc34b
$func3552 @ dotnet.wasm:0xcd83e
$func2078 @ dotnet.wasm:0x862e3
$func2076 @ dotnet.wasm:0x85de1
$func1338 @ dotnet.wasm:0x653d0
$func328 @ dotnet.wasm:0x255f4
$func310 @ dotnet.wasm:0x1eb55
$func361 @ dotnet.wasm:0x27e5b
$func214 @ dotnet.wasm:0x1a03b
$func167 @ dotnet.wasm:0x18991
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$func3217 @ dotnet.wasm:0xc4e86
$mono_background_exec @ dotnet.wasm:0x9433f
Module._mono_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
pump_message @ dotnet.6.0.16.9vxckk6r1z.js:1
setTimeout (async)
_schedule_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
$func2392 @ dotnet.wasm:0x942f0
$func3216 @ dotnet.wasm:0xc4e16
$func219 @ dotnet.wasm:0x1a529
$func167 @ dotnet.wasm:0xce8f
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$mono_wasm_invoke_method @ dotnet.wasm:0x969f
Module._mono_wasm_invoke_method @ dotnet.6.0.16.9vxckk6r1z.js:1
_call_method_with_converted_args @ dotnet.6.0.16.9vxckk6r1z.js:1
call_method @ dotnet.6.0.16.9vxckk6r1z.js:1
(anonymous) @ dotnet.6.0.16.9vxckk6r1z.js:1
call_assembly_entry_point @ dotnet.6.0.16.9vxckk6r1z.js:1
callEntryPoint @ MonoPlatform.ts:61
At @ Boot.WebAssembly.ts:135
await in At (async)
(anonymous) @ Boot.WebAssembly.ts:218
(anonymous) @ blazor.webassembly.js:1

@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
I don't know yet.
@kg@radekdoulik any thoughts ?
@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
/mono/mono/eglib/gpath.c:115 is g_path_get_dirname with NULL filename
@lewing
lewing
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
@elinor-fung I think this is the dllimport change breaking blazor
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@elinor-fung
elinor-fung
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
@wtgodbe
wtgodbe
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Test failure fixed by dotnet/runtime#84740
@wtgodbe
wtgodbe
merged commit 5629320
into
dotnet:release/6.0Apr 12, 2023
@ghostghost
modified the milestones:
6.0.x, 6.0.17Apr 12, 2023
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@lewing
lewing
commented
Apr 12, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
no this is crashing the world when that path gets hit
@ghost
ghost
commented
Apr 12, 2023

Copy link


Copy Markdown

Hi @lewing. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wtgodbewtgodbeAwaiting requested review from wtgodbe

Assignees


No one assigned


Labels

area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects


None yet


Milestone

6.0.17

Development

Successfully merging this pull request may close these issues.

8 participants

@vseanreesermsft@wtgodbe@MackinnonBuck@pavelsavara@lewing@elinor-fung@dotnet-bot@mmitche

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Merging internal commits for release/6.0 by vseanreesermsft · Pull Request #47652 · dotnet/aspnetcore · GitHub
Skip to content
Merging internal commits for release/6.0 - #47652
Merged
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Apr 12, 2023
Merged
Merging internal commits for release/6.0#47652
wtgodbe merged 24 commits into
dotnet:release/6.0from 
vseanreesermsft:internal-merge-6.0-2023-04-11-1028
Conversation
@vseanreesermsft
@vseanreesermsftvseanreesermsft
commented
Apr 11, 2023

Copy link


Copy Markdown

Contributor
 No description provided. 
dotnet-botand others
added 23 commits
March 7, 2023 22:17
@dotnet-bot
Merge in 'release/6.0' changes
f0b89db
@dotnet-bot
Merge in 'release/6.0' changes
48345db
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
92609a4
…t-efcore
@dotnet-bot
Merge in 'release/6.0' changes
03626ad
@dotnet-bot
Merge in 'release/6.0' changes
fb6bff7
@dotnet-bot
Merge in 'release/6.0' changes
e40b13e
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
f971c03
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
2e6b193
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
98b903b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
23cbd6b
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
798ac3d
…t-runtime
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
9c56c4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
92f3976
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
56b0b4a
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
0e2c1b3
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
732cd26
…t-efcore
@mmitche
Merged PR 30049: [internal/release/6.0] Merge from public
642c823
Merge from public release/6.0 to internal/release/6.0 and resolve conflicts if necessary
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
206b88e
…t-runtime
@dotnet-bot
Merge in 'release/6.0' changes
bb8d881
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
7a292a4
…t-efcore
@dotnet-bot
[internal/release/6.0] Update dependencies from dnceng/internal/dotne…
41a6490
…t-runtime
@dotnet-bot@mmitche
Merged PR 30222: [internal/release/6.0] Update dependencies from dnce…
d6f154c
…ng/internal/dotnet-runtime
This pull request updates the following dependencies
[marker]: <> (Begin:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
## From https://dev.azure.com/dnceng/internal/_git/dotnet-runtime
- **Subscription**: 7745f62d-e15b-4ba3-39b3-08d960f4ca81
- **Build**: 20230323.11
- **Date Produced**: March 24, 2023 6:12:38 PM UTC
- **Commit**: 1e620a42e71ca8c7efb033fd525f04be5fa701fe
- **Branch**: refs/heads/internal/release/6.0
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.Internal.Runtime.AspNetCore.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NET.Runtime.MonoAOTCompiler.Task**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NET.Runtime.WebAssembly.Sdk**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Ref**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.App.Runtime.win-x64**: [from 6.0.16 to 6.0.16][1]
- **Microsoft.NETCore.BrowserDebugHost.Transport**: [from 6.0.16-servicing.23170.9 to 6.0.16-servicing.23173.11][1]
- **Microsoft.NETCore.Platforms**: [from 6.0.9 to 6.0.9][1]
[1]: https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/branches?baseVersion=GC567ff53ac7&targetVersion=GC1e620a42e7&_a=files
[DependencyUpdate]: <> (End)
[marker]: <> (End:7745f62d-e15b-4ba3-39b3-08d960f4ca81)
@vseanreesermsft
Merge commit 'd6f154cca3863703cf87c8b840eea9cbe20229b2' into internal…
017655f
…-merge-6.0-2023-04-11-1028
@ghostghost
added
the 
area-infrastructure
Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
label
Apr 11, 2023
@ghostghost
added this to the 6.0.x milestone
Apr 11, 2023
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hi @vseanreesermsft. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.

Otherwise, please add tell-mode label.
@ghost
ghost
commented
Apr 11, 2023

Copy link


Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.
@wtgodbe
wtgodbe
requested a review
from a team
as a code ownerApril 11, 2023 17:55
@wtgodbe
wtgodbe
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Got some Components-e2e failures, @MackinnonBuck could you take a look?
Microsoft.AspNetCore.Components.E2ETest.Tests.ComponentRenderingTest.CanHandleClearedChild
Assert.DoesNotContain() Failure

Found: (filter expression)

In value: ReadOnlyCollection [[2023-04-11T18:43:04Z] [Info] http://127.0.0.1:42599/subdir/_framework/blazor.webassembly.js 0:35640 "Handle blur...", [2023-04-11T18:43:09Z] [Debug] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:131187 "mono_wasm_runtime_ready" "fe00e07a-5519-4dfe-b35a-f867dbaf2e28", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>", [2023-04-11T18:43:09Z] [Severe] http://127.0.0.1:42599/subdir/_framework/dotnet.6.0.16.abslel8s2o.js 0:17630 "/__w/1/s/src/mono/mono/eglib/gpath.c:115 \u003Cdisabled>"]
@MackinnonBuck
MackinnonBuck
commented
Apr 11, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like some tests are failing because there are errors in the console.
@pavelsavara Do you know what might be happening here? From what I can tell, application functionality hasn't broken in any way other than outputting this error in the console.
dotnet.6.0.16.9vxckk6r1z.js:1 /__w/1/s/src/mono/mono/eglib/gpath.c:115 <disabled>
580850 @ dotnet.6.0.16.9vxckk6r1z.js:1
_emscripten_asm_const_int @ dotnet.6.0.16.9vxckk6r1z.js:1
$func111 @ dotnet.wasm:0x94bd
$func2230 @ dotnet.wasm:0x8ebb3
$func3483 @ dotnet.wasm:0xcc2e7
$func3484 @ dotnet.wasm:0xcc318
$func3485 @ dotnet.wasm:0xcc34b
$func3552 @ dotnet.wasm:0xcd83e
$func2078 @ dotnet.wasm:0x862e3
$func2076 @ dotnet.wasm:0x85de1
$func1338 @ dotnet.wasm:0x653d0
$func328 @ dotnet.wasm:0x255f4
$func310 @ dotnet.wasm:0x1eb55
$func361 @ dotnet.wasm:0x27e5b
$func214 @ dotnet.wasm:0x1a03b
$func167 @ dotnet.wasm:0x18991
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$func3217 @ dotnet.wasm:0xc4e86
$mono_background_exec @ dotnet.wasm:0x9433f
Module._mono_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
pump_message @ dotnet.6.0.16.9vxckk6r1z.js:1
setTimeout (async)
_schedule_background_exec @ dotnet.6.0.16.9vxckk6r1z.js:1
$func2392 @ dotnet.wasm:0x942f0
$func3216 @ dotnet.wasm:0xc4e16
$func219 @ dotnet.wasm:0x1a529
$func167 @ dotnet.wasm:0xce8f
$func166 @ dotnet.wasm:0xbd73
$func2815 @ dotnet.wasm:0xabef4
$func1619 @ dotnet.wasm:0x6fcb4
$func1623 @ dotnet.wasm:0x70321
$mono_wasm_invoke_method @ dotnet.wasm:0x969f
Module._mono_wasm_invoke_method @ dotnet.6.0.16.9vxckk6r1z.js:1
_call_method_with_converted_args @ dotnet.6.0.16.9vxckk6r1z.js:1
call_method @ dotnet.6.0.16.9vxckk6r1z.js:1
(anonymous) @ dotnet.6.0.16.9vxckk6r1z.js:1
call_assembly_entry_point @ dotnet.6.0.16.9vxckk6r1z.js:1
callEntryPoint @ MonoPlatform.ts:61
At @ Boot.WebAssembly.ts:135
await in At (async)
(anonymous) @ Boot.WebAssembly.ts:218
(anonymous) @ blazor.webassembly.js:1

@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
I don't know yet.
@kg@radekdoulik any thoughts ?
@pavelsavara
pavelsavara
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
/mono/mono/eglib/gpath.c:115 is g_path_get_dirname with NULL filename
@lewing
lewing
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
@elinor-fung I think this is the dllimport change breaking blazor
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@elinor-fung
elinor-fung
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
@wtgodbe
wtgodbe
commented
Apr 12, 2023

Copy link


Copy Markdown

Member
Test failure fixed by dotnet/runtime#84740
@wtgodbe
wtgodbe
merged commit 5629320
into
dotnet:release/6.0Apr 12, 2023
@ghostghost
modified the milestones:
6.0.x, 6.0.17Apr 12, 2023
@lewinglewing
mentioned this pull request
Apr 12, 2023
 Merged

@lewing
lewing
commented
Apr 12, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Looks like 6.0 didn't have the null check: dotnet/runtime#60445
Just to double check - this is a log message, not a 'crashing the world', right?
no this is crashing the world when that path gets hit
@ghost
ghost
commented
Apr 12, 2023

Copy link


Copy Markdown

Hi @lewing. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wtgodbewtgodbeAwaiting requested review from wtgodbe

Assignees


No one assigned


Labels

area-infrastructureIncludes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects


None yet


Milestone

6.0.17

Development

Successfully merging this pull request may close these issues.

8 participants

@vseanreesermsft@wtgodbe@MackinnonBuck@pavelsavara@lewing@elinor-fung@dotnet-bot@mmitche