Skip to content

Enable runtime-async for SharedFx-only libraries#66200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtgodbe merged 19 commits into from
Apr 24, 2026
Merged

Enable runtime-async for SharedFx-only libraries #66200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
78e5400
Enable runtime-async for SharedFx-only libraries
wtgodbe Apr 7, 2026
fcbf787
Fix wasm exclusion: add RuntimeIdentifier check and fix comment
Copilot Apr 7, 2026
92cd2c0
Fix tests
wtgodbe Apr 7, 2026
c3283a0
Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…
wtgodbe Apr 7, 2026
013779f
Polyfill
wtgodbe Apr 7, 2026
ee72e5a
Fixup
wtgodbe Apr 7, 2026
79a22b2
Own file
wtgodbe Apr 7, 2026
e5a6be6
Whoops
wtgodbe Apr 7, 2026
a0096ab
Merge branch 'main' into wtgodbe/runtime-async
wtgodbe Apr 8, 2026
84530c9
Quarantine CriticalErrorLoggedIfApplicationDoesntComplete test
Copilot Apr 13, 2026
0f7a1e4
Merge branch 'main' into wtgodbe/runtime-async
wtgodbe Apr 14, 2026
d428189
Merge branch 'main' into wtgodbe/runtime-async
wtgodbe Apr 15, 2026
031393c
Merge branch 'main' into wtgodbe/runtime-async
wtgodbe Apr 20, 2026
51d2893
Add --blame-hang to E2E tests to identify hanging tests
wtgodbe Apr 21, 2026
626b3b3
Merge branch 'main' into wtgodbe/runtime-async
wtgodbe Apr 21, 2026
56f72f7
Skip InputTextAreaWorksWithMutatingSetter under runtime-async
wtgodbe Apr 22, 2026
e92c952
Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…
wtgodbe Apr 22, 2026
fc44762
Remove IsTestAssetProject from runtime-async; revert components-e2e-t…
Copilot Apr 23, 2026
4eeefab
Enable InputTextAreaWorksWithMutatingSetter test
wtgodbe Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Directory.Build.targets
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,25 @@
<BuildDependsOn>$(BuildDependsOn);_CopySymbolsToArtifacts</BuildDependsOn>
</PropertyGroup>

<!-- Enable runtime async for net11.0+ source projects that ship only in the Shared Framework -->
<PropertyGroup Condition="'$(IsAspNetCoreApp)' == 'true' AND
'$(IsPackable)' != 'true' AND
$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
'$(UseRuntimeAsync)' != 'false' AND
'$(TargetOS)' != 'browser' AND
!$(RuntimeIdentifier.StartsWith('browser-'))">
<Features>$(Features);runtime-async=on</Features>
</PropertyGroup>

<!-- Also enable runtime async for compatible test projects -->

@halter73halter73Apr 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the tests would fail if not for this, right? Otherwise, I'd probably want to run in both modes at least temporarily.

@wtgodbewtgodbeApr 7, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they would, but I'm largely cribbing off of what runtime did: dotnet/runtime#125406

<PropertyGroup Condition="'$(IsTestProject)' == 'true' AND
$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
'$(UseRuntimeAsync)' != 'false' AND
'$(TargetOS)' != 'browser' AND
!$(RuntimeIdentifier.StartsWith('browser-'))">
<Features>$(Features);runtime-async=on</Features>
</PropertyGroup>

<!-- Properties for Package Validation -->
<PropertyGroup Condition="'$(ExcludeFromSourceOnlyBuild)' != 'true'">
<EnablePackageValidation Condition="'$(EnablePackageValidation)' == ''">true</EnablePackageValidation>
Expand Down
12 changes: 6 additions & 6 deletions src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.WarningSuppressions.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,13 +83,13 @@
<argument>ILLink</argument>
<argument>IL2026</argument>
<property name="Scope">member</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.&lt;ReadRequestBodyAsync&gt;d__9.MoveNext</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.ReadRequestBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.InputFormatterContext,System.Text.Encoding)</property>
</attribute>
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
<argument>ILLink</argument>
<argument>IL2026</argument>
<property name="Scope">member</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.&lt;WriteResponseBodyAsync&gt;d__5.MoveNext</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.WriteResponseBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.OutputFormatterWriteContext,System.Text.Encoding)</property>
</attribute>
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
<argument>ILLink</argument>
Expand All@@ -101,7 +101,7 @@
<argument>ILLink</argument>
<argument>IL2026</argument>
<property name="Scope">member</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.&lt;ExecuteAsync&gt;d__4.MoveNext</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.ExecuteAsync(Microsoft.AspNetCore.Mvc.ActionContext,Microsoft.AspNetCore.Mvc.JsonResult)</property>
</attribute>
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
<argument>ILLink</argument>
Expand All@@ -113,13 +113,13 @@
<argument>ILLink</argument>
<argument>IL2026</argument>
<property name="Scope">member</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.&lt;BindComplexCollectionFromIndexes&gt;d__22.MoveNext</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.BindComplexCollectionFromIndexes(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,System.Collections.Generic.IEnumerable{System.String})</property>
</attribute>
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
<argument>ILLink</argument>
<argument>IL2026</argument>
<property name="Scope">member</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.&lt;BindPropertyAsync&gt;d__15.MoveNext</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.BindPropertyAsync(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,Microsoft.AspNetCore.Mvc.ModelBinding.IModelBinder,System.String,System.String)</property>
</attribute>
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
<argument>ILLink</argument>
Expand All@@ -131,7 +131,7 @@
<argument>ILLink</argument>
<argument>IL2026</argument>
<property name="Scope">member</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.&lt;BindProperty&gt;d__11.MoveNext</property>
<property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.BindProperty(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,System.String,System.String)</property>
</attribute>
<attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
<argument>ILLink</argument>
Expand Down
1 change: 1 addition & 0 deletions src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpConnectionManagerTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ public class HttpConnectionManagerTests : LoggedTest
#if !DEBUG
[ConditionalFact]
[NoDebuggerCondition]
[QuarantinedTest("https://github.com/dotnet/runtime/issues/126735")]
public async Task CriticalErrorLoggedIfApplicationDoesntComplete()
{
////////////////////////////////////////////////////////////////////////////////////////
Expand Down
3 changes: 3 additions & 0 deletions src/SignalR/clients/csharp/Client/test/FunctionalTests/Hubs.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@
using System.Linq;
using System.Reactive.Linq;
using System.Threading.Channels;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Authorization;
Expand DownExpand Up@@ -150,11 +151,13 @@ public class DynamicTestHub : DynamicHub

public ChannelReader<string> StreamBroken() => TestHubMethodsImpl.StreamBroken();

[RuntimeAsyncMethodGeneration(false)]
public async Task CallEcho(string message)
{
await Clients.Client(Context.ConnectionId).Echo(message);
}

[RuntimeAsyncMethodGeneration(false)]
public async Task CallHandlerThatDoesntExist()
{
await Clients.Client(Context.ConnectionId).NoClientHandler();
Expand Down
11 changes: 11 additions & 0 deletions ...gnalR/clients/csharp/Client/test/FunctionalTests/RuntimeAsyncMethodGenerationAttribute.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// Polyfill: RuntimeAsyncMethodGenerationAttribute is not yet public API
namespace System.Runtime.CompilerServices;

[AttributeUsage(AttributeTargets.Method)]
internal sealed class RuntimeAsyncMethodGenerationAttribute(bool runtimeAsync) : Attribute
{
public bool RuntimeAsync { get; } = runtimeAsync;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Enable runtime-async for SharedFx-only libraries by wtgodbe · Pull Request #66200 · dotnet/aspnetcore · GitHub
Skip to content
Enable runtime-async for SharedFx-only libraries#66200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wtgodbe
merged 19 commits into

from

Apr 24, 2026
 Merged


Enable runtime-async for SharedFx-only libraries
#66200
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


19 commits


Select commit
Hold shift + click to select a range
78e5400

Enable runtime-async for SharedFx-only libraries


wtgodbe Apr 7, 2026
fcbf787

Fix wasm exclusion: add RuntimeIdentifier check and fix comment


Copilot Apr 7, 2026
92cd2c0

Fix tests


wtgodbe Apr 7, 2026
c3283a0

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 7, 2026
013779f

Polyfill


wtgodbe Apr 7, 2026
ee72e5a

Fixup


wtgodbe Apr 7, 2026
79a22b2

Own file


wtgodbe Apr 7, 2026
e5a6be6

Whoops


wtgodbe Apr 7, 2026
a0096ab

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 8, 2026
84530c9

Quarantine CriticalErrorLoggedIfApplicationDoesntComplete test


Copilot Apr 13, 2026
0f7a1e4

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 14, 2026
d428189

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 15, 2026
031393c

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 20, 2026
51d2893

Add --blame-hang to E2E tests to identify hanging tests


wtgodbe Apr 21, 2026
626b3b3

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 21, 2026
56f72f7

Skip InputTextAreaWorksWithMutatingSetter under runtime-async


wtgodbe Apr 22, 2026
e92c952

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 22, 2026
fc44762

Remove IsTestAssetProject from runtime-async; revert components-e2e-t…


Copilot Apr 23, 2026
4eeefab

Enable InputTextAreaWorksWithMutatingSetter test


wtgodbe Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
Directory.Build.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,25 @@
 <BuildDependsOn>$(BuildDependsOn);_CopySymbolsToArtifacts</BuildDependsOn>
 </PropertyGroup>

 <!-- Enable runtime async for net11.0+ source projects that ship only in the Shared Framework -->
 <PropertyGroup Condition="'$(IsAspNetCoreApp)' == 'true' AND
 '$(IsPackable)' != 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Also enable runtime async for compatible test projects -->
@halter73halter73Apr 7, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the tests would fail if not for this, right? Otherwise, I'd probably want to run in both modes at least temporarily.
@wtgodbewtgodbeApr 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they would, but I'm largely cribbing off of what runtime did: dotnet/runtime#125406
 <PropertyGroup Condition="'$(IsTestProject)' == 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Properties for Package Validation -->
 <PropertyGroup Condition="'$(ExcludeFromSourceOnlyBuild)' != 'true'">
 <EnablePackageValidation Condition="'$(EnablePackageValidation)' == ''">true</EnablePackageValidation>
Expand Down

12 changes: 6 additions & 6 deletions
src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.WarningSuppressions.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,13 +83,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.&lt;ReadRequestBodyAsync&gt;d__9.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.ReadRequestBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.InputFormatterContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.&lt;WriteResponseBodyAsync&gt;d__5.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.WriteResponseBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.OutputFormatterWriteContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -101,7 +101,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.&lt;ExecuteAsync&gt;d__4.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.ExecuteAsync(Microsoft.AspNetCore.Mvc.ActionContext,Microsoft.AspNetCore.Mvc.JsonResult)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -113,13 +113,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.&lt;BindComplexCollectionFromIndexes&gt;d__22.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.BindComplexCollectionFromIndexes(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,System.Collections.Generic.IEnumerable{System.String})</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.&lt;BindPropertyAsync&gt;d__15.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.BindPropertyAsync(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,Microsoft.AspNetCore.Mvc.ModelBinding.IModelBinder,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -131,7 +131,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.&lt;BindProperty&gt;d__11.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.BindProperty(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand Down

1 change: 1 addition & 0 deletions
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpConnectionManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ public class HttpConnectionManagerTests : LoggedTest
#if !DEBUG
 [ConditionalFact]
 [NoDebuggerCondition]
 [QuarantinedTest("https://github.com/dotnet/runtime/issues/126735")]
 public async Task CriticalErrorLoggedIfApplicationDoesntComplete()
 {
 ////////////////////////////////////////////////////////////////////////////////////////
Expand Down

3 changes: 3 additions & 0 deletions
src/SignalR/clients/csharp/Client/test/FunctionalTests/Hubs.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@
using System.Linq;
using System.Reactive.Linq;
using System.Threading.Channels;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Authorization;
Expand DownExpand Up@@ -150,11 +151,13 @@ public class DynamicTestHub : DynamicHub

 public ChannelReader<string> StreamBroken() => TestHubMethodsImpl.StreamBroken();

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallEcho(string message)
 {
 await Clients.Client(Context.ConnectionId).Echo(message);
 }

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallHandlerThatDoesntExist()
 {
 await Clients.Client(Context.ConnectionId).NoClientHandler();
Expand Down

11 changes: 11 additions & 0 deletions
...gnalR/clients/csharp/Client/test/FunctionalTests/RuntimeAsyncMethodGenerationAttribute.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// Polyfill: RuntimeAsyncMethodGenerationAttribute is not yet public API
namespace System.Runtime.CompilerServices;

[AttributeUsage(AttributeTargets.Method)]
internal sealed class RuntimeAsyncMethodGenerationAttribute(bool runtimeAsync) : Attribute
{
 public bool RuntimeAsync { get; } = runtimeAsync;
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable runtime-async for SharedFx-only libraries by wtgodbe · Pull Request #66200 · dotnet/aspnetcore · GitHub
Skip to content
Enable runtime-async for SharedFx-only libraries#66200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wtgodbe
merged 19 commits into

from

Apr 24, 2026
 Merged


Enable runtime-async for SharedFx-only libraries
#66200
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


19 commits


Select commit
Hold shift + click to select a range
78e5400

Enable runtime-async for SharedFx-only libraries


wtgodbe Apr 7, 2026
fcbf787

Fix wasm exclusion: add RuntimeIdentifier check and fix comment


Copilot Apr 7, 2026
92cd2c0

Fix tests


wtgodbe Apr 7, 2026
c3283a0

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 7, 2026
013779f

Polyfill


wtgodbe Apr 7, 2026
ee72e5a

Fixup


wtgodbe Apr 7, 2026
79a22b2

Own file


wtgodbe Apr 7, 2026
e5a6be6

Whoops


wtgodbe Apr 7, 2026
a0096ab

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 8, 2026
84530c9

Quarantine CriticalErrorLoggedIfApplicationDoesntComplete test


Copilot Apr 13, 2026
0f7a1e4

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 14, 2026
d428189

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 15, 2026
031393c

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 20, 2026
51d2893

Add --blame-hang to E2E tests to identify hanging tests


wtgodbe Apr 21, 2026
626b3b3

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 21, 2026
56f72f7

Skip InputTextAreaWorksWithMutatingSetter under runtime-async


wtgodbe Apr 22, 2026
e92c952

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 22, 2026
fc44762

Remove IsTestAssetProject from runtime-async; revert components-e2e-t…


Copilot Apr 23, 2026
4eeefab

Enable InputTextAreaWorksWithMutatingSetter test


wtgodbe Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
Directory.Build.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,25 @@
 <BuildDependsOn>$(BuildDependsOn);_CopySymbolsToArtifacts</BuildDependsOn>
 </PropertyGroup>

 <!-- Enable runtime async for net11.0+ source projects that ship only in the Shared Framework -->
 <PropertyGroup Condition="'$(IsAspNetCoreApp)' == 'true' AND
 '$(IsPackable)' != 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Also enable runtime async for compatible test projects -->
@halter73halter73Apr 7, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the tests would fail if not for this, right? Otherwise, I'd probably want to run in both modes at least temporarily.
@wtgodbewtgodbeApr 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they would, but I'm largely cribbing off of what runtime did: dotnet/runtime#125406
 <PropertyGroup Condition="'$(IsTestProject)' == 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Properties for Package Validation -->
 <PropertyGroup Condition="'$(ExcludeFromSourceOnlyBuild)' != 'true'">
 <EnablePackageValidation Condition="'$(EnablePackageValidation)' == ''">true</EnablePackageValidation>
Expand Down

12 changes: 6 additions & 6 deletions
src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.WarningSuppressions.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,13 +83,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.&lt;ReadRequestBodyAsync&gt;d__9.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.ReadRequestBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.InputFormatterContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.&lt;WriteResponseBodyAsync&gt;d__5.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.WriteResponseBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.OutputFormatterWriteContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -101,7 +101,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.&lt;ExecuteAsync&gt;d__4.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.ExecuteAsync(Microsoft.AspNetCore.Mvc.ActionContext,Microsoft.AspNetCore.Mvc.JsonResult)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -113,13 +113,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.&lt;BindComplexCollectionFromIndexes&gt;d__22.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.BindComplexCollectionFromIndexes(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,System.Collections.Generic.IEnumerable{System.String})</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.&lt;BindPropertyAsync&gt;d__15.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.BindPropertyAsync(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,Microsoft.AspNetCore.Mvc.ModelBinding.IModelBinder,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -131,7 +131,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.&lt;BindProperty&gt;d__11.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.BindProperty(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand Down

1 change: 1 addition & 0 deletions
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpConnectionManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ public class HttpConnectionManagerTests : LoggedTest
#if !DEBUG
 [ConditionalFact]
 [NoDebuggerCondition]
 [QuarantinedTest("https://github.com/dotnet/runtime/issues/126735")]
 public async Task CriticalErrorLoggedIfApplicationDoesntComplete()
 {
 ////////////////////////////////////////////////////////////////////////////////////////
Expand Down

3 changes: 3 additions & 0 deletions
src/SignalR/clients/csharp/Client/test/FunctionalTests/Hubs.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@
using System.Linq;
using System.Reactive.Linq;
using System.Threading.Channels;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Authorization;
Expand DownExpand Up@@ -150,11 +151,13 @@ public class DynamicTestHub : DynamicHub

 public ChannelReader<string> StreamBroken() => TestHubMethodsImpl.StreamBroken();

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallEcho(string message)
 {
 await Clients.Client(Context.ConnectionId).Echo(message);
 }

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallHandlerThatDoesntExist()
 {
 await Clients.Client(Context.ConnectionId).NoClientHandler();
Expand Down

11 changes: 11 additions & 0 deletions
...gnalR/clients/csharp/Client/test/FunctionalTests/RuntimeAsyncMethodGenerationAttribute.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// Polyfill: RuntimeAsyncMethodGenerationAttribute is not yet public API
namespace System.Runtime.CompilerServices;

[AttributeUsage(AttributeTargets.Method)]
internal sealed class RuntimeAsyncMethodGenerationAttribute(bool runtimeAsync) : Attribute
{
 public bool RuntimeAsync { get; } = runtimeAsync;
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable runtime-async for SharedFx-only libraries by wtgodbe · Pull Request #66200 · dotnet/aspnetcore · GitHub
Skip to content
Enable runtime-async for SharedFx-only libraries#66200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wtgodbe
merged 19 commits into

from

Apr 24, 2026
 Merged


Enable runtime-async for SharedFx-only libraries
#66200
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


19 commits


Select commit
Hold shift + click to select a range
78e5400

Enable runtime-async for SharedFx-only libraries


wtgodbe Apr 7, 2026
fcbf787

Fix wasm exclusion: add RuntimeIdentifier check and fix comment


Copilot Apr 7, 2026
92cd2c0

Fix tests


wtgodbe Apr 7, 2026
c3283a0

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 7, 2026
013779f

Polyfill


wtgodbe Apr 7, 2026
ee72e5a

Fixup


wtgodbe Apr 7, 2026
79a22b2

Own file


wtgodbe Apr 7, 2026
e5a6be6

Whoops


wtgodbe Apr 7, 2026
a0096ab

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 8, 2026
84530c9

Quarantine CriticalErrorLoggedIfApplicationDoesntComplete test


Copilot Apr 13, 2026
0f7a1e4

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 14, 2026
d428189

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 15, 2026
031393c

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 20, 2026
51d2893

Add --blame-hang to E2E tests to identify hanging tests


wtgodbe Apr 21, 2026
626b3b3

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 21, 2026
56f72f7

Skip InputTextAreaWorksWithMutatingSetter under runtime-async


wtgodbe Apr 22, 2026
e92c952

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 22, 2026
fc44762

Remove IsTestAssetProject from runtime-async; revert components-e2e-t…


Copilot Apr 23, 2026
4eeefab

Enable InputTextAreaWorksWithMutatingSetter test


wtgodbe Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
Directory.Build.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,25 @@
 <BuildDependsOn>$(BuildDependsOn);_CopySymbolsToArtifacts</BuildDependsOn>
 </PropertyGroup>

 <!-- Enable runtime async for net11.0+ source projects that ship only in the Shared Framework -->
 <PropertyGroup Condition="'$(IsAspNetCoreApp)' == 'true' AND
 '$(IsPackable)' != 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Also enable runtime async for compatible test projects -->
@halter73halter73Apr 7, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the tests would fail if not for this, right? Otherwise, I'd probably want to run in both modes at least temporarily.
@wtgodbewtgodbeApr 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they would, but I'm largely cribbing off of what runtime did: dotnet/runtime#125406
 <PropertyGroup Condition="'$(IsTestProject)' == 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Properties for Package Validation -->
 <PropertyGroup Condition="'$(ExcludeFromSourceOnlyBuild)' != 'true'">
 <EnablePackageValidation Condition="'$(EnablePackageValidation)' == ''">true</EnablePackageValidation>
Expand Down

12 changes: 6 additions & 6 deletions
src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.WarningSuppressions.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,13 +83,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.&lt;ReadRequestBodyAsync&gt;d__9.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.ReadRequestBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.InputFormatterContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.&lt;WriteResponseBodyAsync&gt;d__5.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.WriteResponseBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.OutputFormatterWriteContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -101,7 +101,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.&lt;ExecuteAsync&gt;d__4.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.ExecuteAsync(Microsoft.AspNetCore.Mvc.ActionContext,Microsoft.AspNetCore.Mvc.JsonResult)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -113,13 +113,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.&lt;BindComplexCollectionFromIndexes&gt;d__22.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.BindComplexCollectionFromIndexes(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,System.Collections.Generic.IEnumerable{System.String})</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.&lt;BindPropertyAsync&gt;d__15.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.BindPropertyAsync(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,Microsoft.AspNetCore.Mvc.ModelBinding.IModelBinder,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -131,7 +131,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.&lt;BindProperty&gt;d__11.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.BindProperty(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand Down

1 change: 1 addition & 0 deletions
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpConnectionManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ public class HttpConnectionManagerTests : LoggedTest
#if !DEBUG
 [ConditionalFact]
 [NoDebuggerCondition]
 [QuarantinedTest("https://github.com/dotnet/runtime/issues/126735")]
 public async Task CriticalErrorLoggedIfApplicationDoesntComplete()
 {
 ////////////////////////////////////////////////////////////////////////////////////////
Expand Down

3 changes: 3 additions & 0 deletions
src/SignalR/clients/csharp/Client/test/FunctionalTests/Hubs.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@
using System.Linq;
using System.Reactive.Linq;
using System.Threading.Channels;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Authorization;
Expand DownExpand Up@@ -150,11 +151,13 @@ public class DynamicTestHub : DynamicHub

 public ChannelReader<string> StreamBroken() => TestHubMethodsImpl.StreamBroken();

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallEcho(string message)
 {
 await Clients.Client(Context.ConnectionId).Echo(message);
 }

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallHandlerThatDoesntExist()
 {
 await Clients.Client(Context.ConnectionId).NoClientHandler();
Expand Down

11 changes: 11 additions & 0 deletions
...gnalR/clients/csharp/Client/test/FunctionalTests/RuntimeAsyncMethodGenerationAttribute.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// Polyfill: RuntimeAsyncMethodGenerationAttribute is not yet public API
namespace System.Runtime.CompilerServices;

[AttributeUsage(AttributeTargets.Method)]
internal sealed class RuntimeAsyncMethodGenerationAttribute(bool runtimeAsync) : Attribute
{
 public bool RuntimeAsync { get; } = runtimeAsync;
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Enable runtime-async for SharedFx-only libraries by wtgodbe · Pull Request #66200 · dotnet/aspnetcore · GitHub
Skip to content
Enable runtime-async for SharedFx-only libraries#66200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wtgodbe
merged 19 commits into

from

Apr 24, 2026
 Merged


Enable runtime-async for SharedFx-only libraries
#66200
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


19 commits


Select commit
Hold shift + click to select a range
78e5400

Enable runtime-async for SharedFx-only libraries


wtgodbe Apr 7, 2026
fcbf787

Fix wasm exclusion: add RuntimeIdentifier check and fix comment


Copilot Apr 7, 2026
92cd2c0

Fix tests


wtgodbe Apr 7, 2026
c3283a0

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 7, 2026
013779f

Polyfill


wtgodbe Apr 7, 2026
ee72e5a

Fixup


wtgodbe Apr 7, 2026
79a22b2

Own file


wtgodbe Apr 7, 2026
e5a6be6

Whoops


wtgodbe Apr 7, 2026
a0096ab

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 8, 2026
84530c9

Quarantine CriticalErrorLoggedIfApplicationDoesntComplete test


Copilot Apr 13, 2026
0f7a1e4

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 14, 2026
d428189

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 15, 2026
031393c

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 20, 2026
51d2893

Add --blame-hang to E2E tests to identify hanging tests


wtgodbe Apr 21, 2026
626b3b3

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 21, 2026
56f72f7

Skip InputTextAreaWorksWithMutatingSetter under runtime-async


wtgodbe Apr 22, 2026
e92c952

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 22, 2026
fc44762

Remove IsTestAssetProject from runtime-async; revert components-e2e-t…


Copilot Apr 23, 2026
4eeefab

Enable InputTextAreaWorksWithMutatingSetter test


wtgodbe Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
Directory.Build.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,25 @@
 <BuildDependsOn>$(BuildDependsOn);_CopySymbolsToArtifacts</BuildDependsOn>
 </PropertyGroup>

 <!-- Enable runtime async for net11.0+ source projects that ship only in the Shared Framework -->
 <PropertyGroup Condition="'$(IsAspNetCoreApp)' == 'true' AND
 '$(IsPackable)' != 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Also enable runtime async for compatible test projects -->
@halter73halter73Apr 7, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the tests would fail if not for this, right? Otherwise, I'd probably want to run in both modes at least temporarily.
@wtgodbewtgodbeApr 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they would, but I'm largely cribbing off of what runtime did: dotnet/runtime#125406
 <PropertyGroup Condition="'$(IsTestProject)' == 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Properties for Package Validation -->
 <PropertyGroup Condition="'$(ExcludeFromSourceOnlyBuild)' != 'true'">
 <EnablePackageValidation Condition="'$(EnablePackageValidation)' == ''">true</EnablePackageValidation>
Expand Down

12 changes: 6 additions & 6 deletions
src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.WarningSuppressions.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,13 +83,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.&lt;ReadRequestBodyAsync&gt;d__9.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.ReadRequestBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.InputFormatterContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.&lt;WriteResponseBodyAsync&gt;d__5.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.WriteResponseBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.OutputFormatterWriteContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -101,7 +101,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.&lt;ExecuteAsync&gt;d__4.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.ExecuteAsync(Microsoft.AspNetCore.Mvc.ActionContext,Microsoft.AspNetCore.Mvc.JsonResult)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -113,13 +113,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.&lt;BindComplexCollectionFromIndexes&gt;d__22.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.BindComplexCollectionFromIndexes(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,System.Collections.Generic.IEnumerable{System.String})</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.&lt;BindPropertyAsync&gt;d__15.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.BindPropertyAsync(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,Microsoft.AspNetCore.Mvc.ModelBinding.IModelBinder,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -131,7 +131,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.&lt;BindProperty&gt;d__11.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.BindProperty(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand Down

1 change: 1 addition & 0 deletions
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpConnectionManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ public class HttpConnectionManagerTests : LoggedTest
#if !DEBUG
 [ConditionalFact]
 [NoDebuggerCondition]
 [QuarantinedTest("https://github.com/dotnet/runtime/issues/126735")]
 public async Task CriticalErrorLoggedIfApplicationDoesntComplete()
 {
 ////////////////////////////////////////////////////////////////////////////////////////
Expand Down

3 changes: 3 additions & 0 deletions
src/SignalR/clients/csharp/Client/test/FunctionalTests/Hubs.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@
using System.Linq;
using System.Reactive.Linq;
using System.Threading.Channels;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Authorization;
Expand DownExpand Up@@ -150,11 +151,13 @@ public class DynamicTestHub : DynamicHub

 public ChannelReader<string> StreamBroken() => TestHubMethodsImpl.StreamBroken();

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallEcho(string message)
 {
 await Clients.Client(Context.ConnectionId).Echo(message);
 }

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallHandlerThatDoesntExist()
 {
 await Clients.Client(Context.ConnectionId).NoClientHandler();
Expand Down

11 changes: 11 additions & 0 deletions
...gnalR/clients/csharp/Client/test/FunctionalTests/RuntimeAsyncMethodGenerationAttribute.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// Polyfill: RuntimeAsyncMethodGenerationAttribute is not yet public API
namespace System.Runtime.CompilerServices;

[AttributeUsage(AttributeTargets.Method)]
internal sealed class RuntimeAsyncMethodGenerationAttribute(bool runtimeAsync) : Attribute
{
 public bool RuntimeAsync { get; } = runtimeAsync;
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable runtime-async for SharedFx-only libraries by wtgodbe · Pull Request #66200 · dotnet/aspnetcore · GitHub
Skip to content
Enable runtime-async for SharedFx-only libraries#66200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wtgodbe
merged 19 commits into

from

Apr 24, 2026
 Merged


Enable runtime-async for SharedFx-only libraries
#66200
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


19 commits


Select commit
Hold shift + click to select a range
78e5400

Enable runtime-async for SharedFx-only libraries


wtgodbe Apr 7, 2026
fcbf787

Fix wasm exclusion: add RuntimeIdentifier check and fix comment


Copilot Apr 7, 2026
92cd2c0

Fix tests


wtgodbe Apr 7, 2026
c3283a0

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 7, 2026
013779f

Polyfill


wtgodbe Apr 7, 2026
ee72e5a

Fixup


wtgodbe Apr 7, 2026
79a22b2

Own file


wtgodbe Apr 7, 2026
e5a6be6

Whoops


wtgodbe Apr 7, 2026
a0096ab

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 8, 2026
84530c9

Quarantine CriticalErrorLoggedIfApplicationDoesntComplete test


Copilot Apr 13, 2026
0f7a1e4

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 14, 2026
d428189

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 15, 2026
031393c

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 20, 2026
51d2893

Add --blame-hang to E2E tests to identify hanging tests


wtgodbe Apr 21, 2026
626b3b3

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 21, 2026
56f72f7

Skip InputTextAreaWorksWithMutatingSetter under runtime-async


wtgodbe Apr 22, 2026
e92c952

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 22, 2026
fc44762

Remove IsTestAssetProject from runtime-async; revert components-e2e-t…


Copilot Apr 23, 2026
4eeefab

Enable InputTextAreaWorksWithMutatingSetter test


wtgodbe Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
Directory.Build.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,25 @@
 <BuildDependsOn>$(BuildDependsOn);_CopySymbolsToArtifacts</BuildDependsOn>
 </PropertyGroup>

 <!-- Enable runtime async for net11.0+ source projects that ship only in the Shared Framework -->
 <PropertyGroup Condition="'$(IsAspNetCoreApp)' == 'true' AND
 '$(IsPackable)' != 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Also enable runtime async for compatible test projects -->
@halter73halter73Apr 7, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the tests would fail if not for this, right? Otherwise, I'd probably want to run in both modes at least temporarily.
@wtgodbewtgodbeApr 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they would, but I'm largely cribbing off of what runtime did: dotnet/runtime#125406
 <PropertyGroup Condition="'$(IsTestProject)' == 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Properties for Package Validation -->
 <PropertyGroup Condition="'$(ExcludeFromSourceOnlyBuild)' != 'true'">
 <EnablePackageValidation Condition="'$(EnablePackageValidation)' == ''">true</EnablePackageValidation>
Expand Down

12 changes: 6 additions & 6 deletions
src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.WarningSuppressions.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,13 +83,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.&lt;ReadRequestBodyAsync&gt;d__9.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.ReadRequestBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.InputFormatterContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.&lt;WriteResponseBodyAsync&gt;d__5.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.WriteResponseBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.OutputFormatterWriteContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -101,7 +101,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.&lt;ExecuteAsync&gt;d__4.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.ExecuteAsync(Microsoft.AspNetCore.Mvc.ActionContext,Microsoft.AspNetCore.Mvc.JsonResult)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -113,13 +113,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.&lt;BindComplexCollectionFromIndexes&gt;d__22.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.BindComplexCollectionFromIndexes(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,System.Collections.Generic.IEnumerable{System.String})</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.&lt;BindPropertyAsync&gt;d__15.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.BindPropertyAsync(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,Microsoft.AspNetCore.Mvc.ModelBinding.IModelBinder,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -131,7 +131,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.&lt;BindProperty&gt;d__11.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.BindProperty(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand Down

1 change: 1 addition & 0 deletions
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpConnectionManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ public class HttpConnectionManagerTests : LoggedTest
#if !DEBUG
 [ConditionalFact]
 [NoDebuggerCondition]
 [QuarantinedTest("https://github.com/dotnet/runtime/issues/126735")]
 public async Task CriticalErrorLoggedIfApplicationDoesntComplete()
 {
 ////////////////////////////////////////////////////////////////////////////////////////
Expand Down

3 changes: 3 additions & 0 deletions
src/SignalR/clients/csharp/Client/test/FunctionalTests/Hubs.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@
using System.Linq;
using System.Reactive.Linq;
using System.Threading.Channels;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Authorization;
Expand DownExpand Up@@ -150,11 +151,13 @@ public class DynamicTestHub : DynamicHub

 public ChannelReader<string> StreamBroken() => TestHubMethodsImpl.StreamBroken();

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallEcho(string message)
 {
 await Clients.Client(Context.ConnectionId).Echo(message);
 }

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallHandlerThatDoesntExist()
 {
 await Clients.Client(Context.ConnectionId).NoClientHandler();
Expand Down

11 changes: 11 additions & 0 deletions
...gnalR/clients/csharp/Client/test/FunctionalTests/RuntimeAsyncMethodGenerationAttribute.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// Polyfill: RuntimeAsyncMethodGenerationAttribute is not yet public API
namespace System.Runtime.CompilerServices;

[AttributeUsage(AttributeTargets.Method)]
internal sealed class RuntimeAsyncMethodGenerationAttribute(bool runtimeAsync) : Attribute
{
 public bool RuntimeAsync { get; } = runtimeAsync;
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Enable runtime-async for SharedFx-only libraries by wtgodbe · Pull Request #66200 · dotnet/aspnetcore · GitHub
Skip to content
Enable runtime-async for SharedFx-only libraries#66200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wtgodbe
merged 19 commits into

from

Apr 24, 2026
 Merged


Enable runtime-async for SharedFx-only libraries
#66200
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


19 commits


Select commit
Hold shift + click to select a range
78e5400

Enable runtime-async for SharedFx-only libraries


wtgodbe Apr 7, 2026
fcbf787

Fix wasm exclusion: add RuntimeIdentifier check and fix comment


Copilot Apr 7, 2026
92cd2c0

Fix tests


wtgodbe Apr 7, 2026
c3283a0

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 7, 2026
013779f

Polyfill


wtgodbe Apr 7, 2026
ee72e5a

Fixup


wtgodbe Apr 7, 2026
79a22b2

Own file


wtgodbe Apr 7, 2026
e5a6be6

Whoops


wtgodbe Apr 7, 2026
a0096ab

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 8, 2026
84530c9

Quarantine CriticalErrorLoggedIfApplicationDoesntComplete test


Copilot Apr 13, 2026
0f7a1e4

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 14, 2026
d428189

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 15, 2026
031393c

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 20, 2026
51d2893

Add --blame-hang to E2E tests to identify hanging tests


wtgodbe Apr 21, 2026
626b3b3

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 21, 2026
56f72f7

Skip InputTextAreaWorksWithMutatingSetter under runtime-async


wtgodbe Apr 22, 2026
e92c952

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 22, 2026
fc44762

Remove IsTestAssetProject from runtime-async; revert components-e2e-t…


Copilot Apr 23, 2026
4eeefab

Enable InputTextAreaWorksWithMutatingSetter test


wtgodbe Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
Directory.Build.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,25 @@
 <BuildDependsOn>$(BuildDependsOn);_CopySymbolsToArtifacts</BuildDependsOn>
 </PropertyGroup>

 <!-- Enable runtime async for net11.0+ source projects that ship only in the Shared Framework -->
 <PropertyGroup Condition="'$(IsAspNetCoreApp)' == 'true' AND
 '$(IsPackable)' != 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Also enable runtime async for compatible test projects -->
@halter73halter73Apr 7, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the tests would fail if not for this, right? Otherwise, I'd probably want to run in both modes at least temporarily.
@wtgodbewtgodbeApr 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they would, but I'm largely cribbing off of what runtime did: dotnet/runtime#125406
 <PropertyGroup Condition="'$(IsTestProject)' == 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Properties for Package Validation -->
 <PropertyGroup Condition="'$(ExcludeFromSourceOnlyBuild)' != 'true'">
 <EnablePackageValidation Condition="'$(EnablePackageValidation)' == ''">true</EnablePackageValidation>
Expand Down

12 changes: 6 additions & 6 deletions
src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.WarningSuppressions.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,13 +83,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.&lt;ReadRequestBodyAsync&gt;d__9.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.ReadRequestBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.InputFormatterContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.&lt;WriteResponseBodyAsync&gt;d__5.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.WriteResponseBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.OutputFormatterWriteContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -101,7 +101,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.&lt;ExecuteAsync&gt;d__4.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.ExecuteAsync(Microsoft.AspNetCore.Mvc.ActionContext,Microsoft.AspNetCore.Mvc.JsonResult)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -113,13 +113,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.&lt;BindComplexCollectionFromIndexes&gt;d__22.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.BindComplexCollectionFromIndexes(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,System.Collections.Generic.IEnumerable{System.String})</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.&lt;BindPropertyAsync&gt;d__15.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.BindPropertyAsync(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,Microsoft.AspNetCore.Mvc.ModelBinding.IModelBinder,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -131,7 +131,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.&lt;BindProperty&gt;d__11.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.BindProperty(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand Down

1 change: 1 addition & 0 deletions
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpConnectionManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ public class HttpConnectionManagerTests : LoggedTest
#if !DEBUG
 [ConditionalFact]
 [NoDebuggerCondition]
 [QuarantinedTest("https://github.com/dotnet/runtime/issues/126735")]
 public async Task CriticalErrorLoggedIfApplicationDoesntComplete()
 {
 ////////////////////////////////////////////////////////////////////////////////////////
Expand Down

3 changes: 3 additions & 0 deletions
src/SignalR/clients/csharp/Client/test/FunctionalTests/Hubs.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@
using System.Linq;
using System.Reactive.Linq;
using System.Threading.Channels;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Authorization;
Expand DownExpand Up@@ -150,11 +151,13 @@ public class DynamicTestHub : DynamicHub

 public ChannelReader<string> StreamBroken() => TestHubMethodsImpl.StreamBroken();

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallEcho(string message)
 {
 await Clients.Client(Context.ConnectionId).Echo(message);
 }

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallHandlerThatDoesntExist()
 {
 await Clients.Client(Context.ConnectionId).NoClientHandler();
Expand Down

11 changes: 11 additions & 0 deletions
...gnalR/clients/csharp/Client/test/FunctionalTests/RuntimeAsyncMethodGenerationAttribute.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// Polyfill: RuntimeAsyncMethodGenerationAttribute is not yet public API
namespace System.Runtime.CompilerServices;

[AttributeUsage(AttributeTargets.Method)]
internal sealed class RuntimeAsyncMethodGenerationAttribute(bool runtimeAsync) : Attribute
{
 public bool RuntimeAsync { get; } = runtimeAsync;
}
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Enable runtime-async for SharedFx-only libraries by wtgodbe · Pull Request #66200 · dotnet/aspnetcore · GitHub
Skip to content
Enable runtime-async for SharedFx-only libraries#66200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

wtgodbe
merged 19 commits into

from

Apr 24, 2026
 Merged


Enable runtime-async for SharedFx-only libraries
#66200
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


19 commits


Select commit
Hold shift + click to select a range
78e5400

Enable runtime-async for SharedFx-only libraries


wtgodbe Apr 7, 2026
fcbf787

Fix wasm exclusion: add RuntimeIdentifier check and fix comment


Copilot Apr 7, 2026
92cd2c0

Fix tests


wtgodbe Apr 7, 2026
c3283a0

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 7, 2026
013779f

Polyfill


wtgodbe Apr 7, 2026
ee72e5a

Fixup


wtgodbe Apr 7, 2026
79a22b2

Own file


wtgodbe Apr 7, 2026
e5a6be6

Whoops


wtgodbe Apr 7, 2026
a0096ab

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 8, 2026
84530c9

Quarantine CriticalErrorLoggedIfApplicationDoesntComplete test


Copilot Apr 13, 2026
0f7a1e4

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 14, 2026
d428189

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 15, 2026
031393c

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 20, 2026
51d2893

Add --blame-hang to E2E tests to identify hanging tests


wtgodbe Apr 21, 2026
626b3b3

Merge branch 'main' into wtgodbe/runtime-async


wtgodbe Apr 21, 2026
56f72f7

Skip InputTextAreaWorksWithMutatingSetter under runtime-async


wtgodbe Apr 22, 2026
e92c952

Merge remote-tracking branch 'upstream/wtgodbe/runtime-async' into wt…


wtgodbe Apr 22, 2026
fc44762

Remove IsTestAssetProject from runtime-async; revert components-e2e-t…


Copilot Apr 23, 2026
4eeefab

Enable InputTextAreaWorksWithMutatingSetter test


wtgodbe Apr 23, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


19 changes: 19 additions & 0 deletions
Directory.Build.targets

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -138,6 +138,25 @@
 <BuildDependsOn>$(BuildDependsOn);_CopySymbolsToArtifacts</BuildDependsOn>
 </PropertyGroup>

 <!-- Enable runtime async for net11.0+ source projects that ship only in the Shared Framework -->
 <PropertyGroup Condition="'$(IsAspNetCoreApp)' == 'true' AND
 '$(IsPackable)' != 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Also enable runtime async for compatible test projects -->
@halter73halter73Apr 7, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that the tests would fail if not for this, right? Otherwise, I'd probably want to run in both modes at least temporarily.
@wtgodbewtgodbeApr 7, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they would, but I'm largely cribbing off of what runtime did: dotnet/runtime#125406
 <PropertyGroup Condition="'$(IsTestProject)' == 'true' AND
 $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net11.0')) AND
 '$(UseRuntimeAsync)' != 'false' AND
 '$(TargetOS)' != 'browser' AND
 !$(RuntimeIdentifier.StartsWith('browser-'))">
 <Features>$(Features);runtime-async=on</Features>
 </PropertyGroup>

 <!-- Properties for Package Validation -->
 <PropertyGroup Condition="'$(ExcludeFromSourceOnlyBuild)' != 'true'">
 <EnablePackageValidation Condition="'$(EnablePackageValidation)' == ''">true</EnablePackageValidation>
Expand Down

12 changes: 6 additions & 6 deletions
src/Mvc/Mvc.Core/src/Microsoft.AspNetCore.Mvc.Core.WarningSuppressions.xml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -83,13 +83,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.&lt;ReadRequestBodyAsync&gt;d__9.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonInputFormatter.ReadRequestBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.InputFormatterContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.&lt;WriteResponseBodyAsync&gt;d__5.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Formatters.SystemTextJsonOutputFormatter.WriteResponseBodyAsync(Microsoft.AspNetCore.Mvc.Formatters.OutputFormatterWriteContext,System.Text.Encoding)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -101,7 +101,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.&lt;ExecuteAsync&gt;d__4.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.Infrastructure.SystemTextJsonResultExecutor.ExecuteAsync(Microsoft.AspNetCore.Mvc.ActionContext,Microsoft.AspNetCore.Mvc.JsonResult)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -113,13 +113,13 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.&lt;BindComplexCollectionFromIndexes&gt;d__22.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.CollectionModelBinder`1.BindComplexCollectionFromIndexes(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,System.Collections.Generic.IEnumerable{System.String})</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.&lt;BindPropertyAsync&gt;d__15.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexObjectModelBinder.BindPropertyAsync(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,Microsoft.AspNetCore.Mvc.ModelBinding.IModelBinder,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand All@@ -131,7 +131,7 @@
 <argument>ILLink</argument>
 <argument>IL2026</argument>
 <property name="Scope">member</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.&lt;BindProperty&gt;d__11.MoveNext</property>
 <property name="Target">M:Microsoft.AspNetCore.Mvc.ModelBinding.Binders.ComplexTypeModelBinder.BindProperty(Microsoft.AspNetCore.Mvc.ModelBinding.ModelBindingContext,Microsoft.AspNetCore.Mvc.ModelBinding.ModelMetadata,System.String,System.String)</property>
 </attribute>
 <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
 <argument>ILLink</argument>
Expand Down

1 change: 1 addition & 0 deletions
src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpConnectionManagerTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,6 +21,7 @@ public class HttpConnectionManagerTests : LoggedTest
#if !DEBUG
 [ConditionalFact]
 [NoDebuggerCondition]
 [QuarantinedTest("https://github.com/dotnet/runtime/issues/126735")]
 public async Task CriticalErrorLoggedIfApplicationDoesntComplete()
 {
 ////////////////////////////////////////////////////////////////////////////////////////
Expand Down

3 changes: 3 additions & 0 deletions
src/SignalR/clients/csharp/Client/test/FunctionalTests/Hubs.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,6 +6,7 @@
using System.Linq;
using System.Reactive.Linq;
using System.Threading.Channels;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authentication.JwtBearer;
using Microsoft.AspNetCore.Authorization;
Expand DownExpand Up@@ -150,11 +151,13 @@ public class DynamicTestHub : DynamicHub

 public ChannelReader<string> StreamBroken() => TestHubMethodsImpl.StreamBroken();

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallEcho(string message)
 {
 await Clients.Client(Context.ConnectionId).Echo(message);
 }

 [RuntimeAsyncMethodGeneration(false)]
 public async Task CallHandlerThatDoesntExist()
 {
 await Clients.Client(Context.ConnectionId).NoClientHandler();
Expand Down

11 changes: 11 additions & 0 deletions
...gnalR/clients/csharp/Client/test/FunctionalTests/RuntimeAsyncMethodGenerationAttribute.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// Polyfill: RuntimeAsyncMethodGenerationAttribute is not yet public API
namespace System.Runtime.CompilerServices;

[AttributeUsage(AttributeTargets.Method)]
internal sealed class RuntimeAsyncMethodGenerationAttribute(bool runtimeAsync) : Attribute
{
 public bool RuntimeAsync { get; } = runtimeAsync;
}
Loading