Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

add more f# tests - #6816

Merged
livarcocc merged 3 commits into
dotnet:release/2.0.0from
enricosada:fsharp_e2e
Jun 12, 2017
Merged

add more f# tests#6816
livarcocc merged 3 commits into
dotnet:release/2.0.0from
enricosada:fsharp_e2e

Conversation

@enricosada

@enricosadaenricosada commented Jun 9, 2017

Copy link
Copy Markdown
  • reenable F# test
  • add some e2e
    • dotnet new {templates} -lang f#
    • dotnet build
    • dotnet run
    • dotnet pack

Todo for another PR (just a remainder for myself)

  • dotnet test (xunit)
  • dotnet add (package. p2p)
  • dotnet remove (package, p2p)
  • dotnet publish (fdd, scd)
  • dotnet sln (add, remove)

@enricosada

Copy link
Copy Markdown
Author

@livarcocc that's what i was speaking about with https://github.com/dotnet/cli/issues/6813#issuecomment-307433277

is ok to target release/2.0.0 branch?

@enricosada

Copy link
Copy Markdown
Author

@dotnet-bot Test Windows_NT x86 Debug Build please.

@enricosada

Copy link
Copy Markdown
Author

@livarcocc i'd like to add just one test (the happy path, no special options) for each command, is ok?

@nguerrera

Copy link
Copy Markdown
Contributor

We should add basic F# coverage in dotnet/sdk repo as well. I just spotted an incoming break: dotnet/sdk#1329 (comment)

@nguerrera

Copy link
Copy Markdown
Contributor

@enricosada Can you do the other checkboxes as a separate PR? I'd like us to gain better F# coverage ASAP rather than wait for the full set to be written.

@enricosada

Copy link
Copy Markdown
Author

@nguerrera Sure, @livarcocc this PR is finished, can be merged if ok.

I'll send another next week too, with others.

@nguerrera i'll add more to sdk too, i'ld like to move also some of dotnet/netcorecli-fsc test suite too. Added dotnet/sdk#1334 to track it

@enricosada

Copy link
Copy Markdown
Author

@dotnet-bot Test Debian8.2 x64 Debug Build please.
@dotnet-bot Test Windows_NT x86 Debug Build please.

@livarcocclivarcocc added this to the 2.0.0 milestone Jun 12, 2017
@livarcocc

Copy link
Copy Markdown

@MattGertz This is a test only change.

@livarcocc
livarcocc merged commit 3ea6a6e into dotnet:release/2.0.0Jun 12, 2017
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), testAsset.props))\testAsset.props" />

<PropertyGroup>
<TargetFramework>netcoreapp2.0</TargetFramework>

This comment was marked as spam.

This comment was marked as spam.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@enricosada@nguerrera@livarcocc@dsyme@dnfclas