Support for ARM64 on UNIX like systems compiler and runtime by RalfKornmannEnvision · Pull Request #8271 · dotnet/corert

RalfKornmannEnvision · 2020-08-20T06:36:00Z

Implements most of the missing parts for ARM64 on UNIX like hosts.

Change section for native signature layout from read only to data for non Windows systems to avoid linker issues with absolute relocations between sections
Store CFI data for ARM64 non Windows builds
Add special ARM64 relocation types were needed
Implements functions to handle 28 bit offsets in ARM64 opcodes
Implements ARM64 instruction encoding
Implements helper nodes ARM64 code generators
Implements ARM64 intrinsic supports by following the XArch pattern
Implements runtime query and check of required intrinsics
Use special name for AssignRef helper functions as RyuJit uses a custom calling convention for these on ARM64
Change relocation type for exception type in catch handler to avoid an assert in LLVM. The old one marked the symbol as code but it's data.
Fix the runtime to handle the new relocation type correct
Add post processing for ARM64 CFI data to ensure the unwinder can use them.
patch LLVM to handle ARM64 relocations in the way the object writer emits them
Add ARM64 ELF support to the object writer
Port syntax for all needed assembler functions (*.asm to *.S)
Implements new unwind helper that follows the AMD64 model (Shim over REGDISPLAY)
Add option to use only the dwarf index to search for unwind information. Needed when the linker removed anything else for different reasons.

Sync to Head

On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants

…indows target

* CoreRT-ARM64: Helper node asm code generation * CoreRT ARM64: Add additional relocation support * CoreRT ARM64: Use alternative functions for write Barriers On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants * ARM64 code generation * unwind use only the dwarf index option * ARM64 runtime assembler functions * ARM64 unix stack walk * ARM64 Exception Handling * ARM64: Fix EH data decodeing * Move nattive layout signature from read only to data section on non Windows target * Fix exception handling macro call * ARM64 thunk helpers * ARM64 process cfi data for elf * ARM64 missing assembler macro * ARM64 port more assembler helpers * ARM64: Add missing case for the gemeric helper node * ARM64 intrinsic support * ARM64 object writer for ELF object files * ARM64 llvm patches for object writer * ARM64 include untested helper code with debug break * ARM64 reenable scanning fail exception

Update to master

Update from master

…into ARM64

* CoreRT-ARM64: Helper node asm code generation * CoreRT ARM64: Add additional relocation support * CoreRT ARM64: Use alternative functions for write Barriers On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants * ARM64 code generation * unwind use only the dwarf index option * ARM64 runtime assembler functions * ARM64 unix stack walk * ARM64 Exception Handling * ARM64: Fix EH data decodeing * Move nattive layout signature from read only to data section on non Windows target * Fix exception handling macro call * ARM64 thunk helpers * ARM64 process cfi data for elf * ARM64 missing assembler macro * ARM64 port more assembler helpers * ARM64: Add missing case for the gemeric helper node * ARM64 intrinsic support * ARM64 object writer for ELF object files * ARM64 llvm patches for object writer * ARM64 include untested helper code with debug break * ARM64 reenable scanning fail exception

This reverts commit 6c9e235.

* CoreRT-ARM64: Helper node asm code generation * CoreRT ARM64: Add additional relocation support * CoreRT ARM64: Use alternative functions for write Barriers On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants * ARM64 code generation * unwind use only the dwarf index option * ARM64 runtime assembler functions * ARM64 unix stack walk * ARM64 Exception Handling * ARM64: Fix EH data decodeing * Move nattive layout signature from read only to data section on non Windows target * Fix exception handling macro call * ARM64 thunk helpers * ARM64 process cfi data for elf * ARM64 missing assembler macro * ARM64 port more assembler helpers * ARM64: Add missing case for the gemeric helper node * ARM64 intrinsic support * ARM64 object writer for ELF object files * ARM64 llvm patches for object writer * ARM64 include untested helper code with debug break * ARM64 reenable scanning fail exception * ARM64 formating * ARM64: revert using alternative JIT * Revert "ARM64 unix stack walk" This reverts commit 6c9e235.

This reverts commit c68cea1.

MichalStrehovsky

Looked at the AOT compiler changes so far, but looks great!

I'll look at the rest a bit later.

This reverts commit 37ce540.

* CoreRT-ARM64: Helper node asm code generation * CoreRT ARM64: Add additional relocation support * CoreRT ARM64: Use alternative functions for write Barriers On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants * ARM64 code generation * unwind use only the dwarf index option * ARM64 runtime assembler functions * ARM64 unix stack walk * ARM64 Exception Handling * ARM64: Fix EH data decodeing * Move nattive layout signature from read only to data section on non Windows target * Fix exception handling macro call * ARM64 thunk helpers * ARM64 process cfi data for elf * ARM64 missing assembler macro * ARM64 port more assembler helpers * ARM64: Add missing case for the gemeric helper node * ARM64 intrinsic support * ARM64 object writer for ELF object files * ARM64 llvm patches for object writer * ARM64 include untested helper code with debug break * ARM64 reenable scanning fail exception * ARM64 formating * ARM64: revert using alternative JIT * Revert "ARM64 unix stack walk" * ARM64 review reworks

Arm64: Fix function call for pinvoke result

Data is updated with a compare exchange operation. Therefore it needs to be aligned or it will trigger a data exception on ARM64 CPUs

ARM64: Ensure module fixup node data is aligned

jkotas

This looks great otherwise! Thank you!

MichalStrehovsky

Didn't look at the assembly helpers in detail, but the rest looks good! Thanks!

* ARM64: remove left over code

jkotas · 2020-08-27T17:33:23Z

@RalfKornmannEnvision Thank you again for this contribution! We really appreciate it.

* Fix alignment of marshaled inline arrays (dotnet#8275) Fixesdotnet#8274 * Correct flags for allocating in RhpNewFastMisalign. Add fast path (dotnet#8277) * add switch case for LPUTF8Str in array element (dotnet#8278) * Wasm: Add support for DefaultConstructorOf and hence Activator.CreateInstance<T> (dotnet#8279) * Wasm: upgrade emscripten for an llvm and exception fixes. (dotnet#8281) * upgrade emscripten for some llvm and exception fixes. Correct retrieval of exception from landing pad. end c++ exception when catch found. * Update ILToWebAssemblyImporter.cs remove cut/past comment * Wasm: add support for new StackTrace().ToString() (dotnet#8201) * wasm add rethrow support (dotnet#8206) * Wasm: add support for overflow checks on signed and unsigned ints multiply (dotnet#8259) * wasm-ovf-unsigned-int * refactor for stack kind tests and add signed check * use llvm intrinsics * Wasm: bring add and sub overflow operations in line with mul (dotnet#8284) * Support for ARM64 on UNIX like systems compiler and runtime (dotnet#8271) * CoreRT-ARM64: Helper node asm code generation * CoreRT ARM64: Add additional relocation support * CoreRT ARM64: Use alternative functions for write Barriers On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implementations. The helper nodes need to call the custom variants * ARM64 code generation * unwind use only the dwarf index option * ARM64 runtime assembler functions * ARM64 unix stack walk * ARM64 Exception Handling * ARM64: Fix EH data decoding * Move native layout signature from read only to data section on non Windows target * Fix exception handling macro call * ARM64 thunk helpers * ARM64 process cfi data for elf * ARM64 missing assembler macro * ARM64 port more assembler helpers * ARM64: Add missing case for the generic helper node * ARM64 intrinsic support * ARM64 object writer for ELF object files * ARM64 llvm patches for object writer * ARM64 include untested helper code with debug break * ARM64 reenable scanning fail exception * ARM64 Fix wrong function call for invoke return * ARM64: Ensure module fixup node data is aligned Data is updated with a compare exchange operation. Therefore it needs to be aligned or it will trigger a data exception on ARM64 CPUs * Wasm fix LLVM Debug Information subroutine linkage (dotnet#8288) * wasm - reinstate llvm debug subroutine linkage Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: yowl <scott.waye@hubse.com>

* Arm64 (#5) * CoreRT-ARM64: Helper node asm code generation * CoreRT ARM64: Add additional relocation support * CoreRT ARM64: Use alternative functions for write Barriers On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants * ARM64 code generation * unwind use only the dwarf index option * ARM64 runtime assembler functions * ARM64 unix stack walk * ARM64 Exception Handling * ARM64: Fix EH data decodeing * Move nattive layout signature from read only to data section on non Windows target * Fix exception handling macro call * ARM64 thunk helpers * ARM64 process cfi data for elf * ARM64 missing assembler macro * ARM64 port more assembler helpers * ARM64: Add missing case for the gemeric helper node * ARM64 intrinsic support * ARM64 object writer for ELF object files * ARM64 llvm patches for object writer * ARM64 include untested helper code with debug break * ARM64 reenable scanning fail exception * Arm64 (#6) * CoreRT-ARM64: Helper node asm code generation * CoreRT ARM64: Add additional relocation support * CoreRT ARM64: Use alternative functions for write Barriers On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants * ARM64 code generation * unwind use only the dwarf index option * ARM64 runtime assembler functions * ARM64 unix stack walk * ARM64 Exception Handling * ARM64: Fix EH data decodeing * Move nattive layout signature from read only to data section on non Windows target * Fix exception handling macro call * ARM64 thunk helpers * ARM64 process cfi data for elf * ARM64 missing assembler macro * ARM64 port more assembler helpers * ARM64: Add missing case for the gemeric helper node * ARM64 intrinsic support * ARM64 object writer for ELF object files * ARM64 llvm patches for object writer * ARM64 include untested helper code with debug break * ARM64 reenable scanning fail exception * ARM64 formating * ARM64: revert using alternative JIT * Revert "ARM64 unix stack walk" This reverts commit 6c9e235. * Arm64 (#7) * CoreRT-ARM64: Helper node asm code generation * CoreRT ARM64: Add additional relocation support * CoreRT ARM64: Use alternative functions for write Barriers On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants * ARM64 code generation * unwind use only the dwarf index option * ARM64 runtime assembler functions * ARM64 unix stack walk * ARM64 Exception Handling * ARM64: Fix EH data decodeing * Move nattive layout signature from read only to data section on non Windows target * Fix exception handling macro call * ARM64 thunk helpers * ARM64 process cfi data for elf * ARM64 missing assembler macro * ARM64 port more assembler helpers * ARM64: Add missing case for the gemeric helper node * ARM64 intrinsic support * ARM64 object writer for ELF object files * ARM64 llvm patches for object writer * ARM64 include untested helper code with debug break * ARM64 reenable scanning fail exception * ARM64 formating * ARM64: revert using alternative JIT * Revert "ARM64 unix stack walk" * ARM64 review reworks * Arm64: review reworks (#10) * Arm64 (#11) * ARM64: remove left over code * Update src/Native/Runtime/arm64/WriteBarriers.S * Sync to head (#12) * Fix alignment of marshaled inline arrays (dotnet#8275) Fixesdotnet#8274 * Correct flags for allocating in RhpNewFastMisalign. Add fast path (dotnet#8277) * add switch case for LPUTF8Str in array element (dotnet#8278) * Wasm: Add support for DefaultConstructorOf and hence Activator.CreateInstance<T> (dotnet#8279) * Wasm: upgrade emscripten for an llvm and exception fixes. (dotnet#8281) * upgrade emscripten for some llvm and exception fixes. Correct retrieval of exception from landing pad. end c++ exception when catch found. * Update ILToWebAssemblyImporter.cs remove cut/past comment * Wasm: add support for new StackTrace().ToString() (dotnet#8201) * wasm add rethrow support (dotnet#8206) * Wasm: add support for overflow checks on signed and unsigned ints multiply (dotnet#8259) * wasm-ovf-unsigned-int * refactor for stack kind tests and add signed check * use llvm intrinsics * Wasm: bring add and sub overflow operations in line with mul (dotnet#8284) * Support for ARM64 on UNIX like systems compiler and runtime (dotnet#8271) * CoreRT-ARM64: Helper node asm code generation * CoreRT ARM64: Add additional relocation support * CoreRT ARM64: Use alternative functions for write Barriers On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implementations. The helper nodes need to call the custom variants * ARM64 code generation * unwind use only the dwarf index option * ARM64 runtime assembler functions * ARM64 unix stack walk * ARM64 Exception Handling * ARM64: Fix EH data decoding * Move native layout signature from read only to data section on non Windows target * Fix exception handling macro call * ARM64 thunk helpers * ARM64 process cfi data for elf * ARM64 missing assembler macro * ARM64 port more assembler helpers * ARM64: Add missing case for the generic helper node * ARM64 intrinsic support * ARM64 object writer for ELF object files * ARM64 llvm patches for object writer * ARM64 include untested helper code with debug break * ARM64 reenable scanning fail exception * ARM64 Fix wrong function call for invoke return * ARM64: Ensure module fixup node data is aligned Data is updated with a compare exchange operation. Therefore it needs to be aligned or it will trigger a data exception on ARM64 CPUs * Wasm fix LLVM Debug Information subroutine linkage (dotnet#8288) * wasm - reinstate llvm debug subroutine linkage Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: yowl <scott.waye@hubse.com> Co-authored-by: Jan Kotas <jkotas@microsoft.com> Co-authored-by: yowl <scott.waye@hubse.com>

RalfKornmannEnvision added 30 commits July 17, 2020 08:41

Merge pull request#1from dotnet/master
a056f09
Sync to Head

CoreRT-ARM64: Helper node asm code generation
a8d26b2

CoreRT ARM64: Add additional relocation support
6c4b87b

CoreRT ARM64: Use alternative functions for write Barriers
404f4ed
On ARM the Jit uses a special register interface for to call the write barrier functions. But as the regular once still used in other places we need two different implemenations. The helper nodes need to call the custom variants

ARM64 code generation
9d4c4cb

unwind use only the dwarf index option
20021cb

ARM64 runtime assembler functions
39c6ceb

ARM64 unix stack walk
6c9e235

ARM64 Exception Handling
aba22ac

ARM64: Fix EH data decodeing
5b6bea5

Move nattive layout signature from read only to data section on non W…
86a4b8b
…indows target

Fix exception handling macro call
f98ba02

ARM64 thunk helpers
f289d85

ARM64 process cfi data for elf
986f61a

ARM64 missing assembler macro
b1481d6

ARM64 port more assembler helpers
5f3bb34

ARM64: Add missing case for the gemeric helper node
2fe1f65

ARM64 intrinsic support
11817b2

ARM64 object writer for ELF object files
08e0d52

ARM64 llvm patches for object writer
083ee8c

ARM64 include untested helper code with debug break
b8d0123

ARM64 reenable scanning fail exception
e70d94e

Merge pull request#3from dotnet/master
7f19a17
Update to master

Merge pull request#4from RalfKornmannEnvision/master
996d034
Update from master

ARM64 formating
d5766e0

ARM64: revert using alternative JIT
c0afb01

Merge branch 'ARM64' ofhttps://github.com/RalfKornmannEnvision/corert…
7c79156
…into ARM64

Revert "ARM64 unix stack walk"
c68cea1
This reverts commit 6c9e235.

RalfKornmannEnvision marked this pull request as ready for review August 20, 2020 08:41

RalfKornmannEnvision mentioned this pull request Aug 20, 2020
ARM64 and cross compile support #8236
Closed

Revert "Revert "ARM64 unix stack walk""
37ce540
This reverts commit c68cea1.

MichalStrehovsky reviewed Aug 20, 2020
View reviewed changes

RalfKornmannEnvision added 7 commits August 20, 2020 11:00

Revert "Revert "Revert "ARM64 unix stack walk"""
d1cf628
This reverts commit 37ce540.

ARM64 review reworks
be9d9e6

ARM64 Fix wrong function call for invoke return
d9d12f7

Merge pull request#8from RalfKornmannEnvision/ARM64
30b59ef
Arm64: Fix function call for pinvoke result

ARM64: Ensure module fixup node data is aligned
2bc790b
Data is updated with a compare exchange operation. Therefore it needs to be aligned or it will trigger a data exception on ARM64 CPUs

Merge pull request#9from RalfKornmannEnvision/ARM64
d0836ec
ARM64: Ensure module fixup node data is aligned

jkotas approved these changes Aug 25, 2020
View reviewed changes

Arm64: review reworks (#10)
65f6dff

MichalStrehovsky approved these changes Aug 27, 2020
View reviewed changes

Comment threadsrc/Native/ObjWriter/objwriter.cpp Outdated

Arm64 (#11)
ca7d15a
* ARM64: remove left over code

jkotas reviewed Aug 27, 2020
View reviewed changes

Comment threadsrc/Native/Runtime/arm64/WriteBarriers.S Outdated

Update src/Native/Runtime/arm64/WriteBarriers.S
a83496e

jkotas merged commit c01d95a into dotnet:masterAug 27, 2020

MichalStrehovsky mentioned this pull request Aug 31, 2020
Type manager indirection EEType vs. native layout signature #8261
Closed

am11 mentioned this pull request Jul 19, 2022
Update llvm-libunwind from v9.0.0 to v14.0.6 dotnet/runtime#72442
Merged

Navigation Menu

Uh oh!

Support for ARM64 on UNIX like systems compiler and runtime - #8271

Support for ARM64 on UNIX like systems compiler and runtime#8271
jkotas merged 42 commits into
dotnet:masterfrom
RalfKornmannEnvision:master

RalfKornmannEnvision commented Aug 20, 2020•
edited
Loading

Uh oh!

MichalStrehovsky left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichalStrehovsky left a comment

Uh oh!

Uh oh!

Uh oh!

jkotas commented Aug 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

RalfKornmannEnvision commented Aug 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichalStrehovsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichalStrehovsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jkotas commented Aug 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RalfKornmannEnvision commented Aug 20, 2020•
edited
Loading