Skip to content

New article - Migrate from Newtonsoft.Json - #16225

Merged
tdykstra merged 76 commits into
dotnet:masterfrom
tdykstra:jnmigrate
Jan 11, 2020
Merged

New article - Migrate from Newtonsoft.Json#16225
tdykstra merged 76 commits into
dotnet:masterfrom
tdykstra:jnmigrate

Conversation

@tdykstra

@tdykstratdykstra commented Dec 12, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@dotnet-botdotnet-bot added this to the December 2019 milestone Dec 12, 2019
@tdykstratdykstra reopened this Dec 13, 2019
@tdykstratdykstra reopened this Dec 13, 2019
@tdykstratdykstra changed the title WIP: Migrate from Json.NET articleMigrate from Json.NET articleDec 13, 2019
@tdykstra
tdykstra marked this pull request as ready for review December 13, 2019 18:59
@tdykstratdykstra changed the title Migrate from Json.NET articleNew article - Migrate from Json.NETDec 16, 2019
@ericstj

ericstj commented Dec 16, 2019

Copy link
Copy Markdown
Member

@tdykstra thank you for the huge doc!

@ahsonkhan@layomia@steveharter please have a look and help fill this out.

@ericstj

ericstj commented Dec 16, 2019

Copy link
Copy Markdown
Member

Also @pranavkm@rynowak

pranavkm
pranavkm reviewed Dec 16, 2019
View reviewed changes

@pranavkmpranavkm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Thraka
Thraka suggested changes Dec 16, 2019
View reviewed changes

@ThrakaThraka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things I think you should consider, and a few bugs

Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-how-to.md Outdated
Comment threaddocs/standard/serialization/toc.yml Outdated
ahsonkhan
ahsonkhan reviewed Jan 8, 2020
View reviewed changes
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
ahsonkhan
ahsonkhan reviewed Jan 8, 2020
View reviewed changes
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
ahsonkhan
ahsonkhan reviewed Jan 10, 2020
View reviewed changes
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
@tdykstra
tdykstra removed the request for review from HongGitJanuary 10, 2020 20:30
ahsonkhan
ahsonkhan reviewed Jan 10, 2020
View reviewed changes
Comment threaddocs/framework/wcf/feature-details/how-to-serialize-and-deserialize-json-data.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md
ahsonkhan
ahsonkhan reviewed Jan 10, 2020
View reviewed changes
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
ahsonkhan
ahsonkhan reviewed Jan 10, 2020
View reviewed changes
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
ahsonkhan
ahsonkhan reviewed Jan 11, 2020
View reviewed changes
Comment threaddocs/standard/serialization/system-text-json-migrate-from-newtonsoft-how-to.md Outdated
@tdykstra@ahsonkhan
Update docs/standard/serialization/system-text-json-migrate-from-newt…
30277d7
…onsoft-how-to.md
Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
@tdykstra
tdykstra merged commit eeecda4 into dotnet:masterJan 11, 2020
@tdykstra
tdykstra deleted the jnmigrate branch January 11, 2020 15:18
@ahsonkhan

ahsonkhan commented Jan 12, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

@tdykstra merged commit eeecda4 into dotnet:master yesterday

Hurray! Great job.

This was referenced Jan 13, 2020
Closed
Closed
Closed
@layomialayomia mentioned this pull request Mar 25, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagnerBillWagnerBillWagner approved these changes
@terrajobstterrajobstAwaiting requested review from terrajobst
@stevehartersteveharterAwaiting requested review from steveharter
+4 more reviewers
@pranavkmpranavkmpranavkm left review comments
@ahsonkhanahsonkhanahsonkhan left review comments
@layomialayomialayomia left review comments
@ThrakaThrakaThraka approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

December 2019

Development

Successfully merging this pull request may close these issues.

Create doc for System.Text.Json: migration from Json.NET / current limitations

8 participants

@tdykstra@ericstj@ahsonkhan@pranavkm@BillWagner@Thraka@layomia@dotnet-bot