Skip to content

Add entry for breaking change doc for 5.0 - #18542

Merged
gewarren merged 3 commits into
dotnet:masterfrom
buyaa-n:change_argex_to_ioe
May 27, 2020
Merged

Add entry for breaking change doc for 5.0#18542
gewarren merged 3 commits into
dotnet:masterfrom
buyaa-n:change_argex_to_ioe

Conversation

@buyaa-n

@buyaa-nbuyaa-n commented May 21, 2020

Copy link
Copy Markdown
Contributor

InvalidOperationException instead ArgumentException breaking change update

Starting in .NET Core 5.0, System.Diagnostics.PerformanceData.CounterSet.CreateCounterSetInstance(string instanceName) throws xref:System.InvalidOperationException instead of xref:System.ArgumentException if user attempt to create already existing instance.

Related to dotnet/runtime#35717

@buyaa-n
buyaa-n requested review from a team and gewarren as code ownersMay 21, 2020 02:20
@dotnet-botdotnet-bot added this to the May 2020 milestone May 21, 2020
gewarren
gewarren requested changes May 21, 2020
View reviewed changes

@gewarrengewarren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @buyaa-n. I left a few suggestions.

Comment threadincludes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md Outdated
Comment threadincludes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md Outdated
Comment threadincludes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md Outdated
Comment threadincludes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md Outdated
Comment threadincludes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md Outdated
@buyaa-n@gewarren
Apply suggestions from code review
4b826e6
Co-authored-by: Genevieve Warren <gewarren@microsoft.com>
@buyaa-n

buyaa-n commented May 21, 2020

Copy link
Copy Markdown
ContributorAuthor

Thanks for adding this @buyaa-n. I left a few suggestions.

Thank you @gewarren, feedbacks applied

gewarren
gewarren reviewed May 21, 2020
View reviewed changes

@gewarrengewarren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a few build warnings, so a couple more things to fix.

Comment threaddocs/core/compatibility/3.1-5.0.md Outdated
Comment threadincludes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md Outdated
Comment threaddocs/core/compatibility/corefx.md Outdated
Comment threadincludes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md Outdated
Comment threadincludes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md Outdated
Comment threadincludes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md Outdated
@buyaa-n@gewarren
Apply suggestions from code review
a201e45
Co-authored-by: Genevieve Warren <gewarren@microsoft.com>
@buyaa-n

buyaa-n commented May 26, 2020

Copy link
Copy Markdown
ContributorAuthor

There were a few build warnings, so a couple more things to fix.

@gewarren done thanks! Seems build passed

@gewarren
gewarren merged commit 20b44a6 into dotnet:masterMay 27, 2020
@buyaa-n
buyaa-n deleted the change_argex_to_ioe branch September 1, 2021 22:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarrengewarrengewarren approved these changes
@stephentoubstephentoubAwaiting requested review from stephentoub
@bartonjsbartonjsAwaiting requested review from bartonjs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

May 2020

Development

Successfully merging this pull request may close these issues.

4 participants

@buyaa-n@gewarren@BillWagner@dotnet-bot