Skip to content

Networking breaking change - #31595

Merged
gewarren merged 2 commits into
dotnet:mainfrom
gewarren:connectasync
Oct 5, 2022
Merged

Networking breaking change#31595
gewarren merged 2 commits into
dotnet:mainfrom
gewarren:connectasync

Conversation

@gewarren

@gewarrengewarren commented Oct 4, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

@dotnet-botdotnet-bot added this to the October 2022 milestone Oct 4, 2022
@gewarren
gewarren requested review from a team and CarnaViireOctober 4, 2022 21:50
CarnaViire
CarnaViire approved these changes Oct 5, 2022
View reviewed changes

@CarnaViireCarnaViire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

BillWagner
BillWagner approved these changes Oct 5, 2022
View reviewed changes

@BillWagnerBillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren
gewarren merged commit 8239d82 into dotnet:mainOct 5, 2022
@gewarren
gewarren deleted the connectasync branch October 5, 2022 15:12
@gewarrengewarren added the 🏁 Release: .NET 7 Work items for the .NET 7 release label Oct 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagnerBillWagnerBillWagner approved these changes
@CarnaViireCarnaViireCarnaViire approved these changes

Assignees

No one assigned

Labels

🏁 Release: .NET 7Work items for the .NET 7 releasedotnet-fundamentals/svc

Projects

None yet

Milestone

October 2022

Development

Successfully merging this pull request may close these issues.

[Breaking change]: ClientWebSocket.ConnectAsync throws ArgumentException on incompatible options

4 participants

@gewarren@BillWagner@CarnaViire@dotnet-bot