Uh oh!
There was an error while loading. Please reload this page.
Add preferreduilang to F# compiler options and FSI options table - #4193
Merged
Conversation
Roadkitten
approved these changes
Jan 24, 2018
BillWagner
approved these changes
Jan 24, 2018
BillWagner
left a comment
Member
There was a problem hiding this comment.
The change LGTM. I'll close and reopen to trigger a new build as the OPS build seems stuck.
Once the build is clean, I'll 
cartermp
commented
Jan 24, 2018
ContributorAuthor
Hang on - I'll add this to F# Interactive as well |
mairaw
commented
Jan 24, 2018
Contributor
there are some merge conflicts on the PR @cartermp |
mairaw
reviewed
Jan 25, 2018
| |**--out:<output-filename>**<br /><br />**-o:<output-filename>**|Specifies the name of the compiled assembly or module.<br /><br />This compiler option is equivalent to the C# compiler option of the same name. For more information, see [/out (C# Compiler Options)](https://msdn.microsoft.com/library/bw3t50f3.aspx).| | ||
| |**--pdb:<pdb-filename>**|Names the output debug PDB (program database) file. This option only applies when **--debug** is also enabled.<br /><br />This compiler option is equivalent to the C# compiler option of the same name. For more information, see [/pdb (C# Compiler Options)](https://msdn.microsoft.com/library/ms228625.aspx).| | ||
| |**--platform:<platform-name>**|Specifies that the generated code will only run on the specified platform (**x86**, **Itanium**, or **x64**), or, if the platform-name **anycpu** is chosen, specifies that the generated code can run on any platform.<br /><br />This compiler option is equivalent to the C# compiler option of the same name. For more information, see [/platform (C# Compiler Options)](https://msdn.microsoft.com/library/zekwfyz4.aspx).| | ||
| |**--preferreduilang:<lang>**| Specifies the preferred output language culture name (e.g. es-ES, ja-JP). | |
mairaw
requested changes
Jan 25, 2018
mairaw
left a comment
Contributor
There was a problem hiding this comment.
some small nits to be fixed
| |**--nologo**|Same as the **fsc.exe** compiler option. For more information, see [Compiler Options](../../language-reference/compiler-options.md).| | ||
| |**--nowarn:<warning-list>**|Same as the **fsc.exe** compiler option. For more information, see [Compiler Options](../../language-reference/compiler-options.md).| | ||
| |**--optimize**[**+**|**-**]|Same as the **fsc.exe** compiler option. For more information, see [Compiler Options](../../language-reference/compiler-options.md).| | ||
| |**--preferreduilang:<lang>**| Specifies the preferred output language culture name (e.g. es-ES, ja-JP). | |
| |Title|Description| | ||
| |-----|-----------| | ||
| |[F# Interactive Options](fsharp-interactive-options.md)|Describes command line syntax and options for the F# Interactive, fsi.exe.| | ||
| |[F# Interactive Options](../../language-reference/fsharp-interactive-options.md)|Describes command line syntax and options for the F# Interactive, fsi.exe.| |
mairaw
approved these changes
Jan 25, 2018
mairaw
left a comment
Contributor
There was a problem hiding this comment.
LGTM. You can merge it when build finishes
cartermp
commented
Jan 25, 2018
ContributorAuthor
🎉 |
cartermp
commented
Jan 26, 2018
ContributorAuthor
öööf that build is taking a while |
mairaw
commented
Jan 26, 2018
Contributor
The webhook seems to be failing for this PR. Not sure why. I can open a LSI in the morning if the issue persists. |
JRAlexander
commented
Jan 26, 2018
Contributor
Build still hung. Closing and reopening. |
Contributor
Submitted LSI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#4183
Also moves the FSI options table to the language reference, since that's a better place based on the fact that the compiler options table is there, too.