Skip to content

Update task-expressions.md - #45850

Merged
BillWagner merged 2 commits into
dotnet:mainfrom
Lanayx:patch-3
Apr 24, 2025
Merged

Update task-expressions.md#45850
BillWagner merged 2 commits into
dotnet:mainfrom
Lanayx:patch-3

Conversation

@Lanayx

@LanayxLanayx commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

Added and! section

Summary

Describe your changes here.

Relates to dotnet/fsharp#18451


Internal previews

📄 File🔗 Preview link
docs/fsharp/language-reference/task-expressions.mdTasks expressions

Added `and!` section
@dotnetrepomandotnetrepomanBot added this to the April 2025 milestone Apr 17, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added dotnet-fsharp/svc community-contribution Indicates PR is created by someone from the .NET community. labels Apr 17, 2025
@BillWagner

Copy link
Copy Markdown
Member

@T-Gro Can you give this a look?

@baronfelbaronfel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - @Lanayx would it be possible to link to the RFC/spec for how this is implemented so that users that want to understand the concurrency semantics can learn more? Something like:

For more details about this built-in support for concurrency, see RFC-1234

Also, there's a limitation involved with this current implementation, right? Might be good to have a Note: section outlining that rough edge.

@Lanayx

Copy link
Copy Markdown
ContributorAuthor

This LGTM - @Lanayx would it be possible to link to the RFC/spec for how this is implemented so that users that want to understand the concurrency semantics can learn more? Something like:

It's possible of course, I thought about it, but I'm not sure it's needed in place. I see this page as a reference for "how to use it", rather than "how does it work inside", so the link to implementation is a bit off topic in my view. Maybe adding to the links list at the bottom is a better option?

Also, there's a limitation involved with this current implementation, right?

No, there are no limitations, only space to improve performance in future. I don't think we should mention it on this page.

@T-Gro

Copy link
Copy Markdown
Member

Agree with @Lanayx , we don't put RFC details (sometimes very low level details) into docs ;; except for a footer as related links.

@BillWagnerBillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lanayx

This LGTM. I'll :shipit: after making a minor lint fix.

Comment threaddocs/fsharp/language-reference/task-expressions.md Outdated
@BillWagner
BillWagner enabled auto-merge (squash) April 24, 2025 14:29
@BillWagner
BillWagner merged commit 108eae0 into dotnet:mainApr 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributionIndicates PR is created by someone from the .NET community.dotnet-fsharp/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Lanayx@BillWagner@T-Gro@baronfel