Uh oh!
There was an error while loading. Please reload this page.
Fix disposed scope on TCP request timeout - #294
Open
Kowjako wants to merge 1 commit into
Open
Conversation
Kowjako
marked this pull request as ready for review
August 14, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
TcpServer.HandleConnectiondisposedtimeoutSourcein the per-requestfinallyblock and then inspected that scope in the outerOperationCanceledExceptionhandler. Because the cancellation source is pooled,CausedByTimeoutcould access an already disposed source and throwObjectDisposedExceptionfrom theasync voidconnection handler.Implementation
timeoutSourceinTcpServer.cs(lines 134-138).TcpServer.cs(line 150).TransportTestSuite.cs(lines 41 and 128-140).TcpTransportTests.cs(lines 99-119).Validation
git diff --check