Skip to content

CI update - .NET 9 GA - #10679

Merged
gewarren merged 12 commits into
dotnet:mainfrom
gewarren:net9-ga-chunked-redo
Nov 14, 2024
Merged

CI update - .NET 9 GA#10679
gewarren merged 12 commits into
dotnet:mainfrom
gewarren:net9-ga-chunked-redo

Conversation

@gewarren

@gewarrengewarren commented Nov 14, 2024

Copy link
Copy Markdown
Collaborator

Fixes#9991

View by commit.

@ghostghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Nov 14, 2024
@dotnet-policy-service

dotnet-policy-serviceBot commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

@gewarren - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead.

@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
This was referenced Nov 14, 2024
Merged
Merged
@gewarren
gewarren marked this pull request as ready for review November 14, 2024 04:10
@gewarren
gewarren enabled auto-merge (squash) November 14, 2024 04:11
@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
@carlossanlop

carlossanlop commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

A bunch of xrefs are not working.

@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod

learn-build-service-prodBot commented Nov 14, 2024

Copy link
Copy Markdown

Learn Build status updates of commit 9cfbf18:

⚠️ Validation status: warnings

FileStatusPreview URLDetails
xml/Microsoft.Extensions.DependencyInjection/AsyncStateExtensions.xml⚠️WarningViewDetails
xml/Microsoft.Extensions.Hosting.Internal/ConsoleLifetime.xml⚠️WarningViewDetails
xml/Microsoft.Extensions.Http/IHttpMessageHandlerBuilderFilter.xml⚠️WarningViewDetails
xml/System.Formats.Nrbf/ArrayRecord.xml⚠️WarningViewDetails
xml/Microsoft.Extensions.AI/AdditionalPropertiesDictionary.xml💡SuggestionViewDetails
xml/Microsoft.Extensions.AI/ConfigureOptionsChatClient.xml💡SuggestionViewDetails
xml/Microsoft.Extensions.AI/ConfigureOptionsEmbeddingGenerator`2.xml💡SuggestionViewDetails
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml💡SuggestionViewDetails
xml/Microsoft.Extensions.DependencyInjection/ServiceCollection.xml💡SuggestionViewDetails
xml/Microsoft.Extensions.DependencyInjection/ServiceLifetime.xml💡SuggestionViewDetails
xml/Microsoft.Extensions.Hosting/BackgroundServiceExceptionBehavior.xml💡SuggestionViewDetails
xml/Microsoft.Extensions.Http.Diagnostics/HttpRouteParameterRedactionMode.xml💡SuggestionViewDetails
_zip/missingapi.yml✅Succeeded
xml/FrameworksIndex/net-6.0-pp.xml✅Succeeded
xml/FrameworksIndex/net-7.0-pp.xml✅Succeededn/a (file deleted or renamed)
xml/FrameworksIndex/net-8.0-pp.xml✅Succeeded
xml/FrameworksIndex/net-9.0-pp.xml✅Succeeded
xml/FrameworksIndex/net-9.0.xml✅Succeeded
xml/FrameworksIndex/netframework-4.7-pp.xml✅Succeeded
xml/FrameworksIndex/netframework-4.7.1-pp.xml✅Succeeded
xml/FrameworksIndex/netframework-4.7.2-pp.xml✅Succeeded
xml/FrameworksIndex/netframework-4.8-pp.xml✅Succeeded
xml/FrameworksIndex/netframework-4.8.1-pp.xml✅Succeeded
xml/FrameworksIndex/netstandard-2.0-pp.xml✅Succeeded
xml/FrameworksIndex/netstandard-2.1-pp.xml✅Succeeded

This comment lists only the first 25 files in the pull request.

xml/Microsoft.Extensions.DependencyInjection/AsyncStateExtensions.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation]Cross reference not found: 'Microsoft.Extensions.AsyncState.IAsyncLocalContext`1'.

xml/Microsoft.Extensions.Hosting.Internal/ConsoleLifetime.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation]Cross reference not found: 'Microsoft.Extensions.Hosting.Internal.ConsoleLifetime.HostOptions'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation]Cross reference not found: 'Microsoft.Extensions.Hosting.Internal.ConsoleLifetime.HostOptions'.

xml/Microsoft.Extensions.Http/IHttpMessageHandlerBuilderFilter.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation]Cross reference not found: 'Microsoft.Extensions.Http.DefaultHttpClientFactory'.

xml/System.Formats.Nrbf/ArrayRecord.xml

  • [Warning: file-not-redirected - See documentation]File xml/System.Formats.Nrbf/ArrayRecord.xml with URL /dotnet/api/system.formats.nrbf.arrayrecord.flattenedlength was deleted without redirection. To avoid broken links, add a redirection.

xml/Microsoft.Extensions.AI/AdditionalPropertiesDictionary.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:TryGetValue(System.String,System.Object@) for uid: Microsoft.Extensions.AI.AdditionalPropertiesDictionary.TryGetValue(System.String,System.Object@).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs]Inheritdoc tag exists but no inheritdoc found for uid:Microsoft.Extensions.AI.AdditionalPropertiesDictionary.TryGetValue(System.String,System.Object@).

xml/Microsoft.Extensions.AI/ConfigureOptionsChatClient.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs]Inheritdoc tag exists but no inheritdoc found for uid:Microsoft.Extensions.AI.ConfigureOptionsChatClient.CompleteAsync(System.Collections.Generic.IList{Microsoft.Extensions.AI.ChatMessage},Microsoft.Extensions.AI.ChatOptions,System.Threading.CancellationToken).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs]Inheritdoc tag exists but no inheritdoc found for uid:Microsoft.Extensions.AI.ConfigureOptionsChatClient.CompleteStreamingAsync(System.Collections.Generic.IList{Microsoft.Extensions.AI.ChatMessage},Microsoft.Extensions.AI.ChatOptions,System.Threading.CancellationToken).

xml/Microsoft.Extensions.AI/ConfigureOptionsEmbeddingGenerator`2.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs]Inheritdoc tag exists but no inheritdoc found for uid:Microsoft.Extensions.AI.ConfigureOptionsEmbeddingGenerator`2.GenerateAsync(System.Collections.Generic.IEnumerable{`0},Microsoft.Extensions.AI.EmbeddingGenerationOptions,System.Threading.CancellationToken).

xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:CreateServiceProvider(Microsoft.Extensions.DependencyInjection.IServiceCollection) for uid: Microsoft.Extensions.DependencyInjection.DefaultServiceProviderFactory.CreateServiceProvider(Microsoft.Extensions.DependencyInjection.IServiceCollection).

xml/Microsoft.Extensions.DependencyInjection/ServiceCollection.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:Contains(Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.Contains(Microsoft.Extensions.DependencyInjection.ServiceDescriptor).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:CopyTo(Microsoft.Extensions.DependencyInjection.ServiceDescriptor[],System.Int32) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.CopyTo(Microsoft.Extensions.DependencyInjection.ServiceDescriptor[],System.Int32).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:IndexOf(Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.IndexOf(Microsoft.Extensions.DependencyInjection.ServiceDescriptor).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:Insert(System.Int32,Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.Insert(System.Int32,Microsoft.Extensions.DependencyInjection.ServiceDescriptor).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:Remove(Microsoft.Extensions.DependencyInjection.ServiceDescriptor) for uid: Microsoft.Extensions.DependencyInjection.ServiceCollection.Remove(Microsoft.Extensions.DependencyInjection.ServiceDescriptor).

xml/Microsoft.Extensions.DependencyInjection/ServiceLifetime.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks]Please note: <remarks> node on Enum fields will be ignored.

xml/Microsoft.Extensions.Hosting/BackgroundServiceExceptionBehavior.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks]Please note: <remarks> node on Enum fields will be ignored.

xml/Microsoft.Extensions.Http.Diagnostics/HttpRouteParameterRedactionMode.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks]Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren

gewarren commented Nov 14, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@carlossanlop I think the rest of the broken xrefs are beyond my control (they are internal types so not published on docs). Could you approve?

BillWagner
BillWagner approved these changes Nov 14, 2024
View reviewed changes

@BillWagnerBillWagner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a reasonable skimming of this commit-by-commit. This LGTM.

Let's :shipit:

@gewarren
gewarren merged commit 6d2d651 into dotnet:mainNov 14, 2024
@gewarren
gewarren deleted the net9-ga-chunked-redo branch November 14, 2024 20:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagnerBillWagnerBillWagner approved these changes
@Rick-AndersonRick-AndersonAwaiting requested review from Rick-Anderson
@HongGitHongGitAwaiting requested review from HongGit
@kouvelkouvelAwaiting requested review from kouvel
@StephenMolloyStephenMolloyAwaiting requested review from StephenMolloy
@mconnewmconnewAwaiting requested review from mconnewmconnew is a code owner
@AaronRobinsonMSFTAaronRobinsonMSFTAwaiting requested review from AaronRobinsonMSFTAaronRobinsonMSFT is a code owner
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinskyjkoritzinsky is a code owner
@halter73halter73Awaiting requested review from halter73halter73 is a code owner
@David-EngelDavid-EngelAwaiting requested review from David-EngelDavid-Engel is a code owner
@cheenamalhotracheenamalhotraAwaiting requested review from cheenamalhotracheenamalhotra is a code owner
@ajcvickersajcvickersAwaiting requested review from ajcvickers
@cstoncstonAwaiting requested review from cston
@333fred333fredAwaiting requested review from 333fred333fred is a code owner
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop

Assignees

@gewarrengewarren

Labels

area-MetaConcerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update API ref for .NET 9 GA

3 participants

@gewarren@carlossanlop@BillWagner