Uh oh!
There was an error while loading. Please reload this page.
Fix GeneratedRegexAttribute cultureName parameter documentation - #11975
Merged
Conversation
…cultureName parameter Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Port changes from dotnet/runtime PR 121073Fix GeneratedRegexAttribute cultureName parameter documentationOct 26, 2025
jkotas
marked this pull request as ready for review
October 26, 2025 23:46
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect documentation for the GeneratedRegexAttribute.cultureName parameter and CultureName property, correcting "case sensitive" to "case-insensitive" to accurately reflect that this parameter specifies which culture's casing rules apply during case-insensitive matching operations.
- Corrected parameter documentation in two constructor overloads
- Updated property summary documentation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
stephentoub
approved these changes
Oct 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports documentation fix from dotnet/runtime#121073. The
cultureNameparameter was incorrectly documented as being used for "case sensitive comparisons" when it's actually used for "case-insensitive comparisons."Changes
cultureNameparameter documentation in two constructor overloads (with and withoutmatchTimeoutMilliseconds)CultureNameproperty summaryThe parameter specifies which culture's casing rules to apply when performing case-insensitive matches (e.g., Turkish vs. English "i"/"I" mappings).
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.