Remove md shortcuts and their references - #5372

Merged
carlossanlop merged 236 commits into
dotnet:masterfrom
carlossanlop:shortcuts
Mar 3, 2021
Merged

Remove md shortcuts and their references#5372
carlossanlop merged 236 commits into
dotnet:masterfrom
carlossanlop:shortcuts

Conversation

@carlossanlop

@carlossanlopcarlossanlop commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

From a conversation with @gewarren, we want to remove the *.md shortcut files from the ~/include folder. These files contain texts representing official ways of calling different products or services, and they are referenced in markdown remarks all over dotnet-api-docs xmls.

We need to remove them because they prevent the DocsPortingTool from converting many remarks from CDATA+markdown into plain text (there is no way to convert INCLUDE sections to xml). We prefer to use plain xml so that Roslyn can validate triple slash comments (it is unable to validate a CDATA section).

I am requesting help from the heavy cavalry to review this huge PR: @gewarren@BillWagner @dotnet/docs @mairaw.

The PR is split in individual commits for each shortcut file to make it easier to review. I also deleted the referenced files, plus a few others that had no references anywhere.

I limited the removal of *.md files to only those whose contents have less than 80 characters. All other larger files can stay because they are what we call "lengthy remarks" and their use is repeated in many places.

In case anyone is curious, I wrote a tool to automate the substitution of all these shortcut files and uploaded it here: https://github.com/carlossanlop/experiments/tree/ShortcutReplacer

cc @jeffhandley

@carlossanlopcarlossanlop self-assigned this Feb 24, 2021
@ghostghost added the area-System.Net label Feb 24, 2021
gewarren
gewarren approved these changes Feb 25, 2021
View reviewed changes

@gewarrengewarren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks @carlossanlop! For the XAML2009 replacement, just wondering if there should be a space in the middle.

@carlossanlop

carlossanlop commented Feb 25, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I would not have done it if you had not suggested it, @gewarren :)

You're talking about MSBuild? I have always known it like that, without space in the middle.

I'll merge until the CI starts working again.

gewarren
gewarren reviewed Feb 25, 2021
View reviewed changes

@gewarrengewarren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the XAML2009 instances.

Comment threadxml/System.Xaml/XamlLanguage.xml Outdated
Comment threadxml/System.Xaml/XamlLanguage.xml Outdated
Comment threadxml/System.Xaml/XamlLanguage.xml Outdated
Comment threadxml/System.Xaml/XamlLanguage.xml Outdated
Comment threadxml/System.Xaml/XamlLanguage.xml Outdated
@carlossanlop@gewarren
Apply suggestions from code review
22dd25d
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlopcarlossanlop mentioned this pull request Feb 26, 2021
Closed
@gewarrengewarren closed this Mar 3, 2021
@gewarrengewarren reopened this Mar 3, 2021
@opbld31

opbld31 commented Mar 3, 2021

Copy link
Copy Markdown

Docs Build status updates of commit 22dd25d:

⚠️ Validation status: warnings

FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded

This comment lists only the first 50 files in the pull request.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.

xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.

xml/System.Security.Permissions/SecurityAction.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Web.UI.WebControls/ListView.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.

xml/System.Workflow.Activities/ReceiveActivity.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld34

opbld34 commented Mar 3, 2021

Copy link
Copy Markdown

Docs Build status updates of commit 22dd25d:

⚠️ Validation status: warnings

FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded

This comment lists only the first 50 files in the pull request.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.

xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.

xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.

xml/System.Security.Permissions/SecurityAction.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Web.UI.WebControls/ListView.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.

xml/System.Workflow.Activities/ReceiveActivity.xml

  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop

carlossanlop commented Mar 3, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I got warnings but they do not seem to be related to my changes. @gewarren is it ok if we merge this? Edit: Got Genevieve's confirmation via chat.

@carlossanlop
carlossanlop merged commit f6b6edc into dotnet:masterMar 3, 2021
@carlossanlop
carlossanlop deleted the shortcuts branch March 3, 2021 19:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarrengewarrengewarren approved these changes
@BillWagnerBillWagnerAwaiting requested review from BillWagner
@mairawmairawAwaiting requested review from mairaw

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@opbld31@opbld34@gewarren
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Remove md shortcuts and their references - #5372
Merged
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Mar 3, 2021
Merged
Remove md shortcuts and their references#5372
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Feb 24, 2021

Copy link


Copy Markdown

Contributor
From a conversation with @gewarren, we want to remove the *.md shortcut files from the ~/include folder. These files contain texts representing official ways of calling different products or services, and they are referenced in markdown remarks all over dotnet-api-docs xmls.
We need to remove them because they prevent the DocsPortingTool from converting many remarks from CDATA+markdown into plain text (there is no way to convert INCLUDE sections to xml). We prefer to use plain xml so that Roslyn can validate triple slash comments (it is unable to validate a CDATA section).
I am requesting help from the heavy cavalry to review this huge PR: @gewarren@BillWagner @dotnet/docs @mairaw.
The PR is split in individual commits for each shortcut file to make it easier to review. I also deleted the referenced files, plus a few others that had no references anywhere.
I limited the removal of *.md files to only those whose contents have less than 80 characters. All other larger files can stay because they are what we call "lengthy remarks" and their use is repeated in many places.
In case anyone is curious, I wrote a tool to automate the substitution of all these shortcut files and uploaded it here: https://github.com/carlossanlop/experiments/tree/ShortcutReplacer
cc @jeffhandley
@carlossanlopcarlossanlop
self-assigned this
Feb 24, 2021
@ghostghost
added
the 
area-System.Net

label
Feb 24, 2021
gewarren
gewarren
approved these changes
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks @carlossanlop! For the XAML2009 replacement, just wondering if there should be a space in the middle.
@carlossanlop
carlossanlop
commented
Feb 25, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I would not have done it if you had not suggested it, @gewarren :)
You're talking about MSBuild? I have always known it like that, without space in the middle.
I'll merge until the CI starts working again.
gewarren
gewarren
reviewed
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the XAML2009 instances.
Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

@carlossanlop@gewarren
Apply suggestions from code review
22dd25d
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlopcarlossanlop
mentioned this pull request
Feb 26, 2021
 Closed

@gewarrengewarren
closed this
Mar 3, 2021
@gewarrengewarren
reopened this
Mar 3, 2021
@opbld31
opbld31
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@opbld34
opbld34
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@carlossanlop
carlossanlop
commented
Mar 3, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I got warnings but they do not seem to be related to my changes. @gewarren is it ok if we merge this? Edit: Got Genevieve's confirmation via chat.
@carlossanlop
carlossanlop
merged commit f6b6edc
into
dotnet:masterMar 3, 2021
@carlossanlop
carlossanlop
deleted the

shortcuts

branch
March 3, 2021 19:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@gewarrengewarrengewarren approved these changes
@BillWagnerBillWagnerAwaiting requested review from BillWagner
@mairawmairawAwaiting requested review from mairaw

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@opbld31@opbld34@gewarren

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove md shortcuts and their references - #5372
Merged
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Mar 3, 2021
Merged
Remove md shortcuts and their references#5372
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Feb 24, 2021

Copy link


Copy Markdown

Contributor
From a conversation with @gewarren, we want to remove the *.md shortcut files from the ~/include folder. These files contain texts representing official ways of calling different products or services, and they are referenced in markdown remarks all over dotnet-api-docs xmls.
We need to remove them because they prevent the DocsPortingTool from converting many remarks from CDATA+markdown into plain text (there is no way to convert INCLUDE sections to xml). We prefer to use plain xml so that Roslyn can validate triple slash comments (it is unable to validate a CDATA section).
I am requesting help from the heavy cavalry to review this huge PR: @gewarren@BillWagner @dotnet/docs @mairaw.
The PR is split in individual commits for each shortcut file to make it easier to review. I also deleted the referenced files, plus a few others that had no references anywhere.
I limited the removal of *.md files to only those whose contents have less than 80 characters. All other larger files can stay because they are what we call "lengthy remarks" and their use is repeated in many places.
In case anyone is curious, I wrote a tool to automate the substitution of all these shortcut files and uploaded it here: https://github.com/carlossanlop/experiments/tree/ShortcutReplacer
cc @jeffhandley
@carlossanlopcarlossanlop
self-assigned this
Feb 24, 2021
@ghostghost
added
the 
area-System.Net

label
Feb 24, 2021
gewarren
gewarren
approved these changes
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks @carlossanlop! For the XAML2009 replacement, just wondering if there should be a space in the middle.
@carlossanlop
carlossanlop
commented
Feb 25, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I would not have done it if you had not suggested it, @gewarren :)
You're talking about MSBuild? I have always known it like that, without space in the middle.
I'll merge until the CI starts working again.
gewarren
gewarren
reviewed
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the XAML2009 instances.
Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

@carlossanlop@gewarren
Apply suggestions from code review
22dd25d
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlopcarlossanlop
mentioned this pull request
Feb 26, 2021
 Closed

@gewarrengewarren
closed this
Mar 3, 2021
@gewarrengewarren
reopened this
Mar 3, 2021
@opbld31
opbld31
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@opbld34
opbld34
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@carlossanlop
carlossanlop
commented
Mar 3, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I got warnings but they do not seem to be related to my changes. @gewarren is it ok if we merge this? Edit: Got Genevieve's confirmation via chat.
@carlossanlop
carlossanlop
merged commit f6b6edc
into
dotnet:masterMar 3, 2021
@carlossanlop
carlossanlop
deleted the

shortcuts

branch
March 3, 2021 19:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@gewarrengewarrengewarren approved these changes
@BillWagnerBillWagnerAwaiting requested review from BillWagner
@mairawmairawAwaiting requested review from mairaw

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@opbld31@opbld34@gewarren

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove md shortcuts and their references - #5372
Merged
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Mar 3, 2021
Merged
Remove md shortcuts and their references#5372
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Feb 24, 2021

Copy link


Copy Markdown

Contributor
From a conversation with @gewarren, we want to remove the *.md shortcut files from the ~/include folder. These files contain texts representing official ways of calling different products or services, and they are referenced in markdown remarks all over dotnet-api-docs xmls.
We need to remove them because they prevent the DocsPortingTool from converting many remarks from CDATA+markdown into plain text (there is no way to convert INCLUDE sections to xml). We prefer to use plain xml so that Roslyn can validate triple slash comments (it is unable to validate a CDATA section).
I am requesting help from the heavy cavalry to review this huge PR: @gewarren@BillWagner @dotnet/docs @mairaw.
The PR is split in individual commits for each shortcut file to make it easier to review. I also deleted the referenced files, plus a few others that had no references anywhere.
I limited the removal of *.md files to only those whose contents have less than 80 characters. All other larger files can stay because they are what we call "lengthy remarks" and their use is repeated in many places.
In case anyone is curious, I wrote a tool to automate the substitution of all these shortcut files and uploaded it here: https://github.com/carlossanlop/experiments/tree/ShortcutReplacer
cc @jeffhandley
@carlossanlopcarlossanlop
self-assigned this
Feb 24, 2021
@ghostghost
added
the 
area-System.Net

label
Feb 24, 2021
gewarren
gewarren
approved these changes
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks @carlossanlop! For the XAML2009 replacement, just wondering if there should be a space in the middle.
@carlossanlop
carlossanlop
commented
Feb 25, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I would not have done it if you had not suggested it, @gewarren :)
You're talking about MSBuild? I have always known it like that, without space in the middle.
I'll merge until the CI starts working again.
gewarren
gewarren
reviewed
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the XAML2009 instances.
Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

@carlossanlop@gewarren
Apply suggestions from code review
22dd25d
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlopcarlossanlop
mentioned this pull request
Feb 26, 2021
 Closed

@gewarrengewarren
closed this
Mar 3, 2021
@gewarrengewarren
reopened this
Mar 3, 2021
@opbld31
opbld31
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@opbld34
opbld34
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@carlossanlop
carlossanlop
commented
Mar 3, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I got warnings but they do not seem to be related to my changes. @gewarren is it ok if we merge this? Edit: Got Genevieve's confirmation via chat.
@carlossanlop
carlossanlop
merged commit f6b6edc
into
dotnet:masterMar 3, 2021
@carlossanlop
carlossanlop
deleted the

shortcuts

branch
March 3, 2021 19:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@gewarrengewarrengewarren approved these changes
@BillWagnerBillWagnerAwaiting requested review from BillWagner
@mairawmairawAwaiting requested review from mairaw

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@opbld31@opbld34@gewarren

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Remove md shortcuts and their references - #5372
Merged
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Mar 3, 2021
Merged
Remove md shortcuts and their references#5372
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Feb 24, 2021

Copy link


Copy Markdown

Contributor
From a conversation with @gewarren, we want to remove the *.md shortcut files from the ~/include folder. These files contain texts representing official ways of calling different products or services, and they are referenced in markdown remarks all over dotnet-api-docs xmls.
We need to remove them because they prevent the DocsPortingTool from converting many remarks from CDATA+markdown into plain text (there is no way to convert INCLUDE sections to xml). We prefer to use plain xml so that Roslyn can validate triple slash comments (it is unable to validate a CDATA section).
I am requesting help from the heavy cavalry to review this huge PR: @gewarren@BillWagner @dotnet/docs @mairaw.
The PR is split in individual commits for each shortcut file to make it easier to review. I also deleted the referenced files, plus a few others that had no references anywhere.
I limited the removal of *.md files to only those whose contents have less than 80 characters. All other larger files can stay because they are what we call "lengthy remarks" and their use is repeated in many places.
In case anyone is curious, I wrote a tool to automate the substitution of all these shortcut files and uploaded it here: https://github.com/carlossanlop/experiments/tree/ShortcutReplacer
cc @jeffhandley
@carlossanlopcarlossanlop
self-assigned this
Feb 24, 2021
@ghostghost
added
the 
area-System.Net

label
Feb 24, 2021
gewarren
gewarren
approved these changes
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks @carlossanlop! For the XAML2009 replacement, just wondering if there should be a space in the middle.
@carlossanlop
carlossanlop
commented
Feb 25, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I would not have done it if you had not suggested it, @gewarren :)
You're talking about MSBuild? I have always known it like that, without space in the middle.
I'll merge until the CI starts working again.
gewarren
gewarren
reviewed
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the XAML2009 instances.
Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

@carlossanlop@gewarren
Apply suggestions from code review
22dd25d
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlopcarlossanlop
mentioned this pull request
Feb 26, 2021
 Closed

@gewarrengewarren
closed this
Mar 3, 2021
@gewarrengewarren
reopened this
Mar 3, 2021
@opbld31
opbld31
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@opbld34
opbld34
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@carlossanlop
carlossanlop
commented
Mar 3, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I got warnings but they do not seem to be related to my changes. @gewarren is it ok if we merge this? Edit: Got Genevieve's confirmation via chat.
@carlossanlop
carlossanlop
merged commit f6b6edc
into
dotnet:masterMar 3, 2021
@carlossanlop
carlossanlop
deleted the

shortcuts

branch
March 3, 2021 19:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@gewarrengewarrengewarren approved these changes
@BillWagnerBillWagnerAwaiting requested review from BillWagner
@mairawmairawAwaiting requested review from mairaw

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@opbld31@opbld34@gewarren

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove md shortcuts and their references - #5372
Merged
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Mar 3, 2021
Merged
Remove md shortcuts and their references#5372
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Feb 24, 2021

Copy link


Copy Markdown

Contributor
From a conversation with @gewarren, we want to remove the *.md shortcut files from the ~/include folder. These files contain texts representing official ways of calling different products or services, and they are referenced in markdown remarks all over dotnet-api-docs xmls.
We need to remove them because they prevent the DocsPortingTool from converting many remarks from CDATA+markdown into plain text (there is no way to convert INCLUDE sections to xml). We prefer to use plain xml so that Roslyn can validate triple slash comments (it is unable to validate a CDATA section).
I am requesting help from the heavy cavalry to review this huge PR: @gewarren@BillWagner @dotnet/docs @mairaw.
The PR is split in individual commits for each shortcut file to make it easier to review. I also deleted the referenced files, plus a few others that had no references anywhere.
I limited the removal of *.md files to only those whose contents have less than 80 characters. All other larger files can stay because they are what we call "lengthy remarks" and their use is repeated in many places.
In case anyone is curious, I wrote a tool to automate the substitution of all these shortcut files and uploaded it here: https://github.com/carlossanlop/experiments/tree/ShortcutReplacer
cc @jeffhandley
@carlossanlopcarlossanlop
self-assigned this
Feb 24, 2021
@ghostghost
added
the 
area-System.Net

label
Feb 24, 2021
gewarren
gewarren
approved these changes
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks @carlossanlop! For the XAML2009 replacement, just wondering if there should be a space in the middle.
@carlossanlop
carlossanlop
commented
Feb 25, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I would not have done it if you had not suggested it, @gewarren :)
You're talking about MSBuild? I have always known it like that, without space in the middle.
I'll merge until the CI starts working again.
gewarren
gewarren
reviewed
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the XAML2009 instances.
Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

@carlossanlop@gewarren
Apply suggestions from code review
22dd25d
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlopcarlossanlop
mentioned this pull request
Feb 26, 2021
 Closed

@gewarrengewarren
closed this
Mar 3, 2021
@gewarrengewarren
reopened this
Mar 3, 2021
@opbld31
opbld31
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@opbld34
opbld34
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@carlossanlop
carlossanlop
commented
Mar 3, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I got warnings but they do not seem to be related to my changes. @gewarren is it ok if we merge this? Edit: Got Genevieve's confirmation via chat.
@carlossanlop
carlossanlop
merged commit f6b6edc
into
dotnet:masterMar 3, 2021
@carlossanlop
carlossanlop
deleted the

shortcuts

branch
March 3, 2021 19:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@gewarrengewarrengewarren approved these changes
@BillWagnerBillWagnerAwaiting requested review from BillWagner
@mairawmairawAwaiting requested review from mairaw

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@opbld31@opbld34@gewarren

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Remove md shortcuts and their references - #5372
Merged
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Mar 3, 2021
Merged
Remove md shortcuts and their references#5372
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Feb 24, 2021

Copy link


Copy Markdown

Contributor
From a conversation with @gewarren, we want to remove the *.md shortcut files from the ~/include folder. These files contain texts representing official ways of calling different products or services, and they are referenced in markdown remarks all over dotnet-api-docs xmls.
We need to remove them because they prevent the DocsPortingTool from converting many remarks from CDATA+markdown into plain text (there is no way to convert INCLUDE sections to xml). We prefer to use plain xml so that Roslyn can validate triple slash comments (it is unable to validate a CDATA section).
I am requesting help from the heavy cavalry to review this huge PR: @gewarren@BillWagner @dotnet/docs @mairaw.
The PR is split in individual commits for each shortcut file to make it easier to review. I also deleted the referenced files, plus a few others that had no references anywhere.
I limited the removal of *.md files to only those whose contents have less than 80 characters. All other larger files can stay because they are what we call "lengthy remarks" and their use is repeated in many places.
In case anyone is curious, I wrote a tool to automate the substitution of all these shortcut files and uploaded it here: https://github.com/carlossanlop/experiments/tree/ShortcutReplacer
cc @jeffhandley
@carlossanlopcarlossanlop
self-assigned this
Feb 24, 2021
@ghostghost
added
the 
area-System.Net

label
Feb 24, 2021
gewarren
gewarren
approved these changes
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks @carlossanlop! For the XAML2009 replacement, just wondering if there should be a space in the middle.
@carlossanlop
carlossanlop
commented
Feb 25, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I would not have done it if you had not suggested it, @gewarren :)
You're talking about MSBuild? I have always known it like that, without space in the middle.
I'll merge until the CI starts working again.
gewarren
gewarren
reviewed
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the XAML2009 instances.
Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

@carlossanlop@gewarren
Apply suggestions from code review
22dd25d
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlopcarlossanlop
mentioned this pull request
Feb 26, 2021
 Closed

@gewarrengewarren
closed this
Mar 3, 2021
@gewarrengewarren
reopened this
Mar 3, 2021
@opbld31
opbld31
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@opbld34
opbld34
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@carlossanlop
carlossanlop
commented
Mar 3, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I got warnings but they do not seem to be related to my changes. @gewarren is it ok if we merge this? Edit: Got Genevieve's confirmation via chat.
@carlossanlop
carlossanlop
merged commit f6b6edc
into
dotnet:masterMar 3, 2021
@carlossanlop
carlossanlop
deleted the

shortcuts

branch
March 3, 2021 19:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@gewarrengewarrengewarren approved these changes
@BillWagnerBillWagnerAwaiting requested review from BillWagner
@mairawmairawAwaiting requested review from mairaw

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@opbld31@opbld34@gewarren

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Remove md shortcuts and their references - #5372
Merged
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Mar 3, 2021
Merged
Remove md shortcuts and their references#5372
carlossanlop merged 236 commits into
dotnet:masterfrom 
carlossanlop:shortcuts
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Feb 24, 2021

Copy link


Copy Markdown

Contributor
From a conversation with @gewarren, we want to remove the *.md shortcut files from the ~/include folder. These files contain texts representing official ways of calling different products or services, and they are referenced in markdown remarks all over dotnet-api-docs xmls.
We need to remove them because they prevent the DocsPortingTool from converting many remarks from CDATA+markdown into plain text (there is no way to convert INCLUDE sections to xml). We prefer to use plain xml so that Roslyn can validate triple slash comments (it is unable to validate a CDATA section).
I am requesting help from the heavy cavalry to review this huge PR: @gewarren@BillWagner @dotnet/docs @mairaw.
The PR is split in individual commits for each shortcut file to make it easier to review. I also deleted the referenced files, plus a few others that had no references anywhere.
I limited the removal of *.md files to only those whose contents have less than 80 characters. All other larger files can stay because they are what we call "lengthy remarks" and their use is repeated in many places.
In case anyone is curious, I wrote a tool to automate the substitution of all these shortcut files and uploaded it here: https://github.com/carlossanlop/experiments/tree/ShortcutReplacer
cc @jeffhandley
@carlossanlopcarlossanlop
self-assigned this
Feb 24, 2021
@ghostghost
added
the 
area-System.Net

label
Feb 24, 2021
gewarren
gewarren
approved these changes
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks @carlossanlop! For the XAML2009 replacement, just wondering if there should be a space in the middle.
@carlossanlop
carlossanlop
commented
Feb 25, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I would not have done it if you had not suggested it, @gewarren :)
You're talking about MSBuild? I have always known it like that, without space in the middle.
I'll merge until the CI starts working again.
gewarren
gewarren
reviewed
Feb 25, 2021
View reviewed changes
@gewarrengewarren
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the XAML2009 instances.
Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

Comment threadxml/System.Xaml/XamlLanguage.xml
Outdated

@carlossanlop@gewarren
Apply suggestions from code review
22dd25d
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@carlossanlopcarlossanlop
mentioned this pull request
Feb 26, 2021
 Closed

@gewarrengewarren
closed this
Mar 3, 2021
@gewarrengewarren
reopened this
Mar 3, 2021
@opbld31
opbld31
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@opbld34
opbld34
commented
Mar 3, 2021

Copy link


Copy Markdown

Docs Build status updates of commit 22dd25d:
⚠️ Validation status: warnings
FileStatusPreview URLDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml⚠️WarningViewDetails
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml⚠️WarningViewDetails
xml/System.Security.Permissions/SecurityAction.xml⚠️WarningViewDetails
xml/System.Web.UI.WebControls/ListView.xml⚠️WarningViewDetails
xml/System.Workflow.Activities/ReceiveActivity.xml⚠️WarningViewDetails
includes/ado-whidbey-long-md.md✅Succeeded
includes/adonet-edm-md.md✅Succeeded
includes/adonet-ef-md.md✅Succeeded
includes/ajax-current-short-md.md✅Succeeded
includes/compact-md.md✅Succeeded
includes/cpp-iter-arg-md.md✅Succeeded
includes/csprcslong-md.md✅Succeeded
includes/desktop-appname-md.md✅Succeeded
includes/dnprdnext-md.md✅Succeeded
includes/dnprdnlong-md.md✅Succeeded
includes/dnprdnshort-md.md✅Succeeded
includes/dp-id-field-label-md.md✅Succeeded
includes/esql-md.md✅Succeeded
includes/iisver-md.md✅Succeeded
includes/infocard-md.md✅Succeeded
includes/linq-dataset-md.md✅Succeeded
includes/ndptecclick-md.md✅Succeeded
includes/ndptecgdi-md.md✅Succeeded
includes/ndptecgdiplus-md.md✅Succeeded
includes/net-client-v40-long-md.md✅Succeeded
includes/net-core-md.md✅Succeeded
includes/net-native-md.md✅Succeeded
includes/net-portable-md.md✅Succeeded
includes/net-v10-short-md.md✅Succeeded
includes/net-v11-long-md.md✅Succeeded
includes/net-v11-short-md.md✅Succeeded
includes/net-v20sp1-long-md.md✅Succeeded
includes/net-v20sp1-short-md.md✅Succeeded
includes/net-v30-long-md.md✅Succeeded
includes/net-v30-short-md.md✅Succeeded
includes/net-v35-long-md.md✅Succeeded
includes/net-v35-short-md.md✅Succeeded
includes/net-v35sp1-long-md.md✅Succeeded
includes/net-v35sp1-short-md.md✅Succeeded
includes/net-v40-long-md.md✅Succeeded
includes/net-v40-short-md.md✅Succeeded
includes/net-v45-md.md✅Succeeded
includes/net-v451-md.md✅Succeeded
This comment lists only the first 50 files in the pull request.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FetchCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+FieldChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+RecordsetChangeCompleteDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Error'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeFieldDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillChangeRecordsetDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC+WillMoveDelegate.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventReasonEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.EventStatusEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
xml/Microsoft.VisualBasic.Compatibility.VB6/ADODC.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.addDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.ConnectModeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberCount'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSourceListener'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.removeDataSourceListener(msdatasrc.DataSourceListener)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMemberName(System.Int32)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorLocationEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.Recordset'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.LockTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CursorTypeEnum'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource.getDataMember(System.String,System.Guid@)'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'ADODB.CommandTypeEnum'.
xml/Microsoft.VisualBasic.Compatibility.VB6/MBindingCollection.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'msdatasrc.DataSource'.
xml/System.Security.Permissions/SecurityAction.xml
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched]System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.
xml/System.Web.UI.WebControls/ListView.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.Web.WebSysDescriptionAttribute'.
xml/System.Workflow.Activities/ReceiveActivity.xml
  • Line 0, Column 0: [Warning-xref-not-found]Cross reference not found: 'System.ServiceModel.SRCategoryAttribute'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@carlossanlop
carlossanlop
commented
Mar 3, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
I got warnings but they do not seem to be related to my changes. @gewarren is it ok if we merge this? Edit: Got Genevieve's confirmation via chat.
@carlossanlop
carlossanlop
merged commit f6b6edc
into
dotnet:masterMar 3, 2021
@carlossanlop
carlossanlop
deleted the

shortcuts

branch
March 3, 2021 19:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@gewarrengewarrengewarren approved these changes
@BillWagnerBillWagnerAwaiting requested review from BillWagner
@mairawmairawAwaiting requested review from mairaw

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@opbld31@opbld34@gewarren