Skip to content

CI Update - .NET 7 RC 1 - #8380

Merged
gewarren merged 6 commits into
mainfrom
net7-rc1
Sep 15, 2022
Merged

CI Update - .NET 7 RC 1#8380
gewarren merged 6 commits into
mainfrom
net7-rc1

Conversation

@gewarren

@gewarrengewarren commented Sep 12, 2022

Copy link
Copy Markdown
Collaborator

Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries

VSC-Service-Account
CI Update
fa1c1ff
 Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@ghostghost assigned gewarrenSep 12, 2022
@ghostghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Sep 12, 2022
@opbld33

This comment was marked as outdated.

Sign in to view
@carlossanlop

carlossanlop commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.

Where does this error come from? Is this deleted file being referenced somewhere?

@gewarren

gewarren commented Sep 13, 2022

Copy link
Copy Markdown
CollaboratorAuthor

File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.

Where does this error come from? Is this deleted file being referenced somewhere?

You can ignore it. It's because that type was renamed to GeneratedRegexAttribute.

@carlossanlop@gewarren
RC1 - Update System.Formats.Tar docs (Backport#8375) (#8385)
db7194e
* Update System.Formats.Tar docs (#8375)
* Update tar docs
* Apply suggestions from code review
* Few more
* Update xml/System.Formats.Tar/GnuTarEntry.xml
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Formats.Tar/GnuTarEntry.xml
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry)
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Apply suggestions from code review
* Fix bullet lists
* Merge markdowns
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld34

This comment was marked as outdated.

Sign in to view
@carlossanlop

carlossanlop commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Tar changes included. Merge conflicts solved. I will generate RC2 intellisense from this, and will generate the undoc API report as well.

@opbld30

This comment was marked as outdated.

Sign in to view
@carlossanlopcarlossanlop mentioned this pull request Sep 14, 2022
Merged
@carlossanlop

carlossanlop commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Incoming PRs: #8390 and #8391

carlossanlopand others added 2 commits September 15, 2022 09:13
@carlossanlop@gewarren@radical
Port System.Runtime.InteropServices.Javascript docs to RC1 (#8390)
0effa38
* System.Runtime.InteropServices.Javascript RC1
* First batch of suggestions by gewarren
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Next batch of suggestions by gewarren.
* Apply suggestions from code review
* It's -> This API is
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@carlossanlop@gewarren
Assorted missing docs for RC1 (#8391)
66b6eca
* Assorted missing docs for RC1
* which -> that
* which -> that
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Diagnostics/TagList.xml
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31

This comment was marked as outdated.

Sign in to view
@opbld30

This comment was marked as outdated.

Sign in to view
gewarren
gewarren commented Sep 15, 2022
View reviewed changes
Comment threadxml/System.Windows.Forms/Control.xml
@gewarren
gewarren marked this pull request as ready for review September 15, 2022 20:41
@gewarren
gewarren requested a review from a team as a code ownerSeptember 15, 2022 20:41
@gewarren

gewarren commented Sep 15, 2022

Copy link
Copy Markdown
CollaboratorAuthor

@carlossanlop Are we good to merge this? If so can you approve?

carlossanlop
carlossanlop approved these changes Sep 15, 2022
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good from the perspective of runtime APIs. If WPF/WinForms need to add extra documentation, they can do it directly in main after we merge this.

@gewarren
gewarren enabled auto-merge (squash) September 15, 2022 21:24
@carlossanlop

carlossanlop commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

Don't merge this yet, please. The WinForms PR is targeting this branch: #8393

@opbld32

opbld32 commented Sep 15, 2022

Copy link
Copy Markdown

Docs Build status updates of commit 57d3f9f:

💡 Validation status: suggestions

FileStatusPreview URLDetails
xml/System.Net.Http.Headers/HeaderStringValues.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml💡SuggestionViewDetails
xml/System.Numerics/BigInteger.xml💡SuggestionViewDetails
xml/System.Numerics/Complex.xml💡SuggestionViewDetails
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml💡Suggestionn/a (file deleted)Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml✅Succeeded
xml/FrameworksIndex/net-7.0.xml✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml✅Succeeded
xml/Microsoft.Extensions.Configuration/ConfigurationBinder.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceCollectionContainerBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceProviderServiceExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting.Internal/HostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/Host.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptions.xml✅SucceededView
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml✅SucceededView

This comment lists only the first 25 files in the pull request.

xml/System.Net.Http.Headers/HeaderStringValues.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#String}#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#Generic#IEnumerable{System#String}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#IEnumerable#GetEnumerator.

xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Reset.

xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#IEnumerable#GetEnumerator.

xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Reset.

xml/System.Numerics/BigInteger.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.BigInteger.op_UnsignedRightShift(System.Numerics.BigInteger,System.Int32).

xml/System.Numerics/Complex.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Decrement(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Increment(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_UnaryPlus(System.Numerics.Complex).

xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml

  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren
gewarren merged commit 55d7a64 into mainSep 15, 2022
@gewarren
gewarren deleted the net7-rc1 branch September 15, 2022 21:52
@carlossanlop

carlossanlop commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

Nevermind, automerge 😄

@amzwzw

This comment was marked as off-topic.

Sign in to view
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RussKieRussKieAwaiting requested review from RussKie
@merriemcgawmerriemcgawAwaiting requested review from merriemcgaw
@HongGitHongGitAwaiting requested review from HongGit
@StephenMolloyStephenMolloyAwaiting requested review from StephenMolloyStephenMolloy is a code owner
@AaronRobinsonMSFTAaronRobinsonMSFTAwaiting requested review from AaronRobinsonMSFTAaronRobinsonMSFT is a code owner
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinskyjkoritzinsky is a code owner
@ajcvickersajcvickersAwaiting requested review from ajcvickers
@David-EngelDavid-EngelAwaiting requested review from David-Engel
@JRahnamaJRahnamaAwaiting requested review from JRahnama
1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gewarrengewarren

Labels

area-MetaConcerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gewarren@opbld33@carlossanlop@opbld34@opbld30@opbld31@opbld32@amzwzw
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
CI Update - .NET 7 RC 1 by gewarren · Pull Request #8380 · dotnet/dotnet-api-docs · GitHub
Skip to content
CI Update - .NET 7 RC 1 - #8380
Merged
gewarren merged 6 commits into
mainfrom 
net7-rc1
Sep 15, 2022
Merged
CI Update - .NET 7 RC 1#8380
gewarren merged 6 commits into
mainfrom 
net7-rc1
Conversation
@gewarren
@gewarrengewarren
commented
Sep 12, 2022

Copy link


Copy Markdown

Collaborator
Build.Reason:Manual by Genevieve Warren

Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results

source_repo.branch:net7-rc1

source_repo.url:https://apidrop.visualstudio.com/_git/binaries
VSC-Service-Account
CI Update
fa1c1ff
 Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@ghostghost
assigned gewarrenSep 12, 2022
@ghostghost
added
the 
area-Meta
Concerns something that extends across runtime area boundaries, for example, IDisposable.
label
Sep 12, 2022
@opbld33

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
@gewarren
gewarren
commented
Sep 13, 2022

Copy link


Copy Markdown

CollaboratorAuthor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
You can ignore it. It's because that type was renamed to GeneratedRegexAttribute.
@carlossanlop@gewarren
RC1 - Update System.Formats.Tar docs (Backport#8375) (#8385)
db7194e
* Update System.Formats.Tar docs (#8375)
* Update tar docs
* Apply suggestions from code review
* Few more
* Update xml/System.Formats.Tar/GnuTarEntry.xml
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Formats.Tar/GnuTarEntry.xml
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry)
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Apply suggestions from code review
* Fix bullet lists
* Merge markdowns
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld34

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Tar changes included. Merge conflicts solved. I will generate RC2 intellisense from this, and will generate the undoc API report as well.
@opbld30

This comment was marked as outdated.

Sign in to view
@carlossanlopcarlossanlop
mentioned this pull request
Sep 14, 2022
 Merged

@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Incoming PRs: #8390 and #8391
carlossanlopand others
added 2 commits
September 15, 2022 09:13
@carlossanlop@gewarren@radical
Port System.Runtime.InteropServices.Javascript docs to RC1 (#8390)
0effa38
* System.Runtime.InteropServices.Javascript RC1
* First batch of suggestions by gewarren
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Next batch of suggestions by gewarren.
* Apply suggestions from code review
* It's -> This API is
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@carlossanlop@gewarren
Assorted missing docs for RC1 (#8391)
66b6eca
* Assorted missing docs for RC1
* which -> that
* which -> that
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Diagnostics/TagList.xml
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31

This comment was marked as outdated.

Sign in to view
@opbld30

This comment was marked as outdated.

Sign in to view
gewarren
gewarren
commented
Sep 15, 2022
View reviewed changes
Comment threadxml/System.Windows.Forms/Control.xml
@gewarren
gewarren
marked this pull request as ready for review
September 15, 2022 20:41
@gewarren
gewarren
requested a review
from a team
as a code ownerSeptember 15, 2022 20:41
@gewarren
gewarren
commented
Sep 15, 2022

Copy link


Copy Markdown

CollaboratorAuthor
@carlossanlop Are we good to merge this? If so can you approve?
carlossanlop
carlossanlop
approved these changes
Sep 15, 2022
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good from the perspective of runtime APIs. If WPF/WinForms need to add extra documentation, they can do it directly in main after we merge this.
@gewarren
gewarren
enabled auto-merge (squash)
September 15, 2022 21:24
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Don't merge this yet, please. The WinForms PR is targeting this branch: #8393
@opbld32
opbld32
commented
Sep 15, 2022

Copy link


Copy Markdown

Docs Build status updates of commit 57d3f9f:
💡 Validation status: suggestions
FileStatusPreview URLDetails
xml/System.Net.Http.Headers/HeaderStringValues.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml💡SuggestionViewDetails
xml/System.Numerics/BigInteger.xml💡SuggestionViewDetails
xml/System.Numerics/Complex.xml💡SuggestionViewDetails
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml💡Suggestionn/a (file deleted)Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml✅Succeeded
xml/FrameworksIndex/net-7.0.xml✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml✅Succeeded
xml/Microsoft.Extensions.Configuration/ConfigurationBinder.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceCollectionContainerBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceProviderServiceExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting.Internal/HostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/Host.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptions.xml✅SucceededView
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml✅SucceededView
This comment lists only the first 25 files in the pull request.
xml/System.Net.Http.Headers/HeaderStringValues.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#String}#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#Generic#IEnumerable{System#String}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Numerics/BigInteger.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.BigInteger.op_UnsignedRightShift(System.Numerics.BigInteger,System.Int32).
xml/System.Numerics/Complex.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Decrement(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Increment(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_UnaryPlus(System.Numerics.Complex).
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@gewarren
gewarren
merged commit 55d7a64
into
mainSep 15, 2022
@gewarren
gewarren
deleted the

net7-rc1

branch
September 15, 2022 21:52
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Nevermind, automerge 😄
@amzwzw

This comment was marked as off-topic.

Sign in to view
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@RussKieRussKieAwaiting requested review from RussKie
@merriemcgawmerriemcgawAwaiting requested review from merriemcgaw
@HongGitHongGitAwaiting requested review from HongGit
@StephenMolloyStephenMolloyAwaiting requested review from StephenMolloyStephenMolloy is a code owner
@AaronRobinsonMSFTAaronRobinsonMSFTAwaiting requested review from AaronRobinsonMSFTAaronRobinsonMSFT is a code owner
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinskyjkoritzinsky is a code owner
@ajcvickersajcvickersAwaiting requested review from ajcvickers
@David-EngelDavid-EngelAwaiting requested review from David-Engel
@JRahnamaJRahnamaAwaiting requested review from JRahnama

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gewarrengewarren

Labels

area-MetaConcerns something that extends across runtime area boundaries, for example, IDisposable.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@gewarren@opbld33@carlossanlop@opbld34@opbld30@opbld31@opbld32@amzwzw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
CI Update - .NET 7 RC 1 by gewarren · Pull Request #8380 · dotnet/dotnet-api-docs · GitHub
Skip to content
CI Update - .NET 7 RC 1 - #8380
Merged
gewarren merged 6 commits into
mainfrom 
net7-rc1
Sep 15, 2022
Merged
CI Update - .NET 7 RC 1#8380
gewarren merged 6 commits into
mainfrom 
net7-rc1
Conversation
@gewarren
@gewarrengewarren
commented
Sep 12, 2022

Copy link


Copy Markdown

Collaborator
Build.Reason:Manual by Genevieve Warren

Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results

source_repo.branch:net7-rc1

source_repo.url:https://apidrop.visualstudio.com/_git/binaries
VSC-Service-Account
CI Update
fa1c1ff
 Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@ghostghost
assigned gewarrenSep 12, 2022
@ghostghost
added
the 
area-Meta
Concerns something that extends across runtime area boundaries, for example, IDisposable.
label
Sep 12, 2022
@opbld33

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
@gewarren
gewarren
commented
Sep 13, 2022

Copy link


Copy Markdown

CollaboratorAuthor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
You can ignore it. It's because that type was renamed to GeneratedRegexAttribute.
@carlossanlop@gewarren
RC1 - Update System.Formats.Tar docs (Backport#8375) (#8385)
db7194e
* Update System.Formats.Tar docs (#8375)
* Update tar docs
* Apply suggestions from code review
* Few more
* Update xml/System.Formats.Tar/GnuTarEntry.xml
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Formats.Tar/GnuTarEntry.xml
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry)
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Apply suggestions from code review
* Fix bullet lists
* Merge markdowns
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld34

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Tar changes included. Merge conflicts solved. I will generate RC2 intellisense from this, and will generate the undoc API report as well.
@opbld30

This comment was marked as outdated.

Sign in to view
@carlossanlopcarlossanlop
mentioned this pull request
Sep 14, 2022
 Merged

@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Incoming PRs: #8390 and #8391
carlossanlopand others
added 2 commits
September 15, 2022 09:13
@carlossanlop@gewarren@radical
Port System.Runtime.InteropServices.Javascript docs to RC1 (#8390)
0effa38
* System.Runtime.InteropServices.Javascript RC1
* First batch of suggestions by gewarren
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Next batch of suggestions by gewarren.
* Apply suggestions from code review
* It's -> This API is
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@carlossanlop@gewarren
Assorted missing docs for RC1 (#8391)
66b6eca
* Assorted missing docs for RC1
* which -> that
* which -> that
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Diagnostics/TagList.xml
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31

This comment was marked as outdated.

Sign in to view
@opbld30

This comment was marked as outdated.

Sign in to view
gewarren
gewarren
commented
Sep 15, 2022
View reviewed changes
Comment threadxml/System.Windows.Forms/Control.xml
@gewarren
gewarren
marked this pull request as ready for review
September 15, 2022 20:41
@gewarren
gewarren
requested a review
from a team
as a code ownerSeptember 15, 2022 20:41
@gewarren
gewarren
commented
Sep 15, 2022

Copy link


Copy Markdown

CollaboratorAuthor
@carlossanlop Are we good to merge this? If so can you approve?
carlossanlop
carlossanlop
approved these changes
Sep 15, 2022
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good from the perspective of runtime APIs. If WPF/WinForms need to add extra documentation, they can do it directly in main after we merge this.
@gewarren
gewarren
enabled auto-merge (squash)
September 15, 2022 21:24
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Don't merge this yet, please. The WinForms PR is targeting this branch: #8393
@opbld32
opbld32
commented
Sep 15, 2022

Copy link


Copy Markdown

Docs Build status updates of commit 57d3f9f:
💡 Validation status: suggestions
FileStatusPreview URLDetails
xml/System.Net.Http.Headers/HeaderStringValues.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml💡SuggestionViewDetails
xml/System.Numerics/BigInteger.xml💡SuggestionViewDetails
xml/System.Numerics/Complex.xml💡SuggestionViewDetails
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml💡Suggestionn/a (file deleted)Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml✅Succeeded
xml/FrameworksIndex/net-7.0.xml✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml✅Succeeded
xml/Microsoft.Extensions.Configuration/ConfigurationBinder.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceCollectionContainerBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceProviderServiceExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting.Internal/HostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/Host.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptions.xml✅SucceededView
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml✅SucceededView
This comment lists only the first 25 files in the pull request.
xml/System.Net.Http.Headers/HeaderStringValues.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#String}#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#Generic#IEnumerable{System#String}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Numerics/BigInteger.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.BigInteger.op_UnsignedRightShift(System.Numerics.BigInteger,System.Int32).
xml/System.Numerics/Complex.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Decrement(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Increment(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_UnaryPlus(System.Numerics.Complex).
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@gewarren
gewarren
merged commit 55d7a64
into
mainSep 15, 2022
@gewarren
gewarren
deleted the

net7-rc1

branch
September 15, 2022 21:52
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Nevermind, automerge 😄
@amzwzw

This comment was marked as off-topic.

Sign in to view
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@RussKieRussKieAwaiting requested review from RussKie
@merriemcgawmerriemcgawAwaiting requested review from merriemcgaw
@HongGitHongGitAwaiting requested review from HongGit
@StephenMolloyStephenMolloyAwaiting requested review from StephenMolloyStephenMolloy is a code owner
@AaronRobinsonMSFTAaronRobinsonMSFTAwaiting requested review from AaronRobinsonMSFTAaronRobinsonMSFT is a code owner
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinskyjkoritzinsky is a code owner
@ajcvickersajcvickersAwaiting requested review from ajcvickers
@David-EngelDavid-EngelAwaiting requested review from David-Engel
@JRahnamaJRahnamaAwaiting requested review from JRahnama

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gewarrengewarren

Labels

area-MetaConcerns something that extends across runtime area boundaries, for example, IDisposable.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@gewarren@opbld33@carlossanlop@opbld34@opbld30@opbld31@opbld32@amzwzw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
CI Update - .NET 7 RC 1 by gewarren · Pull Request #8380 · dotnet/dotnet-api-docs · GitHub
Skip to content
CI Update - .NET 7 RC 1 - #8380
Merged
gewarren merged 6 commits into
mainfrom 
net7-rc1
Sep 15, 2022
Merged
CI Update - .NET 7 RC 1#8380
gewarren merged 6 commits into
mainfrom 
net7-rc1
Conversation
@gewarren
@gewarrengewarren
commented
Sep 12, 2022

Copy link


Copy Markdown

Collaborator
Build.Reason:Manual by Genevieve Warren

Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results

source_repo.branch:net7-rc1

source_repo.url:https://apidrop.visualstudio.com/_git/binaries
VSC-Service-Account
CI Update
fa1c1ff
 Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@ghostghost
assigned gewarrenSep 12, 2022
@ghostghost
added
the 
area-Meta
Concerns something that extends across runtime area boundaries, for example, IDisposable.
label
Sep 12, 2022
@opbld33

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
@gewarren
gewarren
commented
Sep 13, 2022

Copy link


Copy Markdown

CollaboratorAuthor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
You can ignore it. It's because that type was renamed to GeneratedRegexAttribute.
@carlossanlop@gewarren
RC1 - Update System.Formats.Tar docs (Backport#8375) (#8385)
db7194e
* Update System.Formats.Tar docs (#8375)
* Update tar docs
* Apply suggestions from code review
* Few more
* Update xml/System.Formats.Tar/GnuTarEntry.xml
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Formats.Tar/GnuTarEntry.xml
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry)
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Apply suggestions from code review
* Fix bullet lists
* Merge markdowns
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld34

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Tar changes included. Merge conflicts solved. I will generate RC2 intellisense from this, and will generate the undoc API report as well.
@opbld30

This comment was marked as outdated.

Sign in to view
@carlossanlopcarlossanlop
mentioned this pull request
Sep 14, 2022
 Merged

@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Incoming PRs: #8390 and #8391
carlossanlopand others
added 2 commits
September 15, 2022 09:13
@carlossanlop@gewarren@radical
Port System.Runtime.InteropServices.Javascript docs to RC1 (#8390)
0effa38
* System.Runtime.InteropServices.Javascript RC1
* First batch of suggestions by gewarren
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Next batch of suggestions by gewarren.
* Apply suggestions from code review
* It's -> This API is
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@carlossanlop@gewarren
Assorted missing docs for RC1 (#8391)
66b6eca
* Assorted missing docs for RC1
* which -> that
* which -> that
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Diagnostics/TagList.xml
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31

This comment was marked as outdated.

Sign in to view
@opbld30

This comment was marked as outdated.

Sign in to view
gewarren
gewarren
commented
Sep 15, 2022
View reviewed changes
Comment threadxml/System.Windows.Forms/Control.xml
@gewarren
gewarren
marked this pull request as ready for review
September 15, 2022 20:41
@gewarren
gewarren
requested a review
from a team
as a code ownerSeptember 15, 2022 20:41
@gewarren
gewarren
commented
Sep 15, 2022

Copy link


Copy Markdown

CollaboratorAuthor
@carlossanlop Are we good to merge this? If so can you approve?
carlossanlop
carlossanlop
approved these changes
Sep 15, 2022
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good from the perspective of runtime APIs. If WPF/WinForms need to add extra documentation, they can do it directly in main after we merge this.
@gewarren
gewarren
enabled auto-merge (squash)
September 15, 2022 21:24
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Don't merge this yet, please. The WinForms PR is targeting this branch: #8393
@opbld32
opbld32
commented
Sep 15, 2022

Copy link


Copy Markdown

Docs Build status updates of commit 57d3f9f:
💡 Validation status: suggestions
FileStatusPreview URLDetails
xml/System.Net.Http.Headers/HeaderStringValues.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml💡SuggestionViewDetails
xml/System.Numerics/BigInteger.xml💡SuggestionViewDetails
xml/System.Numerics/Complex.xml💡SuggestionViewDetails
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml💡Suggestionn/a (file deleted)Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml✅Succeeded
xml/FrameworksIndex/net-7.0.xml✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml✅Succeeded
xml/Microsoft.Extensions.Configuration/ConfigurationBinder.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceCollectionContainerBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceProviderServiceExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting.Internal/HostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/Host.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptions.xml✅SucceededView
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml✅SucceededView
This comment lists only the first 25 files in the pull request.
xml/System.Net.Http.Headers/HeaderStringValues.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#String}#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#Generic#IEnumerable{System#String}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Numerics/BigInteger.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.BigInteger.op_UnsignedRightShift(System.Numerics.BigInteger,System.Int32).
xml/System.Numerics/Complex.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Decrement(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Increment(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_UnaryPlus(System.Numerics.Complex).
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@gewarren
gewarren
merged commit 55d7a64
into
mainSep 15, 2022
@gewarren
gewarren
deleted the

net7-rc1

branch
September 15, 2022 21:52
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Nevermind, automerge 😄
@amzwzw

This comment was marked as off-topic.

Sign in to view
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@RussKieRussKieAwaiting requested review from RussKie
@merriemcgawmerriemcgawAwaiting requested review from merriemcgaw
@HongGitHongGitAwaiting requested review from HongGit
@StephenMolloyStephenMolloyAwaiting requested review from StephenMolloyStephenMolloy is a code owner
@AaronRobinsonMSFTAaronRobinsonMSFTAwaiting requested review from AaronRobinsonMSFTAaronRobinsonMSFT is a code owner
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinskyjkoritzinsky is a code owner
@ajcvickersajcvickersAwaiting requested review from ajcvickers
@David-EngelDavid-EngelAwaiting requested review from David-Engel
@JRahnamaJRahnamaAwaiting requested review from JRahnama

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gewarrengewarren

Labels

area-MetaConcerns something that extends across runtime area boundaries, for example, IDisposable.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@gewarren@opbld33@carlossanlop@opbld34@opbld30@opbld31@opbld32@amzwzw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
CI Update - .NET 7 RC 1 by gewarren · Pull Request #8380 · dotnet/dotnet-api-docs · GitHub
Skip to content
CI Update - .NET 7 RC 1 - #8380
Merged
gewarren merged 6 commits into
mainfrom 
net7-rc1
Sep 15, 2022
Merged
CI Update - .NET 7 RC 1#8380
gewarren merged 6 commits into
mainfrom 
net7-rc1
Conversation
@gewarren
@gewarrengewarren
commented
Sep 12, 2022

Copy link


Copy Markdown

Collaborator
Build.Reason:Manual by Genevieve Warren

Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results

source_repo.branch:net7-rc1

source_repo.url:https://apidrop.visualstudio.com/_git/binaries
VSC-Service-Account
CI Update
fa1c1ff
 Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@ghostghost
assigned gewarrenSep 12, 2022
@ghostghost
added
the 
area-Meta
Concerns something that extends across runtime area boundaries, for example, IDisposable.
label
Sep 12, 2022
@opbld33

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
@gewarren
gewarren
commented
Sep 13, 2022

Copy link


Copy Markdown

CollaboratorAuthor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
You can ignore it. It's because that type was renamed to GeneratedRegexAttribute.
@carlossanlop@gewarren
RC1 - Update System.Formats.Tar docs (Backport#8375) (#8385)
db7194e
* Update System.Formats.Tar docs (#8375)
* Update tar docs
* Apply suggestions from code review
* Few more
* Update xml/System.Formats.Tar/GnuTarEntry.xml
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Formats.Tar/GnuTarEntry.xml
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry)
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Apply suggestions from code review
* Fix bullet lists
* Merge markdowns
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld34

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Tar changes included. Merge conflicts solved. I will generate RC2 intellisense from this, and will generate the undoc API report as well.
@opbld30

This comment was marked as outdated.

Sign in to view
@carlossanlopcarlossanlop
mentioned this pull request
Sep 14, 2022
 Merged

@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Incoming PRs: #8390 and #8391
carlossanlopand others
added 2 commits
September 15, 2022 09:13
@carlossanlop@gewarren@radical
Port System.Runtime.InteropServices.Javascript docs to RC1 (#8390)
0effa38
* System.Runtime.InteropServices.Javascript RC1
* First batch of suggestions by gewarren
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Next batch of suggestions by gewarren.
* Apply suggestions from code review
* It's -> This API is
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@carlossanlop@gewarren
Assorted missing docs for RC1 (#8391)
66b6eca
* Assorted missing docs for RC1
* which -> that
* which -> that
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Diagnostics/TagList.xml
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31

This comment was marked as outdated.

Sign in to view
@opbld30

This comment was marked as outdated.

Sign in to view
gewarren
gewarren
commented
Sep 15, 2022
View reviewed changes
Comment threadxml/System.Windows.Forms/Control.xml
@gewarren
gewarren
marked this pull request as ready for review
September 15, 2022 20:41
@gewarren
gewarren
requested a review
from a team
as a code ownerSeptember 15, 2022 20:41
@gewarren
gewarren
commented
Sep 15, 2022

Copy link


Copy Markdown

CollaboratorAuthor
@carlossanlop Are we good to merge this? If so can you approve?
carlossanlop
carlossanlop
approved these changes
Sep 15, 2022
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good from the perspective of runtime APIs. If WPF/WinForms need to add extra documentation, they can do it directly in main after we merge this.
@gewarren
gewarren
enabled auto-merge (squash)
September 15, 2022 21:24
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Don't merge this yet, please. The WinForms PR is targeting this branch: #8393
@opbld32
opbld32
commented
Sep 15, 2022

Copy link


Copy Markdown

Docs Build status updates of commit 57d3f9f:
💡 Validation status: suggestions
FileStatusPreview URLDetails
xml/System.Net.Http.Headers/HeaderStringValues.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml💡SuggestionViewDetails
xml/System.Numerics/BigInteger.xml💡SuggestionViewDetails
xml/System.Numerics/Complex.xml💡SuggestionViewDetails
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml💡Suggestionn/a (file deleted)Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml✅Succeeded
xml/FrameworksIndex/net-7.0.xml✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml✅Succeeded
xml/Microsoft.Extensions.Configuration/ConfigurationBinder.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceCollectionContainerBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceProviderServiceExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting.Internal/HostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/Host.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptions.xml✅SucceededView
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml✅SucceededView
This comment lists only the first 25 files in the pull request.
xml/System.Net.Http.Headers/HeaderStringValues.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#String}#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#Generic#IEnumerable{System#String}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Numerics/BigInteger.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.BigInteger.op_UnsignedRightShift(System.Numerics.BigInteger,System.Int32).
xml/System.Numerics/Complex.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Decrement(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Increment(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_UnaryPlus(System.Numerics.Complex).
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@gewarren
gewarren
merged commit 55d7a64
into
mainSep 15, 2022
@gewarren
gewarren
deleted the

net7-rc1

branch
September 15, 2022 21:52
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Nevermind, automerge 😄
@amzwzw

This comment was marked as off-topic.

Sign in to view
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@RussKieRussKieAwaiting requested review from RussKie
@merriemcgawmerriemcgawAwaiting requested review from merriemcgaw
@HongGitHongGitAwaiting requested review from HongGit
@StephenMolloyStephenMolloyAwaiting requested review from StephenMolloyStephenMolloy is a code owner
@AaronRobinsonMSFTAaronRobinsonMSFTAwaiting requested review from AaronRobinsonMSFTAaronRobinsonMSFT is a code owner
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinskyjkoritzinsky is a code owner
@ajcvickersajcvickersAwaiting requested review from ajcvickers
@David-EngelDavid-EngelAwaiting requested review from David-Engel
@JRahnamaJRahnamaAwaiting requested review from JRahnama

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gewarrengewarren

Labels

area-MetaConcerns something that extends across runtime area boundaries, for example, IDisposable.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@gewarren@opbld33@carlossanlop@opbld34@opbld30@opbld31@opbld32@amzwzw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
CI Update - .NET 7 RC 1 by gewarren · Pull Request #8380 · dotnet/dotnet-api-docs · GitHub
Skip to content
CI Update - .NET 7 RC 1 - #8380
Merged
gewarren merged 6 commits into
mainfrom 
net7-rc1
Sep 15, 2022
Merged
CI Update - .NET 7 RC 1#8380
gewarren merged 6 commits into
mainfrom 
net7-rc1
Conversation
@gewarren
@gewarrengewarren
commented
Sep 12, 2022

Copy link


Copy Markdown

Collaborator
Build.Reason:Manual by Genevieve Warren

Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results

source_repo.branch:net7-rc1

source_repo.url:https://apidrop.visualstudio.com/_git/binaries
VSC-Service-Account
CI Update
fa1c1ff
 Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@ghostghost
assigned gewarrenSep 12, 2022
@ghostghost
added
the 
area-Meta
Concerns something that extends across runtime area boundaries, for example, IDisposable.
label
Sep 12, 2022
@opbld33

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
@gewarren
gewarren
commented
Sep 13, 2022

Copy link


Copy Markdown

CollaboratorAuthor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
You can ignore it. It's because that type was renamed to GeneratedRegexAttribute.
@carlossanlop@gewarren
RC1 - Update System.Formats.Tar docs (Backport#8375) (#8385)
db7194e
* Update System.Formats.Tar docs (#8375)
* Update tar docs
* Apply suggestions from code review
* Few more
* Update xml/System.Formats.Tar/GnuTarEntry.xml
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Formats.Tar/GnuTarEntry.xml
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry)
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Apply suggestions from code review
* Fix bullet lists
* Merge markdowns
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld34

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Tar changes included. Merge conflicts solved. I will generate RC2 intellisense from this, and will generate the undoc API report as well.
@opbld30

This comment was marked as outdated.

Sign in to view
@carlossanlopcarlossanlop
mentioned this pull request
Sep 14, 2022
 Merged

@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Incoming PRs: #8390 and #8391
carlossanlopand others
added 2 commits
September 15, 2022 09:13
@carlossanlop@gewarren@radical
Port System.Runtime.InteropServices.Javascript docs to RC1 (#8390)
0effa38
* System.Runtime.InteropServices.Javascript RC1
* First batch of suggestions by gewarren
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Next batch of suggestions by gewarren.
* Apply suggestions from code review
* It's -> This API is
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@carlossanlop@gewarren
Assorted missing docs for RC1 (#8391)
66b6eca
* Assorted missing docs for RC1
* which -> that
* which -> that
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Diagnostics/TagList.xml
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31

This comment was marked as outdated.

Sign in to view
@opbld30

This comment was marked as outdated.

Sign in to view
gewarren
gewarren
commented
Sep 15, 2022
View reviewed changes
Comment threadxml/System.Windows.Forms/Control.xml
@gewarren
gewarren
marked this pull request as ready for review
September 15, 2022 20:41
@gewarren
gewarren
requested a review
from a team
as a code ownerSeptember 15, 2022 20:41
@gewarren
gewarren
commented
Sep 15, 2022

Copy link


Copy Markdown

CollaboratorAuthor
@carlossanlop Are we good to merge this? If so can you approve?
carlossanlop
carlossanlop
approved these changes
Sep 15, 2022
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good from the perspective of runtime APIs. If WPF/WinForms need to add extra documentation, they can do it directly in main after we merge this.
@gewarren
gewarren
enabled auto-merge (squash)
September 15, 2022 21:24
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Don't merge this yet, please. The WinForms PR is targeting this branch: #8393
@opbld32
opbld32
commented
Sep 15, 2022

Copy link


Copy Markdown

Docs Build status updates of commit 57d3f9f:
💡 Validation status: suggestions
FileStatusPreview URLDetails
xml/System.Net.Http.Headers/HeaderStringValues.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml💡SuggestionViewDetails
xml/System.Numerics/BigInteger.xml💡SuggestionViewDetails
xml/System.Numerics/Complex.xml💡SuggestionViewDetails
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml💡Suggestionn/a (file deleted)Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml✅Succeeded
xml/FrameworksIndex/net-7.0.xml✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml✅Succeeded
xml/Microsoft.Extensions.Configuration/ConfigurationBinder.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceCollectionContainerBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceProviderServiceExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting.Internal/HostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/Host.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptions.xml✅SucceededView
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml✅SucceededView
This comment lists only the first 25 files in the pull request.
xml/System.Net.Http.Headers/HeaderStringValues.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#String}#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#Generic#IEnumerable{System#String}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Numerics/BigInteger.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.BigInteger.op_UnsignedRightShift(System.Numerics.BigInteger,System.Int32).
xml/System.Numerics/Complex.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Decrement(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Increment(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_UnaryPlus(System.Numerics.Complex).
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@gewarren
gewarren
merged commit 55d7a64
into
mainSep 15, 2022
@gewarren
gewarren
deleted the

net7-rc1

branch
September 15, 2022 21:52
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Nevermind, automerge 😄
@amzwzw

This comment was marked as off-topic.

Sign in to view
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@RussKieRussKieAwaiting requested review from RussKie
@merriemcgawmerriemcgawAwaiting requested review from merriemcgaw
@HongGitHongGitAwaiting requested review from HongGit
@StephenMolloyStephenMolloyAwaiting requested review from StephenMolloyStephenMolloy is a code owner
@AaronRobinsonMSFTAaronRobinsonMSFTAwaiting requested review from AaronRobinsonMSFTAaronRobinsonMSFT is a code owner
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinskyjkoritzinsky is a code owner
@ajcvickersajcvickersAwaiting requested review from ajcvickers
@David-EngelDavid-EngelAwaiting requested review from David-Engel
@JRahnamaJRahnamaAwaiting requested review from JRahnama

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gewarrengewarren

Labels

area-MetaConcerns something that extends across runtime area boundaries, for example, IDisposable.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@gewarren@opbld33@carlossanlop@opbld34@opbld30@opbld31@opbld32@amzwzw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
CI Update - .NET 7 RC 1 by gewarren · Pull Request #8380 · dotnet/dotnet-api-docs · GitHub
Skip to content
CI Update - .NET 7 RC 1 - #8380
Merged
gewarren merged 6 commits into
mainfrom 
net7-rc1
Sep 15, 2022
Merged
CI Update - .NET 7 RC 1#8380
gewarren merged 6 commits into
mainfrom 
net7-rc1
Conversation
@gewarren
@gewarrengewarren
commented
Sep 12, 2022

Copy link


Copy Markdown

Collaborator
Build.Reason:Manual by Genevieve Warren

Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results

source_repo.branch:net7-rc1

source_repo.url:https://apidrop.visualstudio.com/_git/binaries
VSC-Service-Account
CI Update
fa1c1ff
 Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@ghostghost
assigned gewarrenSep 12, 2022
@ghostghost
added
the 
area-Meta
Concerns something that extends across runtime area boundaries, for example, IDisposable.
label
Sep 12, 2022
@opbld33

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
@gewarren
gewarren
commented
Sep 13, 2022

Copy link


Copy Markdown

CollaboratorAuthor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
You can ignore it. It's because that type was renamed to GeneratedRegexAttribute.
@carlossanlop@gewarren
RC1 - Update System.Formats.Tar docs (Backport#8375) (#8385)
db7194e
* Update System.Formats.Tar docs (#8375)
* Update tar docs
* Apply suggestions from code review
* Few more
* Update xml/System.Formats.Tar/GnuTarEntry.xml
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Formats.Tar/GnuTarEntry.xml
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry)
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Apply suggestions from code review
* Fix bullet lists
* Merge markdowns
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld34

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Tar changes included. Merge conflicts solved. I will generate RC2 intellisense from this, and will generate the undoc API report as well.
@opbld30

This comment was marked as outdated.

Sign in to view
@carlossanlopcarlossanlop
mentioned this pull request
Sep 14, 2022
 Merged

@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Incoming PRs: #8390 and #8391
carlossanlopand others
added 2 commits
September 15, 2022 09:13
@carlossanlop@gewarren@radical
Port System.Runtime.InteropServices.Javascript docs to RC1 (#8390)
0effa38
* System.Runtime.InteropServices.Javascript RC1
* First batch of suggestions by gewarren
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Next batch of suggestions by gewarren.
* Apply suggestions from code review
* It's -> This API is
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@carlossanlop@gewarren
Assorted missing docs for RC1 (#8391)
66b6eca
* Assorted missing docs for RC1
* which -> that
* which -> that
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Diagnostics/TagList.xml
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31

This comment was marked as outdated.

Sign in to view
@opbld30

This comment was marked as outdated.

Sign in to view
gewarren
gewarren
commented
Sep 15, 2022
View reviewed changes
Comment threadxml/System.Windows.Forms/Control.xml
@gewarren
gewarren
marked this pull request as ready for review
September 15, 2022 20:41
@gewarren
gewarren
requested a review
from a team
as a code ownerSeptember 15, 2022 20:41
@gewarren
gewarren
commented
Sep 15, 2022

Copy link


Copy Markdown

CollaboratorAuthor
@carlossanlop Are we good to merge this? If so can you approve?
carlossanlop
carlossanlop
approved these changes
Sep 15, 2022
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good from the perspective of runtime APIs. If WPF/WinForms need to add extra documentation, they can do it directly in main after we merge this.
@gewarren
gewarren
enabled auto-merge (squash)
September 15, 2022 21:24
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Don't merge this yet, please. The WinForms PR is targeting this branch: #8393
@opbld32
opbld32
commented
Sep 15, 2022

Copy link


Copy Markdown

Docs Build status updates of commit 57d3f9f:
💡 Validation status: suggestions
FileStatusPreview URLDetails
xml/System.Net.Http.Headers/HeaderStringValues.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml💡SuggestionViewDetails
xml/System.Numerics/BigInteger.xml💡SuggestionViewDetails
xml/System.Numerics/Complex.xml💡SuggestionViewDetails
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml💡Suggestionn/a (file deleted)Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml✅Succeeded
xml/FrameworksIndex/net-7.0.xml✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml✅Succeeded
xml/Microsoft.Extensions.Configuration/ConfigurationBinder.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceCollectionContainerBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceProviderServiceExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting.Internal/HostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/Host.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptions.xml✅SucceededView
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml✅SucceededView
This comment lists only the first 25 files in the pull request.
xml/System.Net.Http.Headers/HeaderStringValues.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#String}#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#Generic#IEnumerable{System#String}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Numerics/BigInteger.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.BigInteger.op_UnsignedRightShift(System.Numerics.BigInteger,System.Int32).
xml/System.Numerics/Complex.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Decrement(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Increment(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_UnaryPlus(System.Numerics.Complex).
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@gewarren
gewarren
merged commit 55d7a64
into
mainSep 15, 2022
@gewarren
gewarren
deleted the

net7-rc1

branch
September 15, 2022 21:52
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Nevermind, automerge 😄
@amzwzw

This comment was marked as off-topic.

Sign in to view
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@RussKieRussKieAwaiting requested review from RussKie
@merriemcgawmerriemcgawAwaiting requested review from merriemcgaw
@HongGitHongGitAwaiting requested review from HongGit
@StephenMolloyStephenMolloyAwaiting requested review from StephenMolloyStephenMolloy is a code owner
@AaronRobinsonMSFTAaronRobinsonMSFTAwaiting requested review from AaronRobinsonMSFTAaronRobinsonMSFT is a code owner
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinskyjkoritzinsky is a code owner
@ajcvickersajcvickersAwaiting requested review from ajcvickers
@David-EngelDavid-EngelAwaiting requested review from David-Engel
@JRahnamaJRahnamaAwaiting requested review from JRahnama

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gewarrengewarren

Labels

area-MetaConcerns something that extends across runtime area boundaries, for example, IDisposable.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@gewarren@opbld33@carlossanlop@opbld34@opbld30@opbld31@opbld32@amzwzw

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
CI Update - .NET 7 RC 1 by gewarren · Pull Request #8380 · dotnet/dotnet-api-docs · GitHub
Skip to content
CI Update - .NET 7 RC 1 - #8380
Merged
gewarren merged 6 commits into
mainfrom 
net7-rc1
Sep 15, 2022
Merged
CI Update - .NET 7 RC 1#8380
gewarren merged 6 commits into
mainfrom 
net7-rc1
Conversation
@gewarren
@gewarrengewarren
commented
Sep 12, 2022

Copy link


Copy Markdown

Collaborator
Build.Reason:Manual by Genevieve Warren

Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results

source_repo.branch:net7-rc1

source_repo.url:https://apidrop.visualstudio.com/_git/binaries
VSC-Service-Account
CI Update
fa1c1ff
 Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=318563&view=results
source_repo.branch:net7-rc1
source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@ghostghost
assigned gewarrenSep 12, 2022
@ghostghost
added
the 
area-Meta
Concerns something that extends across runtime area boundaries, for example, IDisposable.
label
Sep 12, 2022
@opbld33

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 13, 2022

Copy link


Copy Markdown

Contributor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
@gewarren
gewarren
commented
Sep 13, 2022

Copy link


Copy Markdown

CollaboratorAuthor
File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
Where does this error come from? Is this deleted file being referenced somewhere?
You can ignore it. It's because that type was renamed to GeneratedRegexAttribute.
@carlossanlop@gewarren
RC1 - Update System.Formats.Tar docs (Backport#8375) (#8385)
db7194e
* Update System.Formats.Tar docs (#8375)
* Update tar docs
* Apply suggestions from code review
* Few more
* Update xml/System.Formats.Tar/GnuTarEntry.xml
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Formats.Tar/GnuTarEntry.xml
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Revert remarks as markdown in TarWriter.WriteEntry/WriteEntryAsync(TarEntry)
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Apply suggestions from code review
* Fix bullet lists
* Merge markdowns
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld34

This comment was marked as outdated.

Sign in to view
@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Tar changes included. Merge conflicts solved. I will generate RC2 intellisense from this, and will generate the undoc API report as well.
@opbld30

This comment was marked as outdated.

Sign in to view
@carlossanlopcarlossanlop
mentioned this pull request
Sep 14, 2022
 Merged

@carlossanlop
carlossanlop
commented
Sep 14, 2022

Copy link


Copy Markdown

Contributor
Incoming PRs: #8390 and #8391
carlossanlopand others
added 2 commits
September 15, 2022 09:13
@carlossanlop@gewarren@radical
Port System.Runtime.InteropServices.Javascript docs to RC1 (#8390)
0effa38
* System.Runtime.InteropServices.Javascript RC1
* First batch of suggestions by gewarren
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Next batch of suggestions by gewarren.
* Apply suggestions from code review
* It's -> This API is
* Apply suggestions from code review
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Runtime.InteropServices.JavaScript/JSExportAttribute.xml
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
@carlossanlop@gewarren
Assorted missing docs for RC1 (#8391)
66b6eca
* Assorted missing docs for RC1
* which -> that
* which -> that
* Apply suggestions from code review
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update xml/System.Diagnostics/TagList.xml
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld31

This comment was marked as outdated.

Sign in to view
@opbld30

This comment was marked as outdated.

Sign in to view
gewarren
gewarren
commented
Sep 15, 2022
View reviewed changes
Comment threadxml/System.Windows.Forms/Control.xml
@gewarren
gewarren
marked this pull request as ready for review
September 15, 2022 20:41
@gewarren
gewarren
requested a review
from a team
as a code ownerSeptember 15, 2022 20:41
@gewarren
gewarren
commented
Sep 15, 2022

Copy link


Copy Markdown

CollaboratorAuthor
@carlossanlop Are we good to merge this? If so can you approve?
carlossanlop
carlossanlop
approved these changes
Sep 15, 2022
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good from the perspective of runtime APIs. If WPF/WinForms need to add extra documentation, they can do it directly in main after we merge this.
@gewarren
gewarren
enabled auto-merge (squash)
September 15, 2022 21:24
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Don't merge this yet, please. The WinForms PR is targeting this branch: #8393
@opbld32
opbld32
commented
Sep 15, 2022

Copy link


Copy Markdown

Docs Build status updates of commit 57d3f9f:
💡 Validation status: suggestions
FileStatusPreview URLDetails
xml/System.Net.Http.Headers/HeaderStringValues.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml💡SuggestionViewDetails
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml💡SuggestionViewDetails
xml/System.Numerics/BigInteger.xml💡SuggestionViewDetails
xml/System.Numerics/Complex.xml💡SuggestionViewDetails
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml💡Suggestionn/a (file deleted)Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml✅Succeeded
xml/FrameworksIndex/net-7.0.xml✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml✅Succeeded
xml/Microsoft.Extensions.Configuration/ConfigurationBinder.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/DefaultServiceProviderFactory.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceCollectionContainerBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.DependencyInjection/ServiceProviderServiceExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting.Internal/HostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/Host.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostApplicationBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostBuilder.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/HostingHostBuilderExtensions.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Hosting/IHostingEnvironment.xml✅SucceededView
xml/Microsoft.Extensions.Logging.Configuration/LoggerProviderOptions.xml✅SucceededView
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml✅SucceededView
This comment lists only the first 25 files in the pull request.
xml/System.Net.Http.Headers/HeaderStringValues.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#String}#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#Generic#IEnumerable{System#String}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HeaderStringValues.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HeaderStringValues+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HeaderStringValues.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IEnumerable{System#Collections#Generic#KeyValuePair{System#String@System#Net#Http#Headers#HeaderStringValues}}#GetEnumerator.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#ContainsKey(System.String).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Keys.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@) for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#TryGetValue(System.String,System.Net.Http.Headers.HeaderStringValues@).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#Generic#IReadOnlyDictionary{System#String@System#Net#Http#Headers#HeaderStringValues}#Values.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerable#GetEnumerator for uid: System.Net.Http.Headers.HttpHeadersNonValidated.System#Collections#IEnumerable#GetEnumerator.
xml/System.Net.Http.Headers/HttpHeadersNonValidated+Enumerator.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Current for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Current.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:System#Collections#IEnumerator#Reset for uid: System.Net.Http.Headers.HttpHeadersNonValidated.Enumerator.System#Collections#IEnumerator#Reset.
xml/System.Numerics/BigInteger.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.BigInteger.op_UnsignedRightShift(System.Numerics.BigInteger,System.Int32).
xml/System.Numerics/Complex.xml
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Decrement(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Increment(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType]Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_UnaryPlus(System.Numerics.Complex).
xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
  • [Suggestion: file-not-redirected - See documentation]File xml/System.Text.RegularExpressions/RegexGeneratorAttribute.xml was deleted without redirection. To avoid broken links, add a redirection.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
@gewarren
gewarren
merged commit 55d7a64
into
mainSep 15, 2022
@gewarren
gewarren
deleted the

net7-rc1

branch
September 15, 2022 21:52
@carlossanlop
carlossanlop
commented
Sep 15, 2022

Copy link


Copy Markdown

Contributor
Nevermind, automerge 😄
@amzwzw

This comment was marked as off-topic.

Sign in to view
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@RussKieRussKieAwaiting requested review from RussKie
@merriemcgawmerriemcgawAwaiting requested review from merriemcgaw
@HongGitHongGitAwaiting requested review from HongGit
@StephenMolloyStephenMolloyAwaiting requested review from StephenMolloyStephenMolloy is a code owner
@AaronRobinsonMSFTAaronRobinsonMSFTAwaiting requested review from AaronRobinsonMSFTAaronRobinsonMSFT is a code owner
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinskyjkoritzinsky is a code owner
@ajcvickersajcvickersAwaiting requested review from ajcvickers
@David-EngelDavid-EngelAwaiting requested review from David-Engel
@JRahnamaJRahnamaAwaiting requested review from JRahnama

1 more reviewer

@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gewarrengewarren

Labels

area-MetaConcerns something that extends across runtime area boundaries, for example, IDisposable.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@gewarren@opbld33@carlossanlop@opbld34@opbld30@opbld31@opbld32@amzwzw