Skip to content

Port docs from WinForms - #8394

Merged
carlossanlop merged 4 commits into
dotnet:mainfrom
carlossanlop:PortDocsWinForms
Sep 16, 2022
Merged

Port docs from WinForms#8394
carlossanlop merged 4 commits into
dotnet:mainfrom
carlossanlop:PortDocsWinForms

Conversation

@carlossanlop

Copy link
Copy Markdown
Contributor

@RussKie@JeremyKuhne This is all I could port from the winforms release/7.0-rc1 branch.

@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Comment threadxml/System.Windows.Forms/BindableComponent.xml Outdated
Comment threadxml/System.Windows.Forms/ButtonBase.xml Outdated
Comment threadxml/System.Windows.Forms/ButtonBase.xml Outdated
Comment threadxml/System.Windows.Forms/ButtonBase.xml Outdated
Comment threadxml/System.Windows.Forms/ContainerControl.xml Outdated
Comment threadxml/System.Windows.Forms/ToolStripItem.xml Outdated
Comment threadxml/System.Windows.Forms/ToolStripItem.xml Outdated
Comment threadxml/Microsoft.VisualBasic.ApplicationServices/ConsoleApplicationBase.xml Outdated
Comment threadxml/System.Windows.Forms/BindableComponent.xml Outdated
@opbld31

This comment was marked as outdated.

@opbld34

This comment was marked as outdated.

@RussKie

Copy link
Copy Markdown
Contributor

Tagging @KlausLoeffelmann since he added the new API to Windows Forms 😉

@RussKie

Copy link
Copy Markdown
Contributor

Tagging @dreddy-work as he added new API as well

@KlausLoeffelmann

Copy link
Copy Markdown
Member

Looks good to me!

@dreddy-workdreddy-work left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Winforms.

@RussKie

Copy link
Copy Markdown
Contributor

Thank you @carlossanlop and @gewarren for doing this

@carlossanlop

Copy link
Copy Markdown
ContributorAuthor

@cston@dreddy-work@RussKie I'll manually apply the requested changes. But if you have additional feedback, please help @gewarren and I by providing GitHub suggestions with the preferred texts. It's much faster to bulk apply them in a single commit.

Comment threadxml/System.Windows.Forms/Control.xml Outdated
Comment threadxml/System.Windows.Forms/FileDialog.xml Outdated
Comment threadxml/System.Windows.Forms/FolderBrowserDialog.xml Outdated
Comment threadxml/System.Windows.Forms/GiveFeedbackEventArgs.xml Outdated
carlossanlopand others added 2 commits September 16, 2022 10:28
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@opbld32

This comment was marked as outdated.

@opbld32

This comment was marked as outdated.

@carlossanlop

Copy link
Copy Markdown
ContributorAuthor

System.Windows.Forms.Application.ThreadContext.PreTranslateMessage(Interop.User32.MSG@) doesn't exist, or is internal. Need to remove it.

@opbld32

Copy link
Copy Markdown

Docs Build status updates of commit 5866fd7:

💡 Validation status: suggestions

FileStatusPreview URLDetails
xml/System.ComponentModel.Design/ObjectSelectorEditor.xml💡SuggestionViewDetails
xml/System.Windows.Forms/TaskDialogButtonCollection.xml💡SuggestionViewDetails
xml/System.Windows.Forms/TaskDialogRadioButtonCollection.xml💡SuggestionViewDetails
xml/System.ComponentModel.Design/BinaryEditor.xml✅SucceededView
xml/System.ComponentModel.Design/CollectionEditor.xml✅SucceededView
xml/System.ComponentModel.Design/DateTimeEditor.xml✅SucceededView
xml/System.ComponentModel.Design/MultilineStringEditor.xml✅SucceededView
xml/System.Drawing.Design/ColorEditor.xml✅SucceededView
xml/System.Drawing.Design/ContentAlignmentEditor.xml✅SucceededView
xml/System.Drawing.Design/CursorEditor.xml✅SucceededView
xml/System.Drawing.Design/FontEditor.xml✅SucceededView
xml/System.Drawing.Design/FontNameEditor.xml✅SucceededView
xml/System.Drawing.Design/IconEditor.xml✅SucceededView
xml/System.Drawing.Design/ImageEditor.xml✅SucceededView
xml/System.Windows.Forms.Design/AnchorEditor.xml✅SucceededView
xml/System.Windows.Forms.Design/BorderSidesEditor.xml✅SucceededView
xml/System.Windows.Forms.Design/DockEditor.xml✅SucceededView
xml/System.Windows.Forms.Design/EventsTab.xml✅SucceededView
xml/System.Windows.Forms.Design/FileNameEditor.xml✅SucceededView
xml/System.Windows.Forms.Design/FolderNameEditor.xml✅SucceededView
xml/System.Windows.Forms.Design/ShortcutKeysEditor.xml✅SucceededView
xml/System.Windows.Forms/BindableComponent.xml✅SucceededView
xml/System.Windows.Forms/ButtonBase.xml✅SucceededView
xml/System.Windows.Forms/ContainerControl.xml✅SucceededView
xml/System.Windows.Forms/Control.xml✅SucceededView

This comment lists only the first 25 files in the pull request.

xml/System.ComponentModel.Design/ObjectSelectorEditor.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:SetValue(System.Object) for uid: System.ComponentModel.Design.ObjectSelectorEditor.SetValue(System.Object).

xml/System.Windows.Forms/TaskDialogButtonCollection.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:InsertItem(System.Int32,System.Windows.Forms.TaskDialogButton) for uid: System.Windows.Forms.TaskDialogButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs]Inheridoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:SetItem(System.Int32,System.Windows.Forms.TaskDialogButton) for uid: System.Windows.Forms.TaskDialogButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs]Inheridoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogButton).

xml/System.Windows.Forms/TaskDialogRadioButtonCollection.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:InsertItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton) for uid: System.Windows.Forms.TaskDialogRadioButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs]Inheridoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogRadioButtonCollection.InsertItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent]Found no member can be inherited by key:SetItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton) for uid: System.Windows.Forms.TaskDialogRadioButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs]Inheridoc tag exists but no inheritdoc found for uid:System.Windows.Forms.TaskDialogRadioButtonCollection.SetItem(System.Int32,System.Windows.Forms.TaskDialogRadioButton).

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop

Copy link
Copy Markdown
ContributorAuthor

Warning removed. Merging now. :shipit:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@carlossanlop@opbld31@opbld34@RussKie@KlausLoeffelmann@opbld32@cston@gewarren@dreddy-work