Skip to content

Make ActivityBaggageLogScopeWrapper implements IEnumerable<KeyValuePair<string, object?>> - #5589

Merged
dariusclay merged 3 commits into
dotnet:mainfrom
NatMarchand:main
Nov 18, 2024
Merged

Make ActivityBaggageLogScopeWrapper implements IEnumerable<KeyValuePair<string, object?>>#5589
dariusclay merged 3 commits into
dotnet:mainfrom
NatMarchand:main

Conversation

@NatMarchand

@NatMarchandNatMarchand commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

In order to work with OpenTelemetry, ActivityBaggageLogScopeWrapper must implements IEnumerable<KeyValuePair<string, object?>>
Closes: open-telemetry/opentelemetry-dotnet#5943

Microsoft Reviewers: Open in CodeFlow

@NatMarchand

NatMarchand commented Nov 1, 2024

Copy link
Copy Markdown
ContributorAuthor

Just found out that the file is a copy of https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.Extensions.Logging/src/LoggerFactoryScopeProvider.cs
However, the source in dotnet/runtime was meanwhile modified to be an IEnumerable<KeyValuePair<string, object?>>
Replicating changes

@RussKie

Copy link
Copy Markdown
Contributor

@dotnet/dotnet-extensions-telemetry please review

@dariusclaydariusclay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dariusclay
dariusclay merged commit 2977765 into dotnet:mainNov 18, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 19, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Lack of baggage in Logs

3 participants

@NatMarchand@RussKie@dariusclay