Uh oh!
There was an error while loading. Please reload this page.
[release/9.0] Merging changes from main into release branch for November release - #5602
Merged
Merged
Conversation
* Add NativeAOT testapp project for M.E.AI * Address PR feedback
…ojects (dotnet#5576) To ensure a recent version is used.
…Options.Dimensions (dotnet#5575) Merge conflict blip.
…otnet#5582) * Lower AIJsonUtilities to STJv8 and move to Abstractions library. * Add README.md
…t#5590) * Plug JsonSchemaExporter test data to the AIJsonUtilities tests * Update src/LegacySupport/DiagnosticAttributes/README.md * Update src/Libraries/Microsoft.Extensions.AI.Abstractions/Utilities/AIJsonUtilities.Schema.cs * Address feedback.
* Improve JsonSchemaExporter trimmer safety. * Remove var * Address feedback. * Remove DynamicallyAccessedMemberTypes.All * Extract reflection helpers into separate file and remove a number of warning suppressions. * Re-enable failing tests that were patched in .NET 9
- Add a strongly-typed Enumerator - Add a TryAdd method - Add a DebuggerDisplay for Count - Add a DebuggerTypeProxy for the collection of properties
* Add UseEmbeddingGenerationOptions Counterpart to UseChatOptions * Document/test null options returned from callback
* - handle serialization failures - enforce payload quota - enforce key validity - add proper logging (infrastructure failure: needs attn) # Conflicts: # src/Libraries/Microsoft.Extensions.Caching.Hybrid/Microsoft.Extensions.Caching.Hybrid.csproj * - add "callback" to .dic - log deserialization failures - expose serialization failures - tests for serialization logging scenarios * support and tests for stability despite unreliable L2 * nit * Compile for NS2.0 * include enabled check in our log output * add event-source tracing and counters * explicitly specify event-source guid * satisfy the stylebot overloads * nix SDT * fix failing CI test * limit to net462 * PR feedback (all except event tests) * naming * add event source tests * fix redundant comment * add clarification * more clarifications * dance for our robot overlords * drop Microsoft.Extensions.Telemetry.Abstractions package-ref * fix glitchy L2 test * better tracking for invalid event-source state * reserve non-printable characters from keys, to prevent L2 abuse * improve test output for ETW * tyop * ETW tests: allow longer if needed * whitespace * more ETW fixins --------- Co-authored-by: Jose Perez Rodriguez <joperezr@microsoft.com>
joperezr
commented
Nov 5, 2024
MemberAuthor
This should be merged and not squashed. |
stephentoub
commented
Nov 6, 2024
Member
I skimmed through and it looks good to me. If #5603 looks good to you, could we also cherry-pick that one? Thanks! |
stephentoub
approved these changes
Nov 6, 2024
mgravell
approved these changes
Nov 6, 2024
mgravell
left a comment
Contributor
There was a problem hiding this comment.
approved re Caching.Hybrid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @stephentoub@mgravell
This is cherry-picking changes made on main branch after the snap for M.E.AI and HybridCache.
PRs that are getting merged are:
AIJsonUtilitiesto STJv8 and move to Abstractions library. (LowerAIJsonUtilitiesto STJv8 and move to Abstractions library. #5582)Microsoft Reviewers: Open in CodeFlow