Skip to content

HttpRouteParser: Handle catch-all parameters - #5604

Merged
dariusclay merged 3 commits into
mainfrom
dletterman/route-parser-catchall
Nov 7, 2024
Merged

HttpRouteParser: Handle catch-all parameters#5604
dariusclay merged 3 commits into
mainfrom
dletterman/route-parser-catchall

Conversation

@dariusclay

@dariusclaydariusclay commented Nov 6, 2024•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Closes#5466#5017

Microsoft Reviewers: Open in CodeFlow

@dariusclay
dariusclay requested a review from a team as a code ownerNovember 6, 2024 11:44
@dariusclaydariusclay linked an issue Nov 6, 2024 that may be closed by this pull request
Support catch-all parameters in HTTP logging #5017
Closed
eduherminio
eduherminio reviewed Nov 6, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Http/HttpRouteParser.cs
@dariusclay
dariusclay merged commit 1af24f5 into mainNov 7, 2024
@dariusclay
dariusclay deleted the dletterman/route-parser-catchall branch November 7, 2024 15:05
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 8, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mariamgergesmariamgergesmariamgerges approved these changes
@evgenyfedorov2evgenyfedorov2evgenyfedorov2 approved these changes
+1 more reviewer
@eduherminioeduherminioeduherminio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dariusclaydariusclay

Labels

area-telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HttpRouteParser incorrectly handles catch-all routes Support catch-all parameters in HTTP logging

4 participants

@dariusclay@eduherminio@mariamgerges@evgenyfedorov2