Skip to content

Add logging buffering - #5635

Merged
evgenyfedorov2 merged 55 commits into
dotnet:mainfrom
evgenyfedorov2:evgenyfedorov2/log_buffering
Apr 9, 2025
Merged

Add logging buffering#5635
evgenyfedorov2 merged 55 commits into
dotnet:mainfrom
evgenyfedorov2:evgenyfedorov2/log_buffering

Conversation

@evgenyfedorov2

@evgenyfedorov2evgenyfedorov2 commented Nov 13, 2024•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Related to the #5123 proposal, this PR is focused on the logging buffering only. See also the sampling part #5574.

Microsoft Reviewers: Open in CodeFlow

noahfalk
noahfalk reviewed Nov 23, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.cs Outdated
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.cs Outdated
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.cs Outdated
Comment thread...Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/Buffering/HttpRequestBufferProvider.cs Outdated
Comment threadsrc/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware/Buffering/HttpRequestBufferOptions.cs Outdated
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/GlobalBufferOptions.cs Outdated
Comment thread...Core.Diagnostics.Middleware.Tests/Buffering/HttpRequestBufferLoggerBuilderExtensionsTests.cs Outdated
Comment threadtest/Libraries/Microsoft.AspNetCore.Diagnostics.Middleware.Tests/Logging/AcceptanceTests.cs
Comment thread...s/Microsoft.Extensions.Telemetry.Tests/Buffering/GlobalBufferLoggerBuilderExtensionsTests.cs Outdated
Comment threadtest/Libraries/Microsoft.Extensions.Telemetry.Tests/Logging/ExtendedLoggerTests.cs Outdated
@evgenyfedorov2
evgenyfedorov2force-pushed the evgenyfedorov2/log_buffering branch 2 times, most recently from e40b7b6 to 9d61d12CompareDecember 12, 2024 16:30
@evgenyfedorov2
evgenyfedorov2force-pushed the evgenyfedorov2/log_buffering branch from 9d61d12 to 2f1a335CompareDecember 12, 2024 17:36
geeknoid
geeknoid reviewed Dec 15, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/BufferFilterRule.cs Outdated
geeknoid
geeknoid reviewed Dec 15, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/GlobalBufferOptions.cs Outdated
geeknoid
geeknoid reviewed Dec 15, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/GlobalBufferOptions.cs Outdated
@evgenyfedorov2
Fix namespaces
f7eaab1
Address PR comments
Add .NET 8 support
Add ExceptionJsonConverter
@evgenyfedorov2
Merge branch 'main' into evgenyfedorov2/log_buffering
1f464df
@evgenyfedorov2
evgenyfedorov2force-pushed the evgenyfedorov2/log_buffering branch from 883334d to 022f00cCompareDecember 16, 2024 14:23
@evgenyfedorov2
evgenyfedorov2force-pushed the evgenyfedorov2/log_buffering branch from 022f00c to a371d9cCompareDecember 16, 2024 14:51
@dotnet-comment-bot

dotnet-comment-bot commented Dec 16, 2024

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.AspNetCore.Diagnostics.MiddlewareLine10096.03 🔻
Microsoft.AspNetCore.Diagnostics.MiddlewareBranch10098.51 🔻
Microsoft.Extensions.TelemetryLine9386.2 🔻
Microsoft.Extensions.TelemetryBranch9384.59 🔻
Microsoft.Extensions.Diagnostics.TestingLine9985.78 🔻
Microsoft.Extensions.Diagnostics.TestingBranch9979.57 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.Diagnostics.Probes7076
Microsoft.Extensions.Caching.Hybrid7586
Microsoft.Extensions.AI.OpenAI7277

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=896358&view=codecoverage-tab

KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Dec 17, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.cs Outdated
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Dec 17, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/GlobalBuffer.cs Outdated
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Dec 17, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/ILoggingBuffer.cs Outdated
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Dec 17, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/GlobalBuffer.cs Outdated
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Dec 17, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/GlobalBufferManager.cs Outdated
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Dec 17, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/ILoggerFilterRule.cs Outdated
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Dec 17, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/BufferSink.cs Outdated
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Dec 17, 2024
View reviewed changes
Comment threadsrc/Shared/ExceptionJsonConverter/ExceptionJsonConverter.cs Outdated
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Dec 17, 2024
View reviewed changes
Comment threadsrc/Shared/ExceptionJsonConverter/ExceptionJsonConverter.cs Outdated
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Dec 18, 2024
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/PooledLogRecord.cs Outdated
@evgenyfedorov2
evgenyfedorov2force-pushed the evgenyfedorov2/log_buffering branch from e16928a to f6a2decCompareMarch 26, 2025 16:29
@evgenyfedorov2
evgenyfedorov2force-pushed the evgenyfedorov2/log_buffering branch 4 times, most recently from f01cbff to edcd424CompareMarch 27, 2025 16:24
@evgenyfedorov2
evgenyfedorov2force-pushed the evgenyfedorov2/log_buffering branch from edcd424 to 6e92aecCompareMarch 27, 2025 17:10
@evgenyfedorov2
evgenyfedorov2 enabled auto-merge (squash) April 2, 2025 13:18
@evgenyfedorov2

evgenyfedorov2 commented Apr 2, 2025

Copy link
Copy Markdown
MemberAuthor

@dariusclay, could you please help review this on behalf of the telemetry area? Thanks!

@evgenyfedorov2

evgenyfedorov2 commented Apr 8, 2025

Copy link
Copy Markdown
MemberAuthor

@RussKie could you review this for the parts related to dotnet/dotnet-extensions-infra parts, please?

RussKie
RussKie approved these changes Apr 8, 2025
View reviewed changes

@RussKieRussKie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the infra side, but noting possible implementation issues.

Comment thread...aries/Microsoft.AspNetCore.Diagnostics.Middleware/Buffering/PerRequestLogBufferingOptions.cs Outdated
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/GlobalLogBufferingOptions.cs Outdated
@RussKie
RussKie disabled auto-merge April 8, 2025 23:51
@RussKieRussKie added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 8, 2025
@dotnet-policy-servicedotnet-policy-serviceBot removed the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 9, 2025
@evgenyfedorov2
evgenyfedorov2 enabled auto-merge (squash) April 9, 2025 06:33
@evgenyfedorov2
evgenyfedorov2 merged commit 3ebeec1 into dotnet:mainApr 9, 2025
@KalleOlaviNiemitaloKalleOlaviNiemitalo mentioned this pull request Apr 9, 2025
Closed
KalleOlaviNiemitalo
KalleOlaviNiemitalo reviewed Apr 9, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Buffering/StringifyComprarer.cs

namespace Microsoft.Extensions.Diagnostics.Buffering;

internal sealed class StringifyComprarer : IEqualityComparer<KeyValuePair<string, object?>>

@KalleOlaviNiemitaloKalleOlaviNiemitaloApr 9, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been StringifyComparer, not StringifyComprarer. It's not public though.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@geeknoidgeeknoidgeeknoid approved these changes
@tarekghtarekghAwaiting requested review from tarekgh
@noahfalknoahfalkAwaiting requested review from noahfalk
@dariusclaydariusclayAwaiting requested review from dariusclay
+2 more reviewers
@KalleOlaviNiemitaloKalleOlaviNiemitaloKalleOlaviNiemitalo left review comments
@RussKieRussKieRussKie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@evgenyfedorov2evgenyfedorov2

Labels

area-telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@evgenyfedorov2@dotnet-comment-bot@tarekgh@KalleOlaviNiemitalo@RussKie@noahfalk@geeknoid