Skip to content

Add Obsolete attribute on IResourceMonitor and its friends - #5774

Merged
evgenyfedorov2 merged 2 commits into
dotnet:mainfrom
evgenyfedorov2:users/evgenyfedorov2/deprecate_iresourcemonitor
Jan 16, 2025
Merged

Add Obsolete attribute on IResourceMonitor and its friends#5774
evgenyfedorov2 merged 2 commits into
dotnet:mainfrom
evgenyfedorov2:users/evgenyfedorov2/deprecate_iresourcemonitor

Conversation

@evgenyfedorov2

@evgenyfedorov2evgenyfedorov2 commented Jan 6, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Resolves#5773

Microsoft Reviewers: Open in CodeFlow

@evgenyfedorov2
evgenyfedorov2 requested review from a team as code ownersJanuary 6, 2025 12:46
@amadeuszl

amadeuszl commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

There's SourceIpAddresses in ResourceMonitoringOptions.Windows that I believe should be Obsolete as well

@amadeuszl

amadeuszl commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Could we specify in readme (unless there's some guide somewhere else) what's obsolete and what's new recommended way of the library usage? It may be quite important as at least half of the codebase of the library will be obsolete at this point.

@evgenyfedorov2

evgenyfedorov2 commented Jan 8, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

There's SourceIpAddresses in ResourceMonitoringOptions.Windows that I believe should be Obsolete as well

I did not make it obsolete intentionally because it is used in WindowsTcpStateInfo, which is not related to IResourceMonitor. It should stay because it is relevant for .NET Metrics

@evgenyfedorov2

evgenyfedorov2 commented Jan 8, 2025

Copy link
Copy Markdown
MemberAuthor

Could we specify in readme (unless there's some guide somewhere else) what's obsolete and what's new recommended way of the library usage? It may be quite important as at least half of the codebase of the library will be obsolete at this point.

We already provide quick Diagnostics IDs here. Conceptual documentation of Resource Monitoring is here and of course it will need to be updated too, but it is a different repo, so created an issue there. Is this what you are suggesting or is it something different?

amadeuszl
amadeuszl approved these changes Jan 9, 2025
View reviewed changes

@amadeuszlamadeuszl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no more questions

@evgenyfedorov2
evgenyfedorov2 merged commit 8f15b0f into dotnet:mainJan 16, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amadeuszlamadeuszlamadeuszl approved these changes

Assignees

@evgenyfedorov2evgenyfedorov2

Labels

area-telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Obsolete attribute to public API which use IResourceMonitor

2 participants

@evgenyfedorov2@amadeuszl