Skip to content

Ensure Ollama streaming updates specify a CompletionId. - #5795

Merged
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:ollama-add-completionid
Jan 14, 2025
Merged

Ensure Ollama streaming updates specify a CompletionId.#5795
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:ollama-add-completionid

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Jan 14, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Discovered while working on eiriktsarpalis/blackbeard-extension-cs#1. Non-streaming completions use the CreatedAt timestamp as the completion id, however this is being omitted for the case of streaming completions.

Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis
eiriktsarpalis requested a review from a team as a code ownerJanuary 14, 2025 11:45
@eiriktsarpalis
eiriktsarpalis enabled auto-merge (squash) January 14, 2025 11:45
@dotnet-comment-bot

dotnet-comment-bot commented Jan 14, 2025

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=916794&view=codecoverage-tab

stephentoub
stephentoub reviewed Jan 14, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.Ollama/OllamaChatClient.cs
@dotnet-comment-bot

dotnet-comment-bot commented Jan 14, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8678.07 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=917062&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalis merged commit b26772a into dotnet:mainJan 14, 2025
@eiriktsarpalis
eiriktsarpalis deleted the ollama-add-completionid branch January 14, 2025 21:04
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 14, 2025
@jeffhandleyjeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eiriktsarpalis@dotnet-comment-bot@stephentoub@jeffhandley