Skip to content

Make HealthChecks.ResourceUtilization use observable instruments - #5798

Merged
evgenyfedorov2 merged 2 commits into
dotnet:mainfrom
evgenyfedorov2:users/evgenyfedorov2/healthchecks_use_metrics
Jan 30, 2025
Merged

Make HealthChecks.ResourceUtilization use observable instruments#5798
evgenyfedorov2 merged 2 commits into
dotnet:mainfrom
evgenyfedorov2:users/evgenyfedorov2/healthchecks_use_metrics

Conversation

@evgenyfedorov2

@evgenyfedorov2evgenyfedorov2 commented Jan 16, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Fixes#5779

Microsoft Reviewers: Open in CodeFlow

@evgenyfedorov2
evgenyfedorov2 requested a review from a team as a code ownerJanuary 16, 2025 13:57
@dotnet-comment-bot

dotnet-comment-bot commented Jan 16, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Diagnostics.HealthChecks.ResourceUtilizationLine10099.12 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.OpenAI7778

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=919875&view=codecoverage-tab

@evgenyfedorov2
evgenyfedorov2force-pushed the users/evgenyfedorov2/healthchecks_use_metrics branch from 4a82fd4 to bf28441CompareJanuary 16, 2025 15:32
@dotnet-comment-bot

dotnet-comment-bot commented Jan 20, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8684.76 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.OpenAI7778

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=919916&view=codecoverage-tab

amadeuszl
amadeuszl reviewed Jan 21, 2025
View reviewed changes
Comment thread...ft.Extensions.Diagnostics.HealthChecks.ResourceUtilization/ResourceUtilizationHealthCheck.cs
Comment thread...ft.Extensions.Diagnostics.HealthChecks.ResourceUtilization/ResourceUtilizationHealthCheck.cs Outdated
@dotnet-comment-bot

dotnet-comment-bot commented Jan 23, 2025

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=926730&view=codecoverage-tab

@evgenyfedorov2
evgenyfedorov2 merged commit 2534f08 into dotnet:mainJan 30, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amadeuszlamadeuszlamadeuszl approved these changes

Assignees

@evgenyfedorov2evgenyfedorov2

Labels

area-resourcemonitoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make HealthChecks.ResourceUtilization use observable instruments

3 participants

@evgenyfedorov2@dotnet-comment-bot@amadeuszl