Skip to content

Make a number of improvements to the OpenAI serialization helpers. - #5799

Merged
eiriktsarpalis merged 3 commits into
dotnet:mainfrom
eiriktsarpalis:improve-openai-serialization
Jan 17, 2025
Merged

Make a number of improvements to the OpenAI serialization helpers.#5799
eiriktsarpalis merged 3 commits into
dotnet:mainfrom
eiriktsarpalis:improve-openai-serialization

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Jan 16, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member
  1. Makes a number of fixes in the OpenAI mapping logic.
  2. Adds a custom converter for the OpenAIChatCompletionRequest envelope type that uses OpenAI wire format. This should make it possible to bind to that type directly in the context of MVC apps.
Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis
eiriktsarpalis requested a review from a team as a code ownerJanuary 16, 2025 19:47
@eiriktsarpalis
eiriktsarpalis enabled auto-merge (squash) January 16, 2025 20:09
@dotnet-comment-bot

dotnet-comment-bot commented Jan 16, 2025

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.OpenAI7778

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=920173&view=codecoverage-tab

@evgenyfedorov2evgenyfedorov2 added the area-ai Microsoft.Extensions.AI libraries label Jan 17, 2025
@dotnet-comment-bot

dotnet-comment-bot commented Jan 17, 2025

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.OpenAI7778

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=921110&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalis merged commit c63bc2c into dotnet:mainJan 17, 2025
@eiriktsarpalis
eiriktsarpalis deleted the improve-openai-serialization branch January 17, 2025 17:38
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eiriktsarpalis@dotnet-comment-bot@stephentoub@evgenyfedorov2