Skip to content

Remove ImageContent and AudioContent - #5814

Merged
MackinnonBuck merged 9 commits into
mainfrom
mbuck/datacontent-fixes
Jan 29, 2025
Merged

Remove ImageContent and AudioContent#5814
MackinnonBuck merged 9 commits into
mainfrom
mbuck/datacontent-fixes

Conversation

@MackinnonBuck

@MackinnonBuckMackinnonBuck commented Jan 24, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Removes the ImageContent and AudioContent types.

The recommendation will be that chat client implementors and app developers use DataContent.MediaType to distinguish between the various content types.

Fixes#5719

Microsoft Reviewers: Open in CodeFlow

@MackinnonBuck
MackinnonBuck requested review from a team as code ownersJanuary 24, 2025 22:20
@dotnet-comment-bot

dotnet-comment-bot commented Jan 25, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8684.76 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=928961&view=codecoverage-tab

stephentoub
stephentoub reviewed Jan 27, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.AzureAIInference/AzureAIInferenceChatClient.cs Outdated
Comment threadsrc/Shared/AIExtensions/DataContentMediaTypeExtensions.cs Outdated
Comment threadsrc/Libraries/Microsoft.Extensions.AI.Ollama/OllamaChatClient.cs Outdated
Comment thread...rosoft.Extensions.AI.Abstractions.Tests/ChatCompletion/StreamingChatCompletionUpdateTests.cs Outdated
@dotnet-comment-bot

dotnet-comment-bot commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=931303&view=codecoverage-tab

@dotnet-comment-bot

dotnet-comment-bot commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=932146&view=codecoverage-tab

@dotnet-comment-bot

dotnet-comment-bot commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8677.7 🔻
Microsoft.Extensions.AI.OllamaLine8078.25 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI.OpenAI7778

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=932449&view=codecoverage-tab

stephentoub
stephentoub reviewed Jan 29, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.Abstractions/Contents/DataContent.cs Outdated
stephentoub
stephentoub reviewed Jan 29, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.AzureAIInference/AzureAIInferenceChatClient.cs Outdated
@dotnet-comment-bot

dotnet-comment-bot commented Jan 29, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.25 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=933933&view=codecoverage-tab

@MackinnonBuck
MackinnonBuck merged commit acc985a into mainJan 29, 2025
@MackinnonBuck
MackinnonBuck deleted the mbuck/datacontent-fixes branch January 29, 2025 21:44
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 1, 2025
@jeffhandleyjeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis left review comments
@stephentoubstephentoubstephentoub approved these changes

Assignees

@MackinnonBuckMackinnonBuck

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revisit DataContent and friends

5 participants

@MackinnonBuck@dotnet-comment-bot@stephentoub@eiriktsarpalis@jeffhandley