Skip to content

Move AIFunction parameter schematization from parameter level to function level. - #5826

Merged
eiriktsarpalis merged 4 commits into
dotnet:mainfrom
eiriktsarpalis:feature/function-metadata
Feb 7, 2025
Merged

Move AIFunction parameter schematization from parameter level to function level.#5826
eiriktsarpalis merged 4 commits into
dotnet:mainfrom
eiriktsarpalis:feature/function-metadata

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Jan 29, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Fix#5655.

@dotnet-comment-bot

dotnet-comment-bot commented Jan 29, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8077.94 🔻
Microsoft.Extensions.AI.OllamaBranch8079.73 🔻
Microsoft.Extensions.Caching.HybridLine8677.7 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI.Abstractions8385
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=933837&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalisforce-pushed the feature/function-metadata branch from 0a3b415 to ec8d3abCompareFebruary 3, 2025 18:39
@eiriktsarpalis
eiriktsarpalis marked this pull request as ready for review February 3, 2025 18:41
@eiriktsarpalis
eiriktsarpalis requested a review from a team as a code ownerFebruary 3, 2025 18:41
@dotnet-comment-bot

dotnet-comment-bot commented Feb 3, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.24 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI.Abstractions8385

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=938548&view=codecoverage-tab

stephentoub
stephentoub reviewed Feb 4, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.AzureAIInference/AzureAIInferenceChatClient.cs Outdated
stephentoub
stephentoub reviewed Feb 4, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.Ollama/OllamaChatClient.cs Outdated
stephentoub
stephentoub reviewed Feb 4, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIModelMapper.ChatCompletion.cs Outdated
stephentoub
stephentoub reviewed Feb 4, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIRealtimeExtensions.cs Outdated
stephentoub
stephentoub reviewed Feb 4, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIRealtimeExtensions.cs Outdated
@dotnet-comment-bot

dotnet-comment-bot commented Feb 4, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.11 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.Abstractions8385

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=939708&view=codecoverage-tab

@RussKieRussKie added the area-ai Microsoft.Extensions.AI libraries label Feb 4, 2025
@eiriktsarpalis
eiriktsarpalis requested review from a team and stephentoubFebruary 5, 2025 15:36
@eiriktsarpalis
eiriktsarpalis enabled auto-merge (squash) February 7, 2025 17:10
@dotnet-comment-bot

dotnet-comment-bot commented Feb 7, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Extensions.AI.OllamaLine8078.11 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.Abstractions8385

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=944418&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalis merged commit 7f98df2 into dotnet:mainFeb 7, 2025
@eiriktsarpalis
eiriktsarpalis deleted the feature/function-metadata branch February 7, 2025 17:58
@eiriktsarpaliseiriktsarpalis mentioned this pull request Feb 13, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Microsoft.Extensions.AI.AIFunctionMetadata should allow to be initialized with a json schema string

4 participants

@eiriktsarpalis@dotnet-comment-bot@stephentoub@RussKie