Skip to content

Small fixes for chat template - #5839

Merged
MackinnonBuck merged 6 commits into
mainfrom
mbuck/small-template-fixes
Feb 4, 2025
Merged

Small fixes for chat template#5839
MackinnonBuck merged 6 commits into
mainfrom
mbuck/small-template-fixes

Conversation

@MackinnonBuck

@MackinnonBuckMackinnonBuck commented Feb 4, 2025

Copy link
Copy Markdown
Member

Fixes some issues that unblock local development:

  1. Add a launchSettings.json file. Without this, the environment defaults to Production and this causes the page to fail to load when running with dotnet run.
  2. Fix the TailwindBuild target to always run after the BuildNpmDependencies target. This just required changing the AfterTargets to a DependsOnTargets.
Microsoft Reviewers: Open in CodeFlow

@MackinnonBuck
MackinnonBuck requested a review from a team as a code ownerFebruary 4, 2025 00:03
@MackinnonBuck
MackinnonBuck requested review from SteveSandersonMS and removed request for a teamFebruary 4, 2025 00:04
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.25 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI.OpenAI7778

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=938914&view=codecoverage-tab

@SteveSandersonMS

Copy link
Copy Markdown
Member

Excellent - thanks!

I don't know how much difference it makes but the ASP.NET Core templates also do something to suppress these kestrelHttp(s)Port parameters from appearing in the CLI: https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/.template.config/dotnetcli.host.json#L11-L16

If you think it's reasonable to copy that pattern here that's great, but like I say I'm not certain what impact it has.

@MackinnonBuck

Copy link
Copy Markdown
MemberAuthor

If you think it's reasonable to copy that pattern here that's great, but like I say I'm not certain what impact it has.

Yep, seems reasonable to me 🙂

@MackinnonBuck
MackinnonBuck enabled auto-merge (squash) February 4, 2025 17:52
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.25 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI.Abstractions8384

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=939731&view=codecoverage-tab

@MackinnonBuck
MackinnonBuck merged commit ab94e0b into mainFeb 4, 2025
@MackinnonBuck
MackinnonBuck deleted the mbuck/small-template-fixes branch February 4, 2025 18:24
@jeffhandleyjeffhandley added the area-ai-templates Microsoft.Extensions.AI.Templates label Mar 7, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai-templatesMicrosoft.Extensions.AI.Templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MackinnonBuck@dotnet-comment-bot@SteveSandersonMS@jeffhandley