Skip to content

Chat template CR feedback - #5845

Merged
stephentoub merged 2 commits into
mainfrom
stevesa/chat-template-cr-feedback
Feb 4, 2025
Merged

Chat template CR feedback#5845
stephentoub merged 2 commits into
mainfrom
stevesa/chat-template-cr-feedback

Conversation

@SteveSandersonMS

@SteveSandersonMSSteveSandersonMS commented Feb 4, 2025

Copy link
Copy Markdown
Member

Handles feedback from #5837

Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.AI.OllamaLine8078.25 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI.Abstractions8384

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=939525&view=codecoverage-tab

@stephentoub
stephentoub merged commit a0fdbfd into mainFeb 4, 2025
@stephentoub
stephentoub deleted the stevesa/chat-template-cr-feedback branch February 4, 2025 17:09
@jeffhandleyjeffhandley added the area-ai-templates Microsoft.Extensions.AI.Templates label Mar 7, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai-templatesMicrosoft.Extensions.AI.Templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveSandersonMS@dotnet-comment-bot@stephentoub@jeffhandley