Skip to content

Remove Tailwind and NPM dependency from chat template - #5846

Merged
MackinnonBuck merged 18 commits into
mainfrom
mbuck/ai-template-remove-npm
Feb 5, 2025
Merged

Remove Tailwind and NPM dependency from chat template#5846
MackinnonBuck merged 18 commits into
mainfrom
mbuck/ai-template-remove-npm

Conversation

@MackinnonBuck

@MackinnonBuckMackinnonBuck commented Feb 4, 2025

Copy link
Copy Markdown
Member

This PR:

  1. Removes tailwind classes from Razor components and replaces them with CSS classes defined in the project
  2. Removes NPM as a dependency and instead includes external dependencies directly in the wwwroot folder

Fixeshttps://github.com/dotnet/ai-private-planning/issues/272
Fixeshttps://github.com/dotnet/ai-private-planning/issues/273

Microsoft Reviewers: Open in CodeFlow

…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.Caching.HybridLine8677.82 🔻
Microsoft.Extensions.AI.OllamaLine8078.25 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=940194&view=codecoverage-tab

@SteveSandersonMSSteveSandersonMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks very much! What you've done with the CSS looks perfect.

I added some minor suggestions about using CSS shorthand syntax in a few places. I'm pretty sure none of them will change the resulting styles, but it's possible I could have a typo in there so please let me know if anything looks wrong.

MackinnonBuckand others added 8 commits February 5, 2025 09:07
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatInput.razor.css
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageItem.razor.css
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/Components/Pages/Chat/ChatMessageList.razor.css
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
MackinnonBuckand others added 4 commits February 5, 2025 09:10
…tWithCustomData/ChatWithCustomData.Web/wwwroot/app.css
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@MackinnonBuck
MackinnonBuck enabled auto-merge (squash) February 5, 2025 17:34
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.25 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.Caching.Hybrid8687
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=941270&view=codecoverage-tab

@MackinnonBuck
MackinnonBuck merged commit 3640389 into mainFeb 5, 2025
@MackinnonBuck
MackinnonBuck deleted the mbuck/ai-template-remove-npm branch February 5, 2025 18:13
@jeffhandleyjeffhandley added the area-ai-templates Microsoft.Extensions.AI.Templates label Mar 7, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai-templatesMicrosoft.Extensions.AI.Templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MackinnonBuck@dotnet-comment-bot@SteveSandersonMS@jeffhandley