Skip to content

Use unsafe relaxed escaping in AIJsonUtilities.DefaultOptions. - #5850

Merged
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:relax-escaping
Feb 7, 2025
Merged

Use unsafe relaxed escaping in AIJsonUtilities.DefaultOptions.#5850
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:relax-escaping

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Feb 6, 2025

Copy link
Copy Markdown
Member

It is common for AI vendor APIs to embed JSON documents inside JSON strings, which results in quotes and most non-ASCII content being escaped and confusing consuming LLMs. This updates the default STJ options to use JavaScriptEncoder.UnsafeRelaxedJsonEscaping.

FYI @GrabYourPitchforks@SergeyMenshykh

Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.AI.OllamaLine8078.25 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=943071&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalis enabled auto-merge (squash) February 6, 2025 20:07
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.AI.OllamaLine8078.25 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.OpenAI7778
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.Abstractions8384

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=943191&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalis merged commit 11ccd68 into dotnet:mainFeb 7, 2025
@eiriktsarpalis
eiriktsarpalis deleted the relax-escaping branch February 7, 2025 15:03
@jeffhandleyjeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@eiriktsarpalis@dotnet-comment-bot@stephentoub@jeffhandley