Skip to content

Use an environment variable for configuring Ollama integration tests - #5851

Merged
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:ollama-integration-env
Feb 6, 2025
Merged

Use an environment variable for configuring Ollama integration tests#5851
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:ollama-integration-env

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Feb 6, 2025

Copy link
Copy Markdown
Member

I very often catch myself accidentally committing changes to Ollama's integration test helper. This changes the helper so that the endpoint is detected from the environment.

Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis
eiriktsarpalis enabled auto-merge (squash) February 6, 2025 19:37
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Extensions.AI.OllamaLine8078.25 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.Abstractions8384
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.OpenAI7778

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=943094&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalis merged commit 19fd307 into dotnet:mainFeb 6, 2025
@eiriktsarpalis
eiriktsarpalis deleted the ollama-integration-env branch February 6, 2025 20:44
@jeffhandleyjeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@eiriktsarpalis@dotnet-comment-bot@SteveSandersonMS@jeffhandley