Skip to content

Generalise how package version isn't stabilized for dev/preview stages - #5864

Merged
RussKie merged 1 commit into
dotnet:mainfrom
RussKie:staging2
Feb 12, 2025
Merged

Generalise how package version isn't stabilized for dev/preview stages#5864
RussKie merged 1 commit into
dotnet:mainfrom
RussKie:staging2

Conversation

@RussKie

@RussKieRussKie commented Feb 10, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Contributor

Follow up on #5632

Microsoft Reviewers: Open in CodeFlow

@RussKie
RussKie requested review from a team as code ownersFebruary 10, 2025 00:25
@RussKie

RussKie commented Feb 10, 2025

Copy link
Copy Markdown
ContributorAuthor

Replace #5640.

/cc: @joperezr

@RussKieRussKie mentioned this pull request Feb 10, 2025
Closed
@dotnet-comment-bot

dotnet-comment-bot commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.Caching.HybridLine8682.92 🔻
Microsoft.Extensions.AI.OllamaLine8078.11 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI.Abstractions8385

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=946062&view=codecoverage-tab

wtgodbe
wtgodbe approved these changes Feb 12, 2025
View reviewed changes

@wtgodbewtgodbe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@dotnet-comment-bot

dotnet-comment-bot commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.Caching.HybridLine8682.92 🔻
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Extensions.AI.OpenAILine7768.75 🔻
Microsoft.Extensions.AI.OpenAIBranch7750.41 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI.Abstractions8385
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=949220&view=codecoverage-tab

@RussKie
RussKie merged commit 4efecdf into dotnet:mainFeb 12, 2025
@RussKie
RussKie deleted the staging2 branch February 12, 2025 04:49
@RussKieRussKie mentioned this pull request Feb 12, 2025
Merged
@RussKieRussKie mentioned this pull request Mar 11, 2025
Merged
@rnelsonrnelson mentioned this pull request Mar 12, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sebastienrossebastienrossebastienros approved these changes
@wtgodbewtgodbewtgodbe approved these changes

Assignees

@RussKieRussKie

Labels

area-infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RussKie@dotnet-comment-bot@sebastienros@wtgodbe