Skip to content

Rename IChatClient members and corresponding types - #5870

Merged
stephentoub merged 4 commits into
dotnet:mainfrom
stephentoub:renamecompletions
Feb 11, 2025
Merged

Rename IChatClient members and corresponding types#5870
stephentoub merged 4 commits into
dotnet:mainfrom
stephentoub:renamecompletions

Conversation

@stephentoub

@stephentoubstephentoub commented Feb 10, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

After great feedback on usage of the APIs, re-reviewing the state of the ecosystem, and length discussions, we're renaming the members of IChatClient to destress the notion of "completions" and instead focus just on getting back a {streaming} response.

Closes#5868

Microsoft Reviewers: Open in CodeFlow

@stephentoub
stephentoub requested a review from a team as a code ownerFebruary 10, 2025 20:53
@dotnet-comment-bot

dotnet-comment-bot commented Feb 10, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OpenAILine7771.71 🔻
Microsoft.Extensions.AI.OpenAIBranch7753.28 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.AI.OllamaLine8078.2 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.Abstractions8385
Microsoft.Extensions.Caching.Hybrid8687
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=947185&view=codecoverage-tab

@RussKieRussKie added the area-ai Microsoft.Extensions.AI libraries label Feb 11, 2025
@stephentoubstephentoub mentioned this pull request Feb 11, 2025
Merged
@stephentoub
Rename IChatClient members and corresponding types
4ae06da
After great feedback on usage of the APIs, re-reviewing the state of the ecosystem, and length discussions, we're renaming the members of IChatClient to destress the notion of "completions" and instead focus just on getting back a {streaming} response.
@dotnet-comment-bot

dotnet-comment-bot commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Extensions.AI.OpenAILine7768.75 🔻
Microsoft.Extensions.AI.OpenAIBranch7750.41 🔻
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI.Abstractions8385

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=947770&view=codecoverage-tab

SteveSandersonMS
SteveSandersonMS reviewed Feb 11, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIModelMapper.ChatCompletion.cs Outdated
SteveSandersonMS
SteveSandersonMS reviewed Feb 11, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIRealtimeExtensions.cs Outdated
SteveSandersonMS
SteveSandersonMS reviewed Feb 11, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI/CachingHelpers.cs Outdated
SteveSandersonMS
SteveSandersonMS reviewed Feb 11, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs Outdated
SteveSandersonMS
SteveSandersonMS reviewed Feb 11, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs Outdated
SteveSandersonMS
SteveSandersonMS reviewed Feb 11, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI/Embeddings/CachingEmbeddingGenerator.cs Outdated
SteveSandersonMS
SteveSandersonMS approved these changes Feb 11, 2025
View reviewed changes

@SteveSandersonMSSteveSandersonMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

stephentoub
stephentoub commented Feb 11, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.AzureAIInference/AzureAIInferenceChatClient.cs Outdated
stephentoub
stephentoub commented Feb 11, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI/ChatCompletion/AnonymousDelegatingChatClient.cs Outdated
stephentouband others added 2 commits February 11, 2025 07:36
@stephentoub@SteveSandersonMS
Apply suggestions from code review
052fb61
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@stephentoub@SteveSandersonMS
Update src/Libraries/Microsoft.Extensions.AI.AzureAIInference/AzureAI…
ff2969c
…InferenceChatClient.cs
Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@dotnet-comment-bot

dotnet-comment-bot commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.92 🔻
Microsoft.Extensions.AI.OpenAILine7768.75 🔻
Microsoft.Extensions.AI.OpenAIBranch7750.41 🔻
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.Abstractions8385
Microsoft.Extensions.AI.AzureAIInference9192

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=948177&view=codecoverage-tab

@stephentoub
stephentoub enabled auto-merge (squash) February 11, 2025 14:38
@dotnet-comment-bot

dotnet-comment-bot commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.AI.OpenAILine7768.75 🔻
Microsoft.Extensions.AI.OpenAIBranch7750.41 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.Caching.Hybrid8687
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.Abstractions8385

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=948307&view=codecoverage-tab

@stephentoub
stephentoub merged commit fab3675 into dotnet:mainFeb 11, 2025
@rnelsonrnelson mentioned this pull request Mar 12, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
@stephentoub
stephentoub deleted the renamecompletions branch March 21, 2025 14:26
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SteveSandersonMSSteveSandersonMSSteveSandersonMS approved these changes
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@JeremyLiknessJeremyLiknessAwaiting requested review from JeremyLikness
@luisquintanillaluisquintanillaAwaiting requested review from luisquintanilla

Assignees

@stephentoubstephentoub

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename IChatClient's methods and result types

5 participants

@stephentoub@dotnet-comment-bot@SteveSandersonMS@eiriktsarpalis@RussKie