Skip to content

Enable API compat validation - #5871

Merged
RussKie merged 1 commit into
dotnet:mainfrom
RussKie:apivalidation
Feb 12, 2025
Merged

Enable API compat validation#5871
RussKie merged 1 commit into
dotnet:mainfrom
RussKie:apivalidation

Conversation

@RussKie

@RussKieRussKie commented Feb 11, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Contributor
Microsoft Reviewers: Open in CodeFlow

@RussKie
RussKieforce-pushed the apivalidation branch 2 times, most recently from beda5f1 to d3c7d3aCompareFebruary 11, 2025 04:55
@dotnet-comment-bot

dotnet-comment-bot commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OpenAILine7771.71 🔻
Microsoft.Extensions.AI.OpenAIBranch7753.28 🔻
Microsoft.Extensions.Caching.HybridLine8682.92 🔻
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI.Abstractions8385
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=947663&view=codecoverage-tab

@RussKie
RussKie marked this pull request as ready for review February 11, 2025 23:14
@RussKie
RussKie requested review from a team as code ownersFebruary 11, 2025 23:14
@dotnet-comment-bot

dotnet-comment-bot commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OpenAILine7768.75 🔻
Microsoft.Extensions.AI.OpenAIBranch7750.41 🔻
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.Abstractions8385
Microsoft.Extensions.Caching.Hybrid8687
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.AzureAIInference9192

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=948992&view=codecoverage-tab

wtgodbe
wtgodbe approved these changes Feb 12, 2025
View reviewed changes

@wtgodbewtgodbe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@RussKie
RussKie enabled auto-merge (squash) February 12, 2025 00:41
stephentoub
stephentoub reviewed Feb 12, 2025
View reviewed changes
Comment threadeng/Versions.props
@RussKie
RussKie merged commit 698296d into dotnet:mainFeb 12, 2025
@RussKie
RussKie deleted the apivalidation branch February 12, 2025 02:49
RussKie
RussKie commented Feb 12, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.Abstractions/Microsoft.Extensions.AI.Abstractions.csproj
<PropertyGroup>
<Stage>preview</Stage>
<SuppressFinalPackageVersion>true</SuppressFinalPackageVersion>
<EnablePackageValidation>false</EnablePackageValidation>

@RussKieRussKieFeb 12, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shyamnamboodiripad FYI, you may need to apply the same to the Eval projects under /src/Libraries.

@shyamnamboodiripadshyamnamboodiripadFeb 12, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the heads up! That probably explains why recent builds in #5873 have been failing...

@RussKieRussKieFeb 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I have cycles, I'll look into generalising MSBuild configs that are required for each AI project.

@rnelsonrnelson mentioned this pull request Mar 12, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shyamnamboodiripadshyamnamboodiripadshyamnamboodiripad left review comments
@sebastienrossebastienrossebastienros approved these changes
@stephentoubstephentoubstephentoub approved these changes
@wtgodbewtgodbewtgodbe approved these changes

Assignees

@RussKieRussKie

Labels

area-infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RussKie@dotnet-comment-bot@sebastienros@stephentoub@shyamnamboodiripad@wtgodbe