Skip to content

Use Environment.WorkingSet in WindowsSnapshotProvider - #5874

Merged
evgenyfedorov2 merged 1 commit into
dotnet:mainfrom
evgenyfedorov2:users/evgenyfedorov2/useenvworkingset
Feb 17, 2025
Merged

Use Environment.WorkingSet in WindowsSnapshotProvider#5874
evgenyfedorov2 merged 1 commit into
dotnet:mainfrom
evgenyfedorov2:users/evgenyfedorov2/useenvworkingset

Conversation

@evgenyfedorov2

@evgenyfedorov2evgenyfedorov2 commented Feb 11, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Fixes#5867

Microsoft Reviewers: Open in CodeFlow

@evgenyfedorov2evgenyfedorov2 self-assigned this Feb 11, 2025
@evgenyfedorov2
evgenyfedorov2 requested a review from a team as a code ownerFebruary 11, 2025 08:01
@dotnet-comment-bot

dotnet-comment-bot commented Feb 11, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Caching.HybridLine8682.77 🔻
Microsoft.Extensions.AI.OpenAILine7768.75 🔻
Microsoft.Extensions.AI.OpenAIBranch7750.41 🔻
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI.Abstractions8385

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=947916&view=codecoverage-tab

@evgenyfedorov2
evgenyfedorov2 merged commit b58c6b6 into dotnet:mainFeb 17, 2025
@rnelsonrnelson mentioned this pull request Mar 12, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub left review comments
@mobratilmobratilmobratil approved these changes
+1 more reviewer
@mScott224mScott224mScott224 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@evgenyfedorov2evgenyfedorov2

Labels

area-resourcemonitoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WindowsSnapshotProvider should obtain memory value from Environment.WorkingSet only

5 participants

@evgenyfedorov2@dotnet-comment-bot@stephentoub@mobratil@mScott224