Skip to content

Introduce type converter for DataClassification - #5887

Merged
dariusclay merged 13 commits into
mainfrom
dletterman/dataclass-typeconverter
Feb 19, 2025
Merged

Introduce type converter for DataClassification#5887
dariusclay merged 13 commits into
mainfrom
dletterman/dataclass-typeconverter

Conversation

@dariusclay

@dariusclaydariusclay commented Feb 12, 2025

Copy link
Copy Markdown
Member

This pull request introduces a new type converter for the DataClassification struct and includes corresponding tests to ensure its functionality. The most important changes include the addition of the DataClassificationTypeConverter class, the integration of this converter into the DataClassification struct, and the creation of unit tests to validate the converter's behavior.

This improves the DataClassification type by allowing it to be bound from configuration files, enhancing the flexibility and usability of the struct in various scenarios.

Microsoft Reviewers: Open in CodeFlow

@dariusclay
dariusclay marked this pull request as ready for review February 17, 2025 14:25
@dariusclay
dariusclay requested a review from a team as a code ownerFebruary 17, 2025 14:25
@dariusclay
dariusclay enabled auto-merge (squash) February 17, 2025 14:31
@eduherminio
eduherminio self-requested a review February 17, 2025 14:49
@dariusclay

Copy link
Copy Markdown
MemberAuthor

I'll add the experimental attribute to proper locations

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.Compliance.AbstractionsLine10099.48 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Gen.MetadataExtractor5771

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=954586&view=codecoverage-tab

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Gen.MetadataExtractor5771

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=954733&view=codecoverage-tab

@dariusclay
dariusclay enabled auto-merge (squash) February 17, 2025 22:00
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Gen.MetadataExtractor5771

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=954738&view=codecoverage-tab

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Gen.MetadataExtractor5771

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=955108&view=codecoverage-tab

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.Caching.Hybrid8287
Microsoft.Gen.MetadataExtractor5770

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=955658&view=codecoverage-tab

@RussKieRussKie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dariusclay

Copy link
Copy Markdown
MemberAuthor

still needing one more owner approval

@dariusclay
dariusclay merged commit 152f142 into mainFeb 19, 2025
@dariusclay
dariusclay deleted the dletterman/dataclass-typeconverter branch February 19, 2025 17:13
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@dariusclay@dotnet-comment-bot@RussKie@eduherminio@amadeuszl@evgenyfedorov2