Skip to content

Rename AIFunctionFactoryOptions and make all properties nullable. - #5906

Merged
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
eiriktsarpalis:schemacreateoptions
Feb 14, 2025
Merged

Rename AIFunctionFactoryOptions and make all properties nullable.#5906
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
eiriktsarpalis:schemacreateoptions

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Feb 14, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Salvages the API changes from #5905

Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis
eiriktsarpalis requested a review from a team as a code ownerFebruary 14, 2025 13:09
@eiriktsarpaliseiriktsarpalis changed the title Renamed AIFunctionFactoryOptions and make all properties nullable.Rename AIFunctionFactoryOptions and make all properties nullable.Feb 14, 2025
@eiriktsarpalis
eiriktsarpalis enabled auto-merge (squash) February 14, 2025 13:40
@dotnet-comment-bot

dotnet-comment-bot commented Feb 14, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Extensions.AI.Evaluation.QualityLine887.57 🔻
Microsoft.Extensions.AI.Evaluation.QualityBranch8816.42 🔻
Microsoft.Extensions.AI.Evaluation.ConsoleLine888.26 🔻
Microsoft.Extensions.AI.Evaluation.ConsoleBranch8817.07 🔻
Microsoft.Extensions.Caching.HybridLine8682.92 🔻
Microsoft.Extensions.AI.Evaluation.ReportingLine8872.06 🔻
Microsoft.Extensions.AI.Evaluation.ReportingBranch8864.8 🔻
Microsoft.Extensions.AI.EvaluationLine8858.67 🔻
Microsoft.Extensions.AI.EvaluationBranch8856.67 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.AI.OpenAILine7768.04 🔻
Microsoft.Extensions.AI.OpenAIBranch7749.8 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.AzureAIInference9192
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=952548&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalis merged commit f225a93 into dotnet:mainFeb 14, 2025
@eiriktsarpalis
eiriktsarpalis deleted the schemacreateoptions branch February 14, 2025 13:56
@jeffhandleyjeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
@rnelsonrnelson mentioned this pull request Mar 12, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eiriktsarpalis@dotnet-comment-bot@stephentoub@jeffhandley