Skip to content

Tweak a comment in FunctionInvokingChatClient - #5910

Merged
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:tweakcomment
Feb 17, 2025
Merged

Tweak a comment in FunctionInvokingChatClient#5910
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:tweakcomment

Conversation

@stephentoub

@stephentoubstephentoub commented Feb 15, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member
Microsoft Reviewers: Open in CodeFlow

@stephentoub
stephentoub requested a review from a team as a code ownerFebruary 15, 2025 14:34
@dotnet-comment-bot

dotnet-comment-bot commented Feb 15, 2025

Copy link
Copy Markdown
Collaborator

‼️Found issues‼️

ProjectCoverage TypeExpectedActual
Microsoft.Extensions.AI.OllamaLine8078.2 🔻
Microsoft.Extensions.AI.OpenAILine7767.92 🔻
Microsoft.Extensions.AI.OpenAIBranch7749.8 🔻
Microsoft.Extensions.AI.Evaluation.ConsoleLine888.26 🔻
Microsoft.Extensions.AI.Evaluation.ConsoleBranch8817.07 🔻
Microsoft.Extensions.Caching.HybridLine8682.69 🔻
Microsoft.Extensions.AI.Evaluation.QualityLine887.57 🔻
Microsoft.Extensions.AI.Evaluation.QualityBranch8816.42 🔻
Microsoft.Extensions.AI.Evaluation.ReportingLine8872.06 🔻
Microsoft.Extensions.AI.Evaluation.ReportingBranch8864.8 🔻
Microsoft.Extensions.AI.AzureAIInferenceLine9190.09 🔻
Microsoft.Extensions.AI.AzureAIInferenceBranch9186.76 🔻
Microsoft.Extensions.AI.AbstractionsBranch8382.85 🔻
Microsoft.Gen.MetadataExtractorLine9857.35 🔻
Microsoft.Gen.MetadataExtractorBranch9862.5 🔻
Microsoft.Extensions.AI.EvaluationLine8858.67 🔻
Microsoft.Extensions.AI.EvaluationBranch8856.67 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI8889

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=953614&view=codecoverage-tab

@stephentoub
stephentoub enabled auto-merge (squash) February 16, 2025 03:04
@SteveSandersonMSSteveSandersonMS mentioned this pull request Feb 17, 2025
Closed
@stephentoub
stephentoub merged commit 7226fd0 into dotnet:mainFeb 17, 2025
@jeffhandleyjeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
@rnelsonrnelson mentioned this pull request Mar 12, 2025
Merged
@stephentoub
stephentoub deleted the tweakcomment branch March 21, 2025 14:26
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SteveSandersonMSSteveSandersonMSSteveSandersonMS approved these changes

Assignees

@stephentoubstephentoub

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@dotnet-comment-bot@SteveSandersonMS@jeffhandley