Skip to content

Add GetRequiredService extension for IChatClient/EmbeddingGenerator - #5930

Merged
stephentoub merged 3 commits into
dotnet:mainfrom
stephentoub:getrequiredservice
Feb 19, 2025
Merged

Add GetRequiredService extension for IChatClient/EmbeddingGenerator#5930
stephentoub merged 3 commits into
dotnet:mainfrom
stephentoub:getrequiredservice

Conversation

@stephentoub

@stephentoubstephentoub commented Feb 19, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Member

Closes#5922

Microsoft Reviewers: Open in CodeFlow

@stephentoub
stephentoub requested review from a team as code ownersFebruary 19, 2025 04:53
@dotnet-comment-bot

dotnet-comment-bot commented Feb 19, 2025

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.Abstractions8283
Microsoft.Gen.MetadataExtractor5770

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=956078&view=codecoverage-tab

@stephentoub
stephentoub enabled auto-merge (squash) February 19, 2025 14:54
@dotnet-comment-bot

dotnet-comment-bot commented Feb 19, 2025

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.Abstractions8283
Microsoft.Extensions.Caching.Hybrid8287
Microsoft.Gen.MetadataExtractor5770

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=956523&view=codecoverage-tab

eerhardt
eerhardt reviewed Feb 19, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatClientExtensions.cs Outdated
eerhardt
eerhardt reviewed Feb 19, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatClientExtensions.cs Outdated
eerhardt
eerhardt approved these changes Feb 19, 2025
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@stephentoub@eerhardt
Apply suggestions from code review
3a57e74
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
@dotnet-comment-bot

dotnet-comment-bot commented Feb 19, 2025

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

ProjectExpectedActual
Microsoft.Extensions.AI.Abstractions8283
Microsoft.Gen.MetadataExtractor5770

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=956567&view=codecoverage-tab

@stephentoub
stephentoub merged commit b19cf20 into dotnet:mainFeb 19, 2025
@jeffhandleyjeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
@rnelsonrnelson mentioned this pull request Mar 12, 2025
Merged
@stephentoub
stephentoub deleted the getrequiredservice branch March 21, 2025 14:26
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@eerhardteerhardteerhardt approved these changes
@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS
+1 more reviewer
@eduherminioeduherminioeduherminio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@stephentoubstephentoub

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: GetRequiredService for IChatClient

7 participants

@stephentoub@dotnet-comment-bot@SteveSandersonMS@eiriktsarpalis@eerhardt@eduherminio@jeffhandley