Skip to content

[AI extensions] Add jsonSchemaIsStrict option to OpenAI options mapping - #6064

Merged
stephentoub merged 2 commits into
dotnet:mainfrom
danielwinkler:feature/strict-output-openai
Mar 16, 2025
Merged

[AI extensions] Add jsonSchemaIsStrict option to OpenAI options mapping#6064
stephentoub merged 2 commits into
dotnet:mainfrom
danielwinkler:feature/strict-output-openai

Conversation

@danielwinkler

@danielwinklerdanielwinkler commented Mar 10, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Contributor

See #6062

Microsoft Reviewers: Open in CodeFlow

@danielwinkler
danielwinkler requested a review from a team as a code ownerMarch 10, 2025 15:25
@github-actionsgithub-actionsBot added the area-ai Microsoft.Extensions.AI libraries label Mar 10, 2025
@danielwinkler

danielwinkler commented Mar 10, 2025

Copy link
Copy Markdown
ContributorAuthor

@dotnet-policy-service agree

@stephentoub

stephentoub commented Mar 11, 2025

Copy link
Copy Markdown
Member

What are the downsides to just always setting strict? I think it's "just" that if a schema is provided the OpenAI doesn't understand, it'll fail? Should we just always set strict and then optionally use something in additional properties as an override?

@SteveSandersonMS

SteveSandersonMS commented Mar 11, 2025

Copy link
Copy Markdown
Member

What are the downsides to just always setting strict? I think it's "just" that if a schema is provided the OpenAI doesn't understand, it'll fail? Should we just always set strict and then optionally use something in additional properties as an override?

There's nothing in OpenAI's announcement that clarifies the drawbacks. Maybe they just didn't know whether it would always work.

As per this longer explanation, I'd support always setting strict if there's a schema. And like you say, if OpenAI really needs to support some non-strict mode, that's very OpenAI-specific and could be handled by something in additional properties to override this.

@stephentoub
stephentoubforce-pushed the feature/strict-output-openai branch from f8ab339 to 5148a45CompareMarch 16, 2025 14:59
@stephentoub

stephentoub commented Mar 16, 2025

Copy link
Copy Markdown
Member

I pushed an update to your branch to fix up the remaining strict handling.

stephentoub
stephentoub approved these changes Mar 16, 2025
View reviewed changes

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub
stephentoub enabled auto-merge (squash) March 16, 2025 15:00
@stephentoubstephentoub mentioned this pull request Mar 16, 2025
Closed
@stephentoub
stephentoub merged commit e4e3187 into dotnet:mainMar 16, 2025
@stephentoubstephentoub mentioned this pull request Mar 17, 2025
Closed
@stephentoubstephentoub mentioned this pull request Apr 11, 2025
Merged
eiriktsarpalis added a commit to eiriktsarpalis/extensions that referenced this pull request Apr 11, 2025
@eiriktsarpalis
Undo a number of additional changes made bydotnet#6064
05d3744
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis left review comments
@stephentoubstephentoubstephentoub approved these changes
@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS

Assignees

@danielwinklerdanielwinkler

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danielwinkler@stephentoub@SteveSandersonMS@eiriktsarpalis@danielwinklermedel