Skip to content

[Telemetry, Logging] Emit {OriginalFormat} as the last property of the log record - #6111

Merged
iliar-turdushev merged 6 commits into
dotnet:mainfrom
iliar-turdushev:logger-originalformat
Mar 18, 2025
Merged

[Telemetry, Logging] Emit {OriginalFormat} as the last property of the log record#6111
iliar-turdushev merged 6 commits into
dotnet:mainfrom
iliar-turdushev:logger-originalformat

Conversation

@iliar-turdushev

@iliar-turdusheviliar-turdushev commented Mar 14, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Contributor

Updates the source-generated logging and the ExtendedLogger to emit the {OriginalFormat} property as the last item of the log record.

Fixes#5720

Microsoft Reviewers: Open in CodeFlow

@iliar-turdushev
Fixesdotnet#5720
5285308
Now {OriginalFormat} is emitted as the last item in the TagArray
@iliar-turdushev
Merge branch 'main' into logger-originalformat
35eac6d
@iliar-turdushev
Fixesdotnet#5720
fb35825
Adjusts ExtendedLogger to always return {OriginalFormat} as the last tag in the list
iliar-turdushev
iliar-turdushev commented Mar 16, 2025
View reviewed changes
Comment threadsrc/Generators/Microsoft.Gen.Logging/Emission/Emitter.Method.cs
@iliar-turdushev
Fixesdotnet#5720
96ab74f
Fixes ResourceMonitoring tests
evgenyfedorov2
evgenyfedorov2 reviewed Mar 17, 2025
View reviewed changes
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.LegacyTagJoiner.cs Outdated
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.ModernTagJoiner.cs Outdated
Comment threadsrc/Libraries/Microsoft.Extensions.Telemetry/Logging/ExtendedLogger.ModernTagJoiner.cs Outdated
@iliar-turdushev
Fixesdotnet#5720
21b58f4
Address PR comments
@iliar-turdushev
iliar-turdushev marked this pull request as ready for review March 17, 2025 14:37
@iliar-turdushev
iliar-turdushev requested review from a team as code ownersMarch 17, 2025 14:37
@iliar-turdusheviliar-turdushev changed the title [Work in progress] Emit {OriginalFormat} as the last property of the log record[Telemetry, Logging] Emit {OriginalFormat} as the last property of the log recordMar 17, 2025
@iliar-turdushev
iliar-turdushev merged commit 037c866 into dotnet:mainMar 18, 2025
@iliar-turdushev
iliar-turdushev deleted the logger-originalformat branch March 18, 2025 08:54
@iliar-turdushev
iliar-turdushev restored the logger-originalformat branch March 18, 2025 09:01
@iliar-turdushev
iliar-turdushev deleted the logger-originalformat branch March 18, 2025 14:46
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dariusclaydariusclaydariusclay approved these changes
@evgenyfedorov2evgenyfedorov2evgenyfedorov2 approved these changes

Assignees

@iliar-turdusheviliar-turdushev

Labels

area-telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ExtendedLogger] {OriginalFormat} is incorrectly exported by OpenTelemetry

3 participants

@iliar-turdushev@dariusclay@evgenyfedorov2