Skip to content

Fix Process Metric calculation in CgroupsV2 - #6321

Merged
evgenyfedorov2 merged 5 commits into
dotnet:mainfrom
nivebb8:nive/processMetricBugFix
Apr 22, 2025
Merged

Fix Process Metric calculation in CgroupsV2#6321
evgenyfedorov2 merged 5 commits into
dotnet:mainfrom
nivebb8:nive/processMetricBugFix

Conversation

@nivebb8

@nivebb8nivebb8 commented Apr 21, 2025•
edited by dotnet-policy-service Bot
Loading

Copy link
Copy Markdown
Contributor

Missed updating the process metric in first check-in. Updating the same to use correct calculations behind the flag, and to ensure CpuUtilization() is not invoked at all.

Microsoft Reviewers: Open in CodeFlow

@nivebb8
nivebb8 requested a review from a team as a code ownerApril 21, 2025 18:11
evgenyfedorov2
evgenyfedorov2 requested changes Apr 22, 2025
View reviewed changes

@evgenyfedorov2evgenyfedorov2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change?
The ResourceUtilizationInstruments.ProcessCpuUtilization metric is deprecated (unofficially). ResourceUtilizationInstruments.ContainerCpuRequestUtilization is the replacement and it already has the right calculation logic

@dotnet-policy-servicedotnet-policy-serviceBot added the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 22, 2025
@dotnet-policy-servicedotnet-policy-serviceBot removed the waiting-author-feedback 📭 The author of this issue needs to respond in order for us to continue investigating this issue. label Apr 22, 2025
@nivebb8
nivebb8 requested a review from a team as a code ownerApril 22, 2025 13:57
evgenyfedorov2
evgenyfedorov2 reviewed Apr 22, 2025
View reviewed changes
Comment thread...raries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/LinuxUtilizationProvider.cs Outdated
Comment threadsrc/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/Linux/Log.cs Outdated
@evgenyfedorov2
evgenyfedorov2 enabled auto-merge (squash) April 22, 2025 15:37
@evgenyfedorov2
evgenyfedorov2 merged commit e5b6b02 into dotnet:mainApr 22, 2025
@evgenyfedorov2

evgenyfedorov2 commented Apr 22, 2025

Copy link
Copy Markdown
Member

/backport to release/9.4

@github-actions

github-actionsBot commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/9.4: https://github.com/dotnet/extensions/actions/runs/14599507495

@github-actions

github-actionsBot commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

@evgenyfedorov2 an error occurred while backporting to "release/9.4", please check the run log for details!

Error: @evgenyfedorov2 is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=evgenyfedorov2

@evgenyfedorov2

evgenyfedorov2 commented Apr 22, 2025

Copy link
Copy Markdown
Member

/backport to release/9.4

@github-actions

github-actionsBot commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/9.4: https://github.com/dotnet/extensions/actions/runs/14599549296

@github-actionsgithub-actionsBot mentioned this pull request Apr 22, 2025
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 23, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@evgenyfedorov2evgenyfedorov2evgenyfedorov2 approved these changes

Assignees

@nivebb8nivebb8

Labels

area-telemetry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nivebb8@evgenyfedorov2@niver2d2