Skip to content

Bump PackageValidation against 9.5.0 and enable for stable MEAI packages - #6458

Merged
jeffhandley merged 2 commits into
dotnet:mainfrom
joperezr:PV
May 17, 2025
Merged

Bump PackageValidation against 9.5.0 and enable for stable MEAI packages#6458
jeffhandley merged 2 commits into
dotnet:mainfrom
joperezr:PV

Conversation

@joperezr

@joperezrjoperezr commented May 16, 2025

Copy link
Copy Markdown
Member

FYI: @stephentoub@jeffhandley this is turning on package validation for MEAI and MEAI.Abstractions to protect against unintentional breaking changes.

Microsoft Reviewers: Open in CodeFlow

@joperezr
joperezr requested review from a team as code ownersMay 16, 2025 18:41
@github-actionsgithub-actionsBot added the area-ai Microsoft.Extensions.AI libraries label May 16, 2025
@joperezr

Copy link
Copy Markdown
MemberAuthor

@shyamnamboodiripad also enabling it for MEAI.Evaluation packages.

@joperezr
joperezr requested a review from a team as a code ownerMay 16, 2025 18:43

@jeffhandleyjeffhandley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joperezr; you beat me to it!

I was going to ask you and @RussKie about package validation and ApiChief. They are both used in this repository, but I was previously unfamiliar with ApiChief. I got the impression ApiChief as an additional layer of guardrails above and beyond whta the .NET API Compat tool provides. Is it correct that both are in use in this repo?

@shyamnamboodiripadshyamnamboodiripad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeffhandley
jeffhandley merged commit 19cc568 into dotnet:mainMay 17, 2025
@RussKie

Copy link
Copy Markdown
Contributor

ApiChef is an inhouse tool built by the R9 team. I'm not too familiar with it, but I think it serves as an alternative to the Roslyn's public API analysers. One of the key features it was addressing was the warnings for the use of experimental API.

Few years ago, I made an attempt to replace it with the Roslyn analysers, but back then those had no experimental API support; so, I had to roll the change back. AFAIU, the analyzers now have support for the experimental attribute, so maybe it's time to re-evaluate the usefulness of the ApiChef?

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jun 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-aiMicrosoft.Extensions.AI libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@joperezr@RussKie@jeffhandley@shyamnamboodiripad