Skip to content

Remove always-on language feature flag: ErrorForNonVirtualMembersOverrides #20179

Description

@T-Gro

LanguageFeature.ErrorForNonVirtualMembersOverrides has shipped since F# 8.0 and is enabled for every selectable language version (the minimum accepted --langversion is 8.0). Its feature flag can therefore never be turned off, so it is dead configuration. This issue removes the flag and collapses the guarded code to its enabled behaviour.

What to remove

  • The ErrorForNonVirtualMembersOverrides case in LanguageFeatures.fs and LanguageFeatures.fsi
  • Its entry in the features map and its GetFeatureString arm
  • The featureErrorForNonVirtualMembersOverrides string in FSComp.txt
  • Every SupportsFeature LanguageFeature.ErrorForNonVirtualMembersOverrides / checkLanguageFeatureAndRecover … ErrorForNonVirtualMembersOverrides guard — keep only the enabled path and delete the legacy branch
  • Adjust affected tests and baselines accordingly

Consequence: --disableLanguageFeature:ErrorForNonVirtualMembersOverrides is no longer a recognised feature name.

Version mapping

LanguageFeature.ErrorForNonVirtualMembersOverrides, languageVersion80

Feature string

featureErrorForNonVirtualMembersOverrides,"Raises errors for non-virtual members overrides"

Part of #20139

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status
New

Relationships

None yet

Development

No branches or pull requests

Issue actions