LanguageFeature.ErrorForNonVirtualMembersOverrides has shipped since F# 8.0 and is enabled for every selectable language version (the minimum accepted --langversion is 8.0). Its feature flag can therefore never be turned off, so it is dead configuration. This issue removes the flag and collapses the guarded code to its enabled behaviour.
What to remove
- The
ErrorForNonVirtualMembersOverrides case in LanguageFeatures.fs and LanguageFeatures.fsi - Its entry in the
features map and its GetFeatureString arm - The
featureErrorForNonVirtualMembersOverrides string in FSComp.txt - Every
SupportsFeature LanguageFeature.ErrorForNonVirtualMembersOverrides / checkLanguageFeatureAndRecover … ErrorForNonVirtualMembersOverrides guard — keep only the enabled path and delete the legacy branch - Adjust affected tests and baselines accordingly
Consequence: --disableLanguageFeature:ErrorForNonVirtualMembersOverrides is no longer a recognised feature name.
Version mapping
| LanguageFeature.ErrorForNonVirtualMembersOverrides, languageVersion80 |
Feature string
| featureErrorForNonVirtualMembersOverrides,"Raises errors for non-virtual members overrides" |
Part of #20139
LanguageFeature.ErrorForNonVirtualMembersOverrideshas shipped since F# 8.0 and is enabled for every selectable language version (the minimum accepted--langversionis 8.0). Its feature flag can therefore never be turned off, so it is dead configuration. This issue removes the flag and collapses the guarded code to its enabled behaviour.What to remove
ErrorForNonVirtualMembersOverridescase inLanguageFeatures.fsandLanguageFeatures.fsifeaturesmap and itsGetFeatureStringarmfeatureErrorForNonVirtualMembersOverridesstring inFSComp.txtSupportsFeature LanguageFeature.ErrorForNonVirtualMembersOverrides/checkLanguageFeatureAndRecover … ErrorForNonVirtualMembersOverridesguard — keep only the enabled path and delete the legacy branchConsequence:
--disableLanguageFeature:ErrorForNonVirtualMembersOverridesis no longer a recognised feature name.Version mapping
fsharp/src/Compiler/Facilities/LanguageFeatures.fs
Line 202 in ea778bb
Feature string
fsharp/src/Compiler/FSComp.txt
Line 1596 in ea778bb
Part of #20139