Skip to content

Deploy FSharp.Core.xml in our IDE package - #10121

Merged
cartermp merged 2 commits into
dotnet:mainfrom
cartermp:fscore-xml-setup
Sep 15, 2020
Merged

Deploy FSharp.Core.xml in our IDE package#10121
cartermp merged 2 commits into
dotnet:mainfrom
cartermp:fscore-xml-setup

Conversation

@cartermp

@cartermpcartermp commented Sep 14, 2020

Copy link
Copy Markdown
Contributor

fixes#2926

@cartermp

Copy link
Copy Markdown
ContributorAuthor

Just to clarify, if I move the xml file in the directory that I think does setup definitions for, I get XML docs for FSharp.Core. So I know that works, it's just a question of if this is the correct fix

@brettfo

Copy link
Copy Markdown
Member

This change is the same as placing that XML file locally at C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSharp\FSharp.Core.xml, so if that manual step does what you want, then this will do what you want, too.

@cartermp

Copy link
Copy Markdown
ContributorAuthor

Yep, that's totes what I want. Here's the difference.

Before:

image

After:

image

My font is larger and different than the default btw

@cartermp
cartermp merged commit 4d2419a into dotnet:mainSep 15, 2020
@dsyme

Copy link
Copy Markdown
Contributor

Thank you for fixing this!

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Deploy FSharp.Core.xml in our IDE package
* yeet sigdata and optdata too
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intellisense and Quick Info do not show F# documentation in FSX files

4 participants

@cartermp@brettfo@dsyme@KevinRansom