Skip to content

Added langversion preview for FCS tests --- keep this open until we understand the failures - #10140

Closed
ncave wants to merge 1 commit into
dotnet:feature/fcswfrom
ncave:fcsw
Closed

Added langversion preview for FCS tests --- keep this open until we understand the failures#10140
ncave wants to merge 1 commit into
dotnet:feature/fcswfrom
ncave:fcsw

Conversation

@ncave

Copy link
Copy Markdown
Contributor
  • Added --langversion:preview for FCS tests.

@ncavencave mentioned this pull request Sep 17, 2020
2 tasks
@KevinRansom

Copy link
Copy Markdown
Contributor

@ncave , I think the individual test case needs to specify the version of F# that it needs. That way can have tests that ensure we don't break the old mechanism. So I don't think this is such a great idea.

@ncave

Copy link
Copy Markdown
ContributorAuthor

@KevinRansom Perhaps, although it would be nice to test backwards compatibility of preview features and make sure they're not breaking existing tests.

Feel free to close this PR, it was just meant to illustrate that some FCS tests are currently broken in this feature branch with --langversion:preview, somewhere around here, that's all.

@KevinRansom

Copy link
Copy Markdown
Contributor

Thanks @ncave, I expect we just ran into those issues with this PR: #10145 where we turned on FSharp 5.0 language features by default.

I'm going to close this and manage thise issues using #10145

Kevin

@KevinRansomKevinRansom changed the title Added langversion preview for FCS testsAdded langversion preview for FCS tests --- keep this open until we understand the failuresSep 17, 2020
@KevinRansom

Copy link
Copy Markdown
Contributor

@ncave, nope, gonna keep it open for a bit, to ensure we figure out the failures. Since the FSharp5 PR didn't see these same failures.

@dsyme

Copy link
Copy Markdown
Contributor

I have fixed this as part of #9510

@dsymedsyme closed this Oct 25, 2020
@ncave
ncave deleted the fcsw branch November 3, 2020 08:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ncave@KevinRansom@dsyme